http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |chris@bigballofwax.co.nz Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30718&action=edit Bug 9530: Adding a new Koha::Email module To test 1/ Apply patch 2/ run t/Koha_Email.t No changes to behaviour have been implemented yet -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30720&action=edit Bug 9530: Making changes to C4::Letters So notices using it (circulation, holds etc) will now use the new behaviour To test: 1/ Edit the new systempreferences (ReplytoDefault and ReturnpathDefault) 2/ Optionally edit the branch the mail will be sent from, adding email addresses 3/ Test some mails, a circulation alert, an acquisitions claim, or a newly created borrower alert 4/ Check that the mails have the correct From, Replyto and ReturnPath set The rules are If the values are set in the branch use that, else use the syspref -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30722&action=edit Bug 9530 Making changes to misc/cronjobs/runreport.pl Note: mail from this doesnt work in current master, so you may not be able to test this fully To Test 1/ Edit the new systempreferences (ReplytoDefault and ReturnpathDefault) 2/ Optionally edit the branch the mail will be sent from, adding email addresses 3/ Test sending a mail from scheduled reports, note you will need to have the fix for 12031 applied 4/ Check that the mails have the correct From, Replyto and ReturnPath set The rules are If the values are set in the branch use that, else use the syspref -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30724&action=edit Bug 9530 making changes to opac/opac-sendshelf.pl To Test 1/ Edit the new systempreferences (ReplytoDefault and ReturnpathDefault) 2/ Optionally edit the branch the mail will be sent from, adding email addresses 3/ Send a list from the public (OPAC) interface 4/ Check that the mails have the correct From, Replyto and ReturnPath set The rules are If the values are set in the branch use that, else use the syspref -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30725&action=edit Bug 9530 making changes to virtualshelves/sendshelf.pl To Test 1/ Edit the new systempreferences (ReplytoDefault and ReturnpathDefault) 2/ Optionally edit the branch the mail will be sent from, adding email addresses 3/ Send a list from the staff client 4/ Check that the mails have the correct From, Replyto and ReturnPath set The rules are If the values are set in the branch use that, else use the syspref -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30717|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30740&action=edit [SIGNED-OFF] Bug 9530: Adding sysprefs and making changes to the branch table To allow for separate Reply To and From email addresses for notices This patch will make no functional changes, it just sets up the db changes needed. To Test: Apply patch, upgrade DB, make sure everything still works fine (Or wait to test with following patches) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30719|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30742&action=edit [SIGNED-OFF] Bug 9350: Making changes so that you can add the new fields to branches To test 1/ Apply patch 2/ Add or Edit a branch, filling out the new fields 3/ Check that the changes saved http://bugs.koha-community.org/show_bug.cgi?id=9530 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- The patches I have signed off on I was able to test successfully. The patches for sending Carts and Lists did not appear to be working as expected.

4/ Check that the mails have the correct From, Replyto and ReturnPath set The rules are If the values are set in the branch use that, else use the syspref

All messages were being sent with the default replyto/returnpath address whether or not I was logged in as a patron from a library which had a library-specific value in the branches table. In other words, in cases where I expected to see the values in branches.branchreplyto and branches.branchreturnpath used they were not. Or is that not the expected behavior in these scripts? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30721|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30760&action=edit [SIGNED-OFF] Bug 9530 making changes to basket/sendbasket.pl To Test 1/ Edit the new systempreferences (ReplytoDefault and ReturnpathDefault) 2/ Optionally edit the branch the mail will be sent from, adding email addresses 3/ Test some mails, test sending a cart email from the staff client 4/ Check that the mails have the correct From, Replyto and ReturnPath set The rules are If the values are set in the branch use that, else use the syspref Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30724|0 |1 is obsolete| | --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30762&action=edit [SIGNED-OFF] Bug 9530 making changes to opac/opac-sendshelf.pl To Test 1/ Edit the new systempreferences (ReplytoDefault and ReturnpathDefault) 2/ Optionally edit the branch the mail will be sent from, adding email addresses 3/ Send a list from the public (OPAC) interface 4/ Check that the mails have the correct From, Replyto and ReturnPath set The rules are If the values are set in the branch use that, else use the syspref Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Chris Cormack from comment #15)

Ah yes sorry, I didn't change the existing behaviour for those.

Thanks for the clarification. That confirms that the behavior I saw in testing was correct. The last problem for me is that I did not see the correct behavior from misc/cronjobs/runreport.pl. I tested it along with the fix for Bug 12031 on a package install. The scheduled report ran and the email was sent correctly, but I didn't see the ReplyTo and ReturnPath headers as defined in my system preferences. I'm going to leave this as "needs signoff" in the hopes that someone else can confirm or deny. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #22 from Chris Cormack <chris@bigballofwax.co.nz> ---

Something else: The encoding for the emails is given as: charset="iso-8850-1" - but should probably be utf-8 like for the other emails?

I'll fix the others, but this one might be better on it's one bug. Chris -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen could you test again, please? The latest patch works nicely for me, after I figured out a problem with the git setup: I had to change the patch in scheduler.pl to point to my git install version of runreport.pl as it was looking in /usr/share... like for a package install. As that file also exists on my system, that caused some confusion :) Not sure about the paths, but that seems out of scope here. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31169|0 |1 is obsolete| | --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 31196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31196&action=edit [SIGNED-OFF] Bug 9530 Making changes to misc/cronjobs/runreport.pl Note: mail from this doesnt work in current master, so you may not be able to test this fully To Test 1/ Edit the new systempreferences (ReplytoDefault and ReturnpathDefault) 2/ Optionally edit the branch the mail will be sent from, adding email addresses 3/ Test sending a mail from scheduled reports, note you will need to have the fix for 12031 applied 4/ Check that the mails have the correct From, Replyto and ReturnPath set The rules are If the values are set in the branch use that, else use the syspref Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30740|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 31926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31926&action=edit [PASSED QA] Bug 9530: Adding sysprefs and making changes to the branch table To allow for separate Reply To and From email addresses for notices This patch will make no functional changes, it just sets up the db changes needed. To Test: Apply patch, upgrade DB, make sure everything still works fine (Or wait to test with following patches) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30742|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 31928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31928&action=edit [PASSED QA] Bug 9350: Making changes so that you can add the new fields to branches To test 1/ Apply patch 2/ Add or Edit a branch, filling out the new fields 3/ Check that the changes saved http://bugs.koha-community.org/show_bug.cgi?id=9530 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30760|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 31930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31930&action=edit [PASSED QA] Bug 9530 making changes to basket/sendbasket.pl To Test 1/ Edit the new systempreferences (ReplytoDefault and ReturnpathDefault) 2/ Optionally edit the branch the mail will be sent from, adding email addresses 3/ Test some mails, test sending a cart email from the staff client 4/ Check that the mails have the correct From, Replyto and ReturnPath set The rules are If the values are set in the branch use that, else use the syspref Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30762|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 31932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31932&action=edit [PASSED QA] Bug 9530 making changes to opac/opac-sendshelf.pl To Test 1/ Edit the new systempreferences (ReplytoDefault and ReturnpathDefault) 2/ Optionally edit the branch the mail will be sent from, adding email addresses 3/ Send a list from the public (OPAC) interface 4/ Check that the mails have the correct From, Replyto and ReturnPath set The rules are If the values are set in the branch use that, else use the syspref Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31196|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 31934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31934&action=edit [PASSED QA] Bug 9530 Making changes to misc/cronjobs/runreport.pl Note: mail from this doesnt work in current master, so you may not be able to test this fully To Test 1/ Edit the new systempreferences (ReplytoDefault and ReturnpathDefault) 2/ Optionally edit the branch the mail will be sent from, adding email addresses 3/ Test sending a mail from scheduled reports, note you will need to have the fix for 12031 applied 4/ Check that the mails have the correct From, Replyto and ReturnPath set The rules are If the values are set in the branch use that, else use the syspref Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- With one minor whitespace issue which I've fixed in a tiny followup patch, I'm now happy to pass QA on this. It works as expected for me and I can't find any regressions caused. The code all passes the QA scripts and the tests all still pass. This will be a great addition. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Chris! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #42 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Followup pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes.