[Bug 23013] New: Upgrade DataTables in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Bug ID: 23013 Summary: Upgrade DataTables in the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- I would like to upgrade the DataTables plugin used in the staff client. This process will include: - A new concatenated, minified version of the DataTables components. - Removal of the custom "four_button" pagination configuration in favor of the built-in "full" pagination type. - Update style of pagination bars, including some additions to improve responsive behavior. Table-specific CSS, including our DataTables CSS, is now in a separate file, "_tables.scss" which compiled into staff-global.css. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This is ready for testing, bug Bugzilla rejects the patches because of the size. I've posted the branch here: https://gitlab.com/koha-dev/koha-dev/tree/bug-23013-datatables-upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I have rebased the branch on GitLab. I have also put a downloadable patch here in case that helps: https://zivotdesign.com/download/bug-23013.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- On the vendor search: https://snag.gy/dLvxB2.jpg On the lists page: https://snag.gy/OuBWls.jpg On the checkouts page: - before https://snag.gy/VHtmrw.jpg - after https://snag.gy/N26y1d.jpg We lost the icons (x, v), the color on hover, and the size is not adjusted (see the last one, "Check in select all" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I forgot to yarn rebuild! Now I see: https://snag.gy/WolMes.jpg https://snag.gy/l5kxbG.jpg Which is better, but still a misalignment (minor). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- In my tests there is some minor misalignment which varies between browsers, usually between one and two pixels. The problem is greater if your page zoom has been increased. I can work on a follow-up, but I hope this can move forward if that's the only problem which has turned up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is looking pretty solid to me.. I can't find any issues (beyond the tiny misalignment problem Jonathan found) I'm inclined to jump to PQA, as two QA team members have now taken a look. What I would love to see if the rowGroup plugin (which only currently appears to be used in the checkouts table with minimal effect) bundled within it too now we're using the DT package builder... but that can wait for a followup bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23493 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 [Bug 24093] Sorting indicators broken on list contents view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27082 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27082 [Bug 27082] Problem when a basket has more of 20 orders with uncertain price -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247 [Bug 27247] Missing highlighting in Quote of the day -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29488 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 [Bug 29488] NumSavedReports system preference doesn't work -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org