[Bug 34072] New: Holds queue search interface hidden on small screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Bug ID: 34072 Summary: Holds queue search interface hidden on small screens Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The search interface for the holds queue (view_holdsqueue.pl) is hidden on small/narrow screens. To recreate in Chrome: - go to /cgi-bin/koha/circ/view_holdsqueue.pl - inspect something within the page to open the dev tools - press ctrl-shift-m to show the device toolbar - use the device toolbar to reduce the resolution of your window - observe that the search controls are lost at smaller resolutions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 152495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152495&action=edit Bug 34072: Remove float/clear from froms.scss To test: - go to /cgi-bin/koha/circ/view_holdsqueue.pl - inspect something within the page to open the dev tools - press ctrl-shift-m to show the device toolbar - use the device toolbar to reduce the resolution of your window - observe that the search controls are lost at smaller resolutions - Apply patch, regerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ), clear browser cache - Try again, you should now see the search controls - Since this patch changes forms.scss try some other forms in Koha at different screen sizes to make sure they still look correct -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152495|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 152542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152542&action=edit Bug 34072: Remove float/clear from froms.scss To test: - go to /cgi-bin/koha/circ/view_holdsqueue.pl - inspect something within the page to open the dev tools - press ctrl-shift-m to show the device toolbar - use the device toolbar to reduce the resolution of your window - observe that the search controls are lost at smaller resolutions - Apply patch, regerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ), clear browser cache - Try again, you should now see the search controls - Since this patch changes forms.scss try some other forms in Koha at different screen sizes to make sure they still look correct Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152542|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153227&action=edit Bug 34072: Remove float/clear from froms.scss To test: - go to /cgi-bin/koha/circ/view_holdsqueue.pl - inspect something within the page to open the dev tools - press ctrl-shift-m to show the device toolbar - use the device toolbar to reduce the resolution of your window - observe that the search controls are lost at smaller resolutions - Apply patch, regerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ), clear browser cache - Try again, you should now see the search controls - Since this patch changes forms.scss try some other forms in Koha at different screen sizes to make sure they still look correct Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I am not able to reproduce this bug in Koha before the patch. In my test, the holds queue sidebar filter doesn't disappear, it just gets moved down to below the holds queue table when the browser window is below a certain width. This is to be expected with anything in the sidebar. I think this patch should be reverted. It has unwanted side-effects (changing margins around fieldsets and submit buttons) and doesn't seem to fix any bug as far as I can tell. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 [Bug 34341] Revert Bug 34072: Holds queue search interface hidden on small screens -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34654 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org