https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Nice addition, Eivin. First I am stumbling over the hardcoded Swedish libris server in the code. Nothing against Sweden btw, but could we put that URL in a pref or config somewhere else? In this case you could add both prefs in one entry like some other prefs are organized (e.g. DefaultLongOverdueLostValue and DefaultLongOverdueDays ). Another small point is: Please add the new pref(s) to sysprefs.sql To test error checking, I changed the URL. Clicking on suggestions gave me: File does not exist: Can't connect to api.libris.kb.nl:80 (Bad hostname) LWP::Protocol::http::Socket: Bad hostname 'api.libris.kb.nl' Could you add some checks around line 34? What is the return value if get does not connect etc? Or when given an expired key? And in terms of security. You get $search from CGI param and directly feed it into LWP. Should we do some sanitizing here? When testing some searches, I always got only one alternative. Do you have examples where I get various results back? And the typo in spellcheking is hilarious. But please correct. Changing status to reflect need for some adjustments. -- You are receiving this mail because: You are watching all bug changes.