[Bug 19941] New: 'alt' and 'title' attributes not set when a hold is placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Bug ID: 19941 Summary: 'alt' and 'title' attributes not set when a hold is placed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Hold requests Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com
From reserve/request.tt:
- <img src="[% biblioloo.imageurl %]" alt="[% biblioloo.itypename %]" title="[% biblioloo.itypename %]" /> But this itypename is never set.
From the controller: $biblioloopiter{description} = $biblioitem->{description}; $biblioloopiter{itypename} = $biblioitem->{description};
$biblioitem comes from GetBiblioItemInfosOf which does not retrieve "description" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|'alt' and 'title' |'alt' and 'title' |attributes not set when a |attributes of the item type |hold is placed |image are not set when a | |hold is placed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70380&action=edit Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf This subroutine is only used once and can be replaced easily with a Koha::Biblioitems->search call Test plan: Test this on top of bug 19941 and confirm that the correct item types are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |tomascohen@gmail.com --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Jonathan, it seems to me that you submitted the patch for bug 19440 here, and forgot about this specific bug you were trying to fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70380|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19940 | Depends on| |19940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|jonathan.druart@bugs.koha-c |koha-bugs@lists.koha-commun |ommunity.org |ity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #2)
Jonathan, it seems to me that you submitted the patch for bug 19440 here, and forgot about this specific bug you were trying to fix.
Sounds like I lost that patch, or never wrote it! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Bug 19941 depends on bug 19940, which changed state. Bug 19940 Summary: Koha::Biblio - Remove GetBiblioItemInfosOf https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org