https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 146130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146130&action=edit Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30975 | Depends on| |30975 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- This one is actually only a cleanup patch that is not needed for bug 30975, but bug 30975 is needed for the cleanup to be possible. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I'm sure there is a reason that this has "Depends on: 30975" instead of "Blocks: 30975" like most of the other bugs for this change. While it is a bit tedious to say "y" to all the depends on bugs, it eventually fails when applying bug 30975. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 --- Comment #6 from David Nind <david@davidnind.com> --- How I tested ~~~~~~~~~~~~ 1. Applied bug 30975 (interactive, commented out the first patch) - this takes a while as you have to say yes to all the dependent bugs. 2. Remove the authorized value list currently used for 146$a in KTD. 3. Add the plugin unimarc_field_146a.pl to subfield 146$a for the default UNIMARC bibliographic framework in KTD. 4. Edit a bibliographic record. 5. Select the tag editor for the subfield. 6. Options and values should be the same before and after the patch is applied. Description ~~~~~~~~~~~ This is a standard UNIMARC value builder for a subfield - it displays a form to select the values that make up the subfield. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks Katrin, you beat me to it :) I confirm the that the plugin continues to work as before. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 --- Comment #10 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.