[Bug 16242] New: Move staff client JavaScript out of language directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Bug ID: 16242 Summary: Move staff client JavaScript out of language directory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 16241 In the staff client, the prog/en/js directory doesn't need to be duplicated for each translation since JavaScript files are not translated. These files should be moved to prog/js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16241 [Bug 16241] Move staff client CSS out of language directory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50130&action=edit Bug 16242 - Move staff client JavaScript out of language directory This patch moves the JavaScript files in prog/en/js to prog/js. JavaScript files do not need to be in the directory which is processed by the translator. To test, apply the patch and visit various pages in the staff client to confirm that JavaScript files are still loading correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50130|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50156&action=edit Bug 16242 - Move staff client JavaScript out of language directory This patch moves the JavaScript files in prog/en/js to prog/js. JavaScript files do not need to be in the directory which is processed by the translator. To test, apply the patch and visit various pages in the staff client to confirm that JavaScript files are still loading correctly. Revised: I intended for this to be built on top of Bug 15883 as well as Bug 16242. Now it is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50156|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 50470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50470&action=edit [SIGNED-OFF] Bug 16242 - Move staff client JavaScript out of language directory This patch moves the JavaScript files in prog/en/js to prog/js. JavaScript files do not need to be in the directory which is processed by the translator. To test, apply the patch and visit various pages in the staff client to confirm that JavaScript files are still loading correctly. Revised: I intended for this to be built on top of Bug 15883 as well as Bug 16242. Now it is. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of 15883 and 16241 All seems to work, js files pulled from new dir. No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I found a broken page: koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt:<script type="text/javascript" src="[% interface %]/prog/en/js/offlinecirc.js"></script> Can you please provide a follow-up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50629&action=edit Bug 16242 [Follow-up] Move staff client JavaScript out of language directory Correcting to a file I missed: circ/offline.tt. This patch corrects the path to offlinecirc.js. To test, go to Circulation -> Built-in offline circulation interface. There should be no errors in the console warning of missing files. The "Check out" link should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |hector.hecaxmmx@gmail.com --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Owen Please rebase patches Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 16242 - Move staff client JavaScript out of language directory When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, did you apply the dependent bug first? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 --- Comment #8 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Ohh Uppss noup Sorry for my mistake -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50629|0 |1 is obsolete| | --- Comment #9 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 50642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50642&action=edit Bug 16242 [Follow-up] Move staff client JavaScript out of language directory Correcting to a file I missed: circ/offline.tt. This patch corrects the path to offlinecirc.js. To test, go to Circulation -> Built-in offline circulation interface. There should be no errors in the console warning of missing files. The "Check out" link should work correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> File missed was fixed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50470|0 |1 is obsolete| | Attachment #50642|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50661&action=edit [PASSED QA] Bug 16242 - Move staff client JavaScript out of language directory This patch moves the JavaScript files in prog/en/js to prog/js. JavaScript files do not need to be in the directory which is processed by the translator. To test, apply the patch and visit various pages in the staff client to confirm that JavaScript files are still loading correctly. Revised: I intended for this to be built on top of Bug 15883 as well as Bug 16242. Now it is. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of 15883 and 16241 All seems to work, js files pulled from new dir. No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50664&action=edit [PASSED QA] Bug 16242 [Follow-up] Move staff client JavaScript out of language directory Correcting to a file I missed: circ/offline.tt. This patch corrects the path to offlinecirc.js. To test, go to Circulation -> Built-in offline circulation interface. There should be no errors in the console warning of missing files. The "Check out" link should work correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> File missed was fixed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for the 16.05 release. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21029 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 [Bug 21029] "Suspend until" in modal in staff patron account is not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 [Bug 21030] Date widget on suspend modal not working correctly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org