[Bug 13247] New: opacuserjs is not compatible with tracking's tools like Piwik
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 Bug ID: 13247 Summary: opacuserjs is not compatible with tracking's tools like Piwik Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: stephane.delaune@biblibre.com QA Contact: testopia@bugs.koha-community.org some tools needs to add javascript just before the </body> tag .This is particularly the case of statistical : - Piwik (the page "http://developer.piwik.org/api-reference/tracking-javascript" indicates "copy and paste the JavaScript Tracking code into your pages, just before the </body> tag") - Google Analytics (the page "https://developers.google.com/analytics/devguides/collection/gajs/gaTracking..." indicates "This tracking code snippet should be included in your site's pages so that it appears at the bottom of the page's HTML (or generated-HTML) structure, before the closing <body> tag.") To use these tools with the syspref "opacuserjs", its use should be moved to the end of opac-bottom.inc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |stephane.delaune@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 --- Comment #1 from stephane.delaune@biblibre.com --- Created attachment 33521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33521&action=edit proposed patch proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 33521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33521 proposed patch Review of attachment 33521: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13247&attachment=33521) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ +238,5 @@
[% PROCESS jsinclude %]
+<script type="text/javascript"> + //<![CDATA[ + [% IF ( opacuserjs ) %][% opacuserjs %][% END %]
Wouldn't it make more sense to put the IF and END around the entire script? Why generate a hollow script section? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to M. Tompsett from comment #2)
Wouldn't it make more sense to put the IF and END around the entire script? Why generate a hollow script section?
I agree. Other than that I think this change will work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33521|0 |1 is obsolete| | --- Comment #4 from stephane.delaune@biblibre.com --- Created attachment 33548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33548&action=edit new proposed patch new proposed patch taking into account the suggestions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33548|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33579&action=edit [SIGNED-OFF] Bug 13247 - Move opacuserjs at the end of opac-bottom.inc This patch makes opacuserjs compatible with tracking tools like Piwik Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33579|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33600&action=edit [PASSED QA] Bug 13247 - Move opacuserjs at the end of opac-bottom.inc This patch makes opacuserjs compatible with tracking tools like Piwik Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Small change to enable use of opacuserjs for statistical tools like Piwik by moving it right above </body>. Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13247 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Stephane! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org