https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |alex.sassmannshausen@ptfs-e | |urope.com Status|NEW |ASSIGNED Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 --- Comment #3 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 56396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56396&action=edit Bug 16083 Allow cli overrides for makefile settings. Currently the Makefile.pl script only accepts the '--prev-install-log' commandline flag for reading Koha configuration values from the previous installation. The Makefile does not have help output. The aim of this bug report is to add 2 things: - --help output - commandline parameters that should allow automating many of the common settings if desired - when commandline parameters are not passed we simply fall back to the interactive method of old Test Plan: - Run the Makefile without parameters — the script should work as before. - Run the script with the '-h' flag — it should output help. - Run the script with any number of additional legal flags — the script should skip those questions in its interactive mode. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Reworked the log message with Bugzilla comments. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49235|0 |1 is obsolete| | Attachment #56396|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58555&action=edit Bug 16083 Allow cli overrides for makefile settings. Currently the Makefile.pl script only accepts the '--prev-install-log' commandline flag for reading Koha configuration values from the previous installation. The Makefile does not have help output. The aim of this bug report is to add 2 things: - --help output - commandline parameters that should allow automating many of the common settings if desired - when commandline parameters are not passed we simply fall back to the interactive method of old Test Plan: - Run the Makefile without parameters — the script should work as before. - Run the script with the '-h' flag — it should output help. - Run the script with any number of additional legal flags — the script should skip those questions in its interactive mode. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Reworked the log message with Bugzilla comments. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: perltidy GetOptions block -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 --- Comment #6 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 58612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58612&action=edit Bug 16083: [QA FOLLOWUP] Add more cli arguments. * Makefile.PL: Add `zebra_sru_host`, `zebra_sru_biblios_port` & `zebra_sru_authorities_port` as possible command line arguments. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Alex Sassmannshausen from comment #7)

My latest patch adds SRU Biblio and Authority port numbers as well as SRU Host commandline arguments.

Thanks that looks great. I'm happy to leave this at Passed QA now. :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.