https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37882 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171246&action=edit Bug 37882: Add class for statuses to SCO module for holds and renewals This patch should have no visual impact, but will add several classes To test: 1 - Place some holds and checkout items to a patron Ensure some items cannot renew, and set a hold with a library as pickup location, then unset library as a location in Library admin page 2 - View their record in sco 3 - Apply patch 4 - 'Finish' and start a new SCO session as same user 5 - No visual difference 6 - Inspect issues/hold to see if new psans are present -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37882 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37882 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171246|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171262&action=edit Bug 37882: Add class for statuses to SCO module for holds and renewals This patch should have no visual impact, but will add several classes To test: 1 - Place some holds and checkout items to a patron Ensure some items cannot renew, and set a hold with a library as pickup location, then unset library as a location in Library admin page 2 - View their record in sco 3 - Apply patch 4 - 'Finish' and start a new SCO session as same user 5 - No visual difference 6 - Inspect issues/hold to see if new psans are present Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37882 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov --- Comment #4 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Ooh, this is a great addition! Since this is a string patch that is partly for users, I am going to nitpick the strings a bit, though... Do the classes need to exactly match the reason codes passed to the template? If not, I'd argue for the following changes for better consistency: 1. The classes should match our vocabulary conventions (for example, toomanyholdstoday instead of toomanyreservestoday) 2. Consistent use of underscores in class names These don't have to be a blocker if there's a good reason to keep it as-is, but if we can have more consistency that will make it easier for users to write their own customizations, then I think we should. Setting to FQA for feedback. -- You are receiving this mail because: You are watching all bug changes.