[Bug 5215] New: Barcode field not cleared when using "Add and Duplicate" option on additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5215 Summary: Barcode field not cleared when using "Add and Duplicate" option on additem.pl Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: cnighswonger@foundations.edu QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Estimated Hours: 0.0 The barcode field is not cleared/incremented properly when using the "Add and Duplicate" option. Rather it is pre-populated with the previously used barcode which causes additem.pl to return a duplicate barcode error if the cataloger does not catch the mistake. The problem is caused by the fact that the current item record is simply duplicated and re-loaded into the form. The solution is to add code which either pre-populates with the next barcode number if the incremental pattern is set or clears the p subfield if one of the various patterns using the javascript plugin is selected. A pull request with an implementation of this will follow. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5215 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored AssignedTo|gmcharlt@gmail.com |cnighswonger@foundations.ed | |u -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5215 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #1 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-09-10 17:15:18 UTC --- Pull request sent. Patch available here: http://git.koha-community.org/gitweb/?p=wip/koha-fbc.git;a=commit;h=41f85c30... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5215 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5215 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Does not apply --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2010-12-16 15:43:14 UTC --- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying Bug 5215 - Barcode field not cleared when using "Add and Duplicate" option on additem.pl error: patch failed: cataloguing/additem.pl:69 error: cataloguing/additem.pl: patch does not apply Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merged cataloguing/additem.pl CONFLICT (content): Merge conflict in cataloguing/additem.pl Failed to merge in the changes. Patch failed at 0001. When you have resolved this problem run "git-am -i -3 --resolved". If you would prefer to skip th -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5215 --- Comment #3 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-12-16 16:14:04 UTC --- (In reply to comment #2)
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying Bug 5215 - Barcode field not cleared when using "Add and Duplicate" option on additem.pl error: patch failed: cataloguing/additem.pl:69 error: cataloguing/additem.pl: patch does not apply Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merged cataloguing/additem.pl CONFLICT (content): Merge conflict in cataloguing/additem.pl Failed to merge in the changes. Patch failed at 0001. When you have resolved this problem run "git-am -i -3 --resolved". If you would prefer to skip th
Rebased and pushed. Please try again as this applies cleanly to the current HEAD. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5215 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-07 22:10:35 UTC --- This is in master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5215 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com Patch Status|Patch Pushed |Failed QA --- Comment #5 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2011-07-08 09:58:16 UTC --- As far as I'm concerned, the barcode is properly cleared when needed, but it is not incremented when the incremental pattern is set. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5215 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Patch Status|Failed QA |Does not apply --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> 2011-07-22 10:30:45 UTC --- Applying: Bug 5215 - Barcode field not cleared when using "Add and Duplicate" option on additem.pl Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging cataloguing/additem.pl CONFLICT (content): Merge conflict in cataloguing/additem.pl Failed to merge in the changes. Patch failed at 0001 Bug 5215 - Barcode field not cleared when using "Add and Duplicate" option on additem.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5215 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Patch Status|Does not apply |Patch Pushed Resolution| |FIXED --- Comment #7 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-07-22 13:50:49 UTC --- (In reply to comment #6)
Applying: Bug 5215 - Barcode field not cleared when using "Add and Duplicate" option on additem.pl Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging cataloguing/additem.pl CONFLICT (content): Merge conflict in cataloguing/additem.pl Failed to merge in the changes. Patch failed at 0001 Bug 5215 - Barcode field not cleared when using "Add and Duplicate" option on additem.pl
See comment #4... http://git.koha-community.org/gitweb/?p=koha.git&a=search&h=HEAD&st=commit&s=5215 Closing to avoid further confusion. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5215 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org