[Bug 27685] New: Syspref OpacSuppression has no effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 Bug ID: 27685 Summary: Syspref OpacSuppression has no effect Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org This syspref is enabled on our install and was working until last update to 19.11 a priori. We add a 099 tag to the notices without items and our zebra config is like this : <!-- 099$o Suppress --> <index_subfields tag="099" subfields="o"> <target_index>Suppress:w</target_index> <target_index>Suppress:n</target_index> </index_subfields> Seems that in 19.11, the Suppress field is hard coded to 942 tag ttps://git.koha-community.org/Koha-community/Koha/src/branch/19.11.x/opac/opac-detail.pl#L118 Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Searching Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Syspref OpacSuppression |Syspref OpacSuppression has |has no effect |no effect on the | |bibliographic detail page CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|19.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20846, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11690 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, I believe this comes from MARC21 which is much more standardized than UNIMARC at this point. I am not sure if we would not even need a new preference to be able to tell what people have set their suppress index to :( What is the problem you see? Search should still be blocked, is it possible to go to the detail page by link directly? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #2 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Yes you can display the detail page only with the direct link on the biblionumber (opac-detail.pl?biblionumber=nnnn). To be honest there is little chance that it could be used like this except if it had been kept previously in a list but never know. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |10195 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 [Bug 10195] Records hidden with OpacSuppression can still be accessed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I've been thinking it would be good to have a "suppressed" or "hidden" column in the "biblio" table... it would help prevent this sort of situation I reckon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Might be fixed by bug 27272. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #4)
Might be fixed by bug 27272.
Hum, forget that, it won't. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's a bug and a regression. The direct link by biblionumber should not work - and it didn't in the past. How a direct link behaves, is supposed to be controlled by the OpacSuppressionRedirect system preference. There is something broken here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Updating severity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #6)
I think it's a bug and a regression.
The direct link by biblionumber should not work - and it didn't in the past.
How a direct link behaves, is supposed to be controlled by the OpacSuppressionRedirect system preference. There is something broken here.
Do we know which version introduced the regression? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sadly it looks like it was a while ago already, I have been seeing the issue on 20.11 in testing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #6)
I think it's a bug and a regression.
The direct link by biblionumber should not work - and it didn't in the past.
How a direct link behaves, is supposed to be controlled by the OpacSuppressionRedirect system preference. There is something broken here.
Could the exact problem be detailed? Using koha-testing-docker, I turned on OpacSuppression, updated 942$n for bib 29, and now when I go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 it redirects me to http://localhost:8080/cgi-bin/koha/opac-blocked.pl I updated to OpacSuppressionRedirect to use a 404 instead and that's working too. So this might already be fixed in master? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, it could be. I am seeing the issue in 20.11. It would be great if we could limit it down a bit more. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Could the exact problem be detailed?
There is not much to detail I think. The record is not turning up in search, but can be accessed by biblionumber link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 'In discussion' without any argument is a bit mean :) Tested with Zebra and Elasticsearch on master: hiding the detail page works correctly in there. It also appears ok with Zebra in 20.11. I cannot check with Elastic and 20.11, but it might not make a difference. Lyon 3, can you add more details? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #13)
'In discussion' without any argument is a bit mean :)
I thought it was gentler than marking Resolved Invalid 😅 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 --- Comment #15 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- I confirm that the problem seems to be solved (for both Zebra and Elastic Search). In prod (indexed with Zebra) : example with biblionumber 3652 wich has the Suppress field enabled (099$0 = 1). Searching with the terms "Einstein 1905" does not get this title in the results. Searching for detailed page "https://catalogue.univ-lyon3.fr/cgi-bin/koha/opac-detail.pl?biblionumber=365..." get 404 error. Same searches on our preprod instance (with Elastic search in test) : same results. Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I suspect that my records were not properly indexed, can't replicate either. Closing WORKSFORME. Please reopen if necessary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org