[Bug 38536] New: Patrons requesting modifications: Expand correct panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Bug ID: 38536 Summary: Patrons requesting modifications: Expand correct panel Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 35402 We have code for expanding the requested accordion panel on the patrons requesting modifications page which needs to be updated for Bootstrap 5. If no borrowernumber has been passed to the template the first panel should expand by default. If a borrowernumber has been passed, that patron's section should automatically expand. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174989&action=edit Bug 38536: Patrons requesting modifications: Expand correct panel This patch updates the JavaScript on the patrons requesting modification page in order to make it work following the upgrade to Bootstrap 5. The automatic panel expansion is broken. To test, apply the patch and enable, if necessary, the OPACPatronDetails system preference. - Log in to the OPAC and submit changes to your personal details. - Do this again as a different user so that there is more than one pending request. - From the staff interface home page, follow the link for "Patrons requesting modifications" - Upon loading, the "Update patron records" page should automatically expand the first panel. - Locate the patron record for the second of the patrons you requested updates for. - From that patron's detail page, follow the "Review pending modifications" link. - The panel containing that patron's information should expand by default. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174989|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 174991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174991&action=edit Bug 38536: Patrons requesting modifications: Expand correct panel This patch updates the JavaScript on the patrons requesting modification page in order to make it work following the upgrade to Bootstrap 5. The automatic panel expansion is broken. To test, apply the patch and enable, if necessary, the OPACPatronDetails system preference. - Log in to the OPAC and submit changes to your personal details. - Do this again as a different user so that there is more than one pending request. - From the staff interface home page, follow the link for "Patrons requesting modifications" - Upon loading, the "Update patron records" page should automatically expand the first panel. - Locate the patron record for the second of the patrons you requested updates for. - From that patron's detail page, follow the "Review pending modifications" link. - The panel containing that patron's information should expand by default. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the panels in release notes| |the staff interface on the | |patrons requesting | |modifications page. The | |automatic panel expansion | |was not working as | |expected: | |- The first panel | |should expand by default | |(when there is no patron | |selected) | |- The panel | |should expand when a patron | |is selected (when opening | |from the patron's record) | |(This is related to the | |OPAC and staff interface | |Bootstrap 5 upgrade in Koha | |24.11.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174991|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175000&action=edit Bug 38536: Patrons requesting modifications: Expand correct panel This patch updates the JavaScript on the patrons requesting modification page in order to make it work following the upgrade to Bootstrap 5. The automatic panel expansion is broken. To test, apply the patch and enable, if necessary, the OPACPatronDetails system preference. - Log in to the OPAC and submit changes to your personal details. - Do this again as a different user so that there is more than one pending request. - From the staff interface home page, follow the link for "Patrons requesting modifications" - Upon loading, the "Update patron records" page should automatically expand the first panel. - Locate the patron record for the second of the patrons you requested updates for. - From that patron's detail page, follow the "Review pending modifications" link. - The panel containing that patron's information should expand by default. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Bug 38536 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Version(s)|25.05.00,24.11.01 |25.05.00,24.11.01,24.05.06 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Backported to 24.05.x for 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Wainui Witika-Park from comment #6)
Backported to 24.05.x for 24.05.06
Depends on Bug 35402 not in 24.05.x You may have to revert. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00,24.11.01,24.05.06 |25.05.00,24.11.01 released in| | --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to Fridolin Somers from comment #7)
(In reply to Wainui Witika-Park from comment #6)
Backported to 24.05.x for 24.05.06
Depends on Bug 35402 not in 24.05.x You may have to revert.
Thanks, reverted from 24.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|25.05.00,24.11.01 |25.05.00,24.11.01,24.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Pushed to 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Needs documenting --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38536 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #11 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org