[Bug 33329] New: GET /biblios encoding wrong when UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Bug ID: 33329 Summary: GET /biblios encoding wrong when UNIMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com CC: tomascohen@gmail.com Same as bug 32336 but for listing biblios. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32336, 32734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336 [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 [Bug 32734] REST API: Add a list endpoint for Biblios -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 148629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148629&action=edit Bug 33329: Regression tests This patch introduces tests for the bug highlighted on bug 32336, but in the context of lists of records. To reproduce: 1. Run: $ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => FAIL: Test fail, encoding is bad! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi, only submitted regression tests while waiting for my flight. Now is time to take off! See you soon! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Bug 33329 depends on bug 32734, which changed state. Bug 32734 Summary: REST API: Add a list endpoint for Biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|julian.maurice@biblibre.com |tomascohen@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 149708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149708&action=edit Bug 33329: Correctly handle UNIMARC encoding for biblios This patch introduces the same treatment we had for bug 32336, this time for Koha::Objects::Record::Collections. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail! Encoding is wrong for UNIMARC! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 [Bug 32735] REST API: Add a list endpoint for Authorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148629|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 149734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149734&action=edit Bug 33329: Regression tests This patch introduces tests for the bug highlighted on bug 32336, but in the context of lists of records. To reproduce: 1. Run: $ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => FAIL: Test fail, encoding is bad! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149708|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 149735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149735&action=edit Bug 33329: Correctly handle UNIMARC encoding for biblios This patch introduces the same treatment we had for bug 32336, this time for Koha::Objects::Record::Collections. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail! Encoding is wrong for UNIMARC! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149734|0 |1 is obsolete| | Attachment #149735|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150375&action=edit Bug 33329: Regression tests This patch introduces tests for the bug highlighted on bug 32336, but in the context of lists of records. To reproduce: 1. Run: $ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => FAIL: Test fail, encoding is bad! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150376&action=edit Bug 33329: Correctly handle UNIMARC encoding for biblios This patch introduces the same treatment we had for bug 32336, this time for Koha::Objects::Record::Collections. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail! Encoding is wrong for UNIMARC! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org