[Bug 28937] New: Use Flatpickr on circulation and patron pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Bug ID: 28937 Summary: Use Flatpickr on circulation and patron pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 28928 Bug 28376 added Flatpickr for date and time-picker widgets, with the goal of replacing all usage of jQueryUI's datepicker widget. This bug will cover Flatpickr additions to these pages/files: includes/borrower_debarments.inc includes/calendar.inc includes/holds_table.inc circ/circulation.tt circ/overdue.tt circ/pendingreserves.tt circ/reserveratios.tt members/memberentrygen.tt members/moremember.tt reserve/request.tt prog/js/checkouts.js prog/js/holds.js Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928 [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr introduction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 [Bug 28938] Correct Flatpickr's default 12hr time formatting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28938 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 [Bug 28938] Correct Flatpickr's default 12hr time formatting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28928 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928 [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr introduction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 [Bug 28938] Correct Flatpickr's default 12hr time formatting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124428&action=edit Bug 28937: Use Flatpickr on circulation and patron pages This patch replaces the use of jQueryUI's datepicker on circulation and patron-related pages. The patch modifies Flatpickr's default configuration (in calendar.inc) so that it has the following features: - A Flatpickr input with a "futuredate" class will require that the selected date be after today. - The Flatpickr input field will be wrapped in a container to facilitate better CSS styling. - Generic handling of paired date fields is enabled using ".flatpickrfrom" and ".flatpickrto" field classes. This mimics the same feature we have for jQueryUI datepickers using ".datepickerfrom" and ".datepickerto". This patch also removes an unused function which was repeated in three templates: validate1. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Circulation and check out to a patron. - Open the Restrictions tab and click "Add manual restriction." - In the "Expiration" field, test that the Flatpickr widget works correctly and limits to dates after today. - Enable the SpecifyDueDate preference if necessary. - Test the behavior of the SpecifyDueDate controls: Setting a date, clearing a date, session persistence. - Enable the SuspendHoldsIntranet system preference if necessary. - Check out to a patron with existing holds. - Open the Holds tab and click the "Suspend" button for one of the holds. - In the modal window which appears, check that the Flatpickr widget works correctly and limits to dates after today. - At the bottom of the table of holds, test that the "Suspend all holds" Flatpickr works correctly and limits to dates after today. - Perform this same test from the patron details page. - Enable the BatchCheckouts system preference if necessary. - Open a patron record and click "Batch check out" in the left-hand sidebar menu. - Test that the "Hard due date" Flatpickr works correctly as a date and time picker. - Go to Circulation -> Overdues. - Test that the date due filters in the sidebar work correctly and are linked, e.g. the "to" field cannot be before the "from" field. - Perform the same test here: Circulation -> Holds to pull; and here: Circulation -> Hold ratios. - Enable the HouseboundModule system preference if necessary. - Check out to or view details of a patron. - Click "Housebound" in the sidebar menu. - Save delivery day and frequency settings for that patron. - Click "Add a new delivery." - Test that the "Date" Flatpickr widget works correctly. - Go to Patrons -> A patron record -> Edit. - Test that Flatpickr widgets work on the following fields: - Date of birth - Registration date & Expiration date (linked). - Patron restrictions -> Add manual restriction -> Expiration. - View a bibliographic record and start the process of placing a hold. - After selecting a patron, test the "Hold starts on" and "Hold expires on" date fields. The fields should be linked and each should limit to future dates. - Confirm that the dates are saved correctly when you submit the hold. - Locate a bibliographic record with multiple holds and view the holds. - In the table of holds, test each date field: Date, expiration, and suspend-until. - Test that Flatpickr's static "formatDate" method is working correctly: - Locate a bibliographic record's item so that there is text in both the "Public note" and "Non-public note" field. - Check that item out to a patron. - After the page reloads the public and non-public notes should be shown under the checkout title highlighted in red. - Check for references to a "validate1" function. There should be none. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28945 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945 [Bug 28945] Use Flatpickr on administration pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28949 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949 [Bug 28949] Use Flatpickr on reports pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Bug 28937 depends on bug 28938, which changed state. Bug 28938 Summary: Correct Flatpickr's default 12hr time formatting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28958 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958 [Bug 28958] Use Flatpickr on serials pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961 [Bug 28961] Use Flatpickr on tools pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963 [Bug 28963] Use Flatpickr on calendar page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124428|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 124630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124630&action=edit Bug 28937: Use Flatpickr on circulation and patron pages This patch replaces the use of jQueryUI's datepicker on circulation and patron-related pages. The patch modifies Flatpickr's default configuration (in calendar.inc) so that it has the following features: - A Flatpickr input with a "futuredate" class will require that the selected date be after today. - The Flatpickr input field will be wrapped in a container to facilitate better CSS styling. - Generic handling of paired date fields is enabled using ".flatpickrfrom" and ".flatpickrto" field classes. This mimics the same feature we have for jQueryUI datepickers using ".datepickerfrom" and ".datepickerto". This patch also removes an unused function which was repeated in three templates: validate1. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Circulation and check out to a patron. - Open the Restrictions tab and click "Add manual restriction." - In the "Expiration" field, test that the Flatpickr widget works correctly and limits to dates after today. - Enable the SpecifyDueDate preference if necessary. - Test the behavior of the SpecifyDueDate controls: Setting a date, clearing a date, session persistence. - Enable the SuspendHoldsIntranet system preference if necessary. - Check out to a patron with existing holds. - Open the Holds tab and click the "Suspend" button for one of the holds. - In the modal window which appears, check that the Flatpickr widget works correctly and limits to dates after today. - At the bottom of the table of holds, test that the "Suspend all holds" Flatpickr works correctly and limits to dates after today. - Perform this same test from the patron details page. - Enable the BatchCheckouts system preference if necessary. - Open a patron record and click "Batch check out" in the left-hand sidebar menu. - Test that the "Hard due date" Flatpickr works correctly as a date and time picker. - Go to Circulation -> Overdues. - Test that the date due filters in the sidebar work correctly and are linked, e.g. the "to" field cannot be before the "from" field. - Perform the same test here: Circulation -> Holds to pull; and here: Circulation -> Hold ratios. - Enable the HouseboundModule system preference if necessary. - Check out to or view details of a patron. - Click "Housebound" in the sidebar menu. - Save delivery day and frequency settings for that patron. - Click "Add a new delivery." - Test that the "Date" Flatpickr widget works correctly. - Go to Patrons -> A patron record -> Edit. - Test that Flatpickr widgets work on the following fields: - Date of birth - Registration date & Expiration date (linked). - Patron restrictions -> Add manual restriction -> Expiration. - View a bibliographic record and start the process of placing a hold. - After selecting a patron, test the "Hold starts on" and "Hold expires on" date fields. The fields should be linked and each should limit to future dates. - Confirm that the dates are saved correctly when you submit the hold. - Locate a bibliographic record with multiple holds and view the holds. - In the table of holds, test each date field: Date, expiration, and suspend-until. - Test that Flatpickr's static "formatDate" method is working correctly: - Locate a bibliographic record's item so that there is text in both the "Public note" and "Non-public note" field. - Check that item out to a patron. - After the page reloads the public and non-public notes should be shown under the checkout title highlighted in red. - Check for references to a "validate1" function. There should be none. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- This seems to be working nicely, I tested on all the pages with each of the different 'dateformat' options. Love the look of Flatpickr! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 [Bug 28982] Use Flatpickr on onboarding pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983 [Bug 28983] Use Flatpickr on various pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 [Bug 28942] Use Flatpickr on acquisitions pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Love this work.. but.. I'm afraid it fell at the first hurdle for me; accessibility is affected. I tested the check-in screen; Upon navigating to the due date input the widget pops up as expected, however the focus remains in the input box and the widget cannot be navigated or submitted via keyboard. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #4)
Love this work.. but..
I'm afraid it fell at the first hurdle for me; accessibility is affected.
I tested the check-in screen; Upon navigating to the due date input the widget pops up as expected, however the focus remains in the input box and the widget cannot be navigated or submitted via keyboard.
But would that not be the intended behavior if we want to allow for direct input of the date in the input field for accessibility? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #5)
(In reply to Martin Renvoize from comment #4)
Love this work.. but..
I'm afraid it fell at the first hurdle for me; accessibility is affected.
I tested the check-in screen; Upon navigating to the due date input the widget pops up as expected, however the focus remains in the input box and the widget cannot be navigated or submitted via keyboard.
But would that not be the intended behavior if we want to allow for direct input of the date in the input field for accessibility?
Also it seems that the behaviour is the same with our current widget: * new patron * tab to date of birth input field * enter date with keyboard - ok * try to use widget with keyboard keys/arrows - doesn't work To me that makes sense. People preferring the mouse, will use the mouse to handle the widget, but people preferring the keyboard, will probably want to type the date directly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #6)
But would that not be the intended behavior if we want to allow for direct input of the date in the input field for accessibility?
For full accessibility, you should support both options ;)
Also it seems that the behaviour is the same with our current widget:
* new patron * tab to date of birth input field * enter date with keyboard - ok * try to use widget with keyboard keys/arrows - doesn't work
I worked on this recently for an accessibility audit of the OPAC ;). Try the arrow keys whilst holding ctrl or shift ;). Holding ctrl sets the arrow keys to navigate through days, holding shift allows them to navigate month to month, year to year. (This also works with the screen reader, reading out the date after a small pause on your selected date. I think I even submitted a documentation patch for this.. it was a requirement to ensure it worked this way to pass the accessibility audit undertaken by UK Gov. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Does it mean we should drop Flatpickr and revert what has been pushed already? It seems that their accessibility issues don't get much attention: https://github.com/flatpickr/flatpickr/milestone/5 See also https://github.com/flatpickr/flatpickr/issues/1329 Workaround suggested at https://github.com/flatpickr/flatpickr/issues/1329#issuecomment-380805839 (In reply to Martin Renvoize from comment #7)
(In reply to Katrin Fischer from comment #6)
But would that not be the intended behavior if we want to allow for direct input of the date in the input field for accessibility?
For full accessibility, you should support both options ;)
Also it seems that the behaviour is the same with our current widget:
* new patron * tab to date of birth input field * enter date with keyboard - ok * try to use widget with keyboard keys/arrows - doesn't work
I worked on this recently for an accessibility audit of the OPAC ;).
Try the arrow keys whilst holding ctrl or shift ;). Holding ctrl sets the arrow keys to navigate through days, holding shift allows them to navigate month to month, year to year. (This also works with the screen reader, reading out the date after a small pause on your selected date.
I think I even submitted a documentation patch for this.. it was a requirement to ensure it worked this way to pass the accessibility audit undertaken by UK Gov.
I do confirm that ctrl allows to navigate through days, however shift does nothing for me. Alt does but conflicts with browser's shortcuts (tab switch). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124630|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125355&action=edit Bug 28937: Use Flatpickr on circulation and patron pages This patch replaces the use of jQueryUI's datepicker on circulation and patron-related pages. The patch modifies Flatpickr's default configuration (in calendar.inc) so that it has the following features: - A Flatpickr input with a "futuredate" class will require that the selected date be after today. - The Flatpickr input field will be wrapped in a container to facilitate better CSS styling. - Generic handling of paired date fields is enabled using ".flatpickrfrom" and ".flatpickrto" field classes. This mimics the same feature we have for jQueryUI datepickers using ".datepickerfrom" and ".datepickerto". This patch also removes an unused function which was repeated in three templates: validate1. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Circulation and check out to a patron. - Open the Restrictions tab and click "Add manual restriction." - In the "Expiration" field, test that the Flatpickr widget works correctly and limits to dates after today. - Enable the SpecifyDueDate preference if necessary. - Test the behavior of the SpecifyDueDate controls: Setting a date, clearing a date, session persistence. - Enable the SuspendHoldsIntranet system preference if necessary. - Check out to a patron with existing holds. - Open the Holds tab and click the "Suspend" button for one of the holds. - In the modal window which appears, check that the Flatpickr widget works correctly and limits to dates after today. - At the bottom of the table of holds, test that the "Suspend all holds" Flatpickr works correctly and limits to dates after today. - Perform this same test from the patron details page. - Enable the BatchCheckouts system preference if necessary. - Open a patron record and click "Batch check out" in the left-hand sidebar menu. - Test that the "Hard due date" Flatpickr works correctly as a date and time picker. - Go to Circulation -> Overdues. - Test that the date due filters in the sidebar work correctly and are linked, e.g. the "to" field cannot be before the "from" field. - Perform the same test here: Circulation -> Holds to pull; and here: Circulation -> Hold ratios. - Enable the HouseboundModule system preference if necessary. - Check out to or view details of a patron. - Click "Housebound" in the sidebar menu. - Save delivery day and frequency settings for that patron. - Click "Add a new delivery." - Test that the "Date" Flatpickr widget works correctly. - Go to Patrons -> A patron record -> Edit. - Test that Flatpickr widgets work on the following fields: - Date of birth - Registration date & Expiration date (linked). - Patron restrictions -> Add manual restriction -> Expiration. - View a bibliographic record and start the process of placing a hold. - After selecting a patron, test the "Hold starts on" and "Hold expires on" date fields. The fields should be linked and each should limit to future dates. - Confirm that the dates are saved correctly when you submit the hold. - Locate a bibliographic record with multiple holds and view the holds. - In the table of holds, test each date field: Date, expiration, and suspend-until. - Test that Flatpickr's static "formatDate" method is working correctly: - Locate a bibliographic record's item so that there is text in both the "Public note" and "Non-public note" field. - Check that item out to a patron. - After the page reloads the public and non-public notes should be shown under the checkout title highlighted in red. - Check for references to a "validate1" function. There should be none. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125356&action=edit Bug 28937: (QA follow-up) Accessability improvement This patch adds a keydown event listener onto the flatpickr instance and looks for the down arrow key. When such an event is detected we take that to mean the user wants to keyboard navigate the calendar widget and so disable the buggy allowInput option allowing keyboard navigation to work as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I think my follow-up should resolve the accessibility concerns I had.. Please test it. With that in mind, I'm happy to PQA on the original patch, but would really like someone to SO my follow-up to check for anything I've missed. In short, I add a listener onto the flatpickr instance at it's creation time and watch for the 'Down arrow' keydown even.. upon detection of that event we temporarily disable the buggy allowInput configuration option of the flatpickr instant and restore the keyboard navigation of the picker widget in doing so. The only caveat I can see with this is that there's not a clear keyboard navigable escape back to the input to get manual input back once you've enabled down arrowed into the widget... hitting escape does close the widget, but it drops you back at totally different focus location for some reason. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We should document this feature too.. "Down arrow" when in a flatpickr input field will focus the flatpickr widget for keyboard navigation. Arrow keys can then be used to navigate days, holding ctrl whilst using the arrow keys switched navigation to month and year fields. Hitting return will submit the selected value, or if this is a datetime picker it will submit the date part and move the focus to the timepicker for the next selection step. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125356|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125363&action=edit Bug 28937: (QA follow-up) Accessability improvement This patch adds a keydown event listener onto the flatpickr instance and looks for the down arrow key. When such an event is detected we take that to mean the user wants to keyboard navigate the calendar widget and so disable the buggy allowInput option allowing keyboard navigation to work as expected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 [Bug 29278] write_age function broken by Flatpickr conversion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28377 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 [Bug 28377] Use the API to suspend/resume holds -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org