[Bug 16624] New: Times are formatted incorrectly in slips ( AM PM ) due to double processing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Bug ID: 16624 Summary: Times are formatted incorrectly in slips ( AM PM ) due to double processing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Letters.pm reformats the time once for title, once for content, this causes improper formatting of timestamps and makes all times appear as AM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 51934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51934&action=edit Bug 16624 - Times are formatted incorrectly in slips ( AM PM ) due to double processing To test: 1 - Checkout an item (with default time 11:59:00 PM) 2 - Generate a quickslip 3 - Notice the time is 'AM' 4 - Apply patch 5 - Generate quickslip 6 - Note time is correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51934|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 51937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51937&action=edit [SIGNED-OFF] Bug 16624 - Times are formatted incorrectly in slips ( AM PM ) due to double processing To test: 1 - Checkout an item (with default time 11:59:00 PM) 2 - Generate a quickslip 3 - Notice the time is 'AM' 4 - Apply patch 5 - Generate quickslip 6 - Note time is correct Signed-off-by: Jason Burds <JBurds@dubuque.lib.ia.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |13622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 [Bug 13622] Add option to display datetimes as dates in notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51937|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52121&action=edit Bug 16624: Add regression tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52122&action=edit Bug 16624: Fix regression displaying a letter with hours Bug 13622 has introduced a bug, if pref TimeFormat is 12hr and a date is displayed in both title and content of the letter. Test plan: 1 - Checkout an item (with default time 11:59:00 PM) 2 - Generate a quickslip 3 - Notice the time is 'AM' 4 - Apply patch 5 - Generate quickslip 6 - Note time is correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16441 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, Looking at the tests, your patch is wrong. Have a look at this counter-patch. Note that we will need bug 16441 to fix the problem in the existing tests (see second patch of bug 16441). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441 [Bug 16441] C4::Letters::getletter is not plack safe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52121|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 52126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52126&action=edit Bug 16624: Add regression tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52122|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 52127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52127&action=edit Bug 16624: Fix regression displaying a letter with hours Bug 13622 has introduced a bug, if pref TimeFormat is 12hr and a date is displayed in both title and content of the letter. Test plan: 1 - Checkout an item (with default time 11:59:00 PM) 2 - Generate a quickslip 3 - Notice the time is 'AM' 4 - Apply patch 5 - Generate quickslip 6 - Note time is correct Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick@bywatersolutions.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Karl Holten <kholten@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten@switchinc.org --- Comment #8 from Karl Holten <kholten@switchinc.org> --- Created attachment 52453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52453&action=edit Screenshot of patron page being affected A note on this particular bug: I don't think it just affects the slips. It seems to affect the actual due date in Koha. When we check out an item and set the due date manually to the end of the day, it instantly becomes overdue. It also displays on the screen as being due in the morning. I am not sure if this bug-fix addresses this particular issue or no. It might need to be its own bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Karl Holten from comment #8)
Created attachment 52453 [details] Screenshot of patron page being affected
A note on this particular bug: I don't think it just affects the slips. It seems to affect the actual due date in Koha.
When we check out an item and set the due date manually to the end of the day, it instantly becomes overdue. It also displays on the screen as being due in the morning. I am not sure if this bug-fix addresses this particular issue or no. It might need to be its own bug.
It's not related, please open a new bug report (and link it to this one using "see also") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can reproduce the problem for the slip printing, but not for the checkouts table. The latter displays correctly for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52126|0 |1 is obsolete| | Attachment #52127|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 52546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52546&action=edit [PASSED QA] Bug 16624: Add regression tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 52547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52547&action=edit [PASSED QA] Bug 16624: Fix regression displaying a letter with hours Bug 13622 has introduced a bug, if pref TimeFormat is 12hr and a date is displayed in both title and content of the letter. Test plan: 1 - Checkout an item (with default time 11:59:00 PM) 2 - Generate a quickslip 3 - Notice the time is 'AM' 4 - Apply patch 5 - Generate quickslip 6 - Note time is correct Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16780 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9)
(In reply to Karl Holten from comment #8)
Created attachment 52453 [details] Screenshot of patron page being affected
A note on this particular bug: I don't think it just affects the slips. It seems to affect the actual due date in Koha.
When we check out an item and set the due date manually to the end of the day, it instantly becomes overdue. It also displays on the screen as being due in the morning. I am not sure if this bug-fix addresses this particular issue or no. It might need to be its own bug.
It's not related, please open a new bug report (and link it to this one using "see also")
See Bug 16780 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #15 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16624 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org