[Bug 42341] New: "Print label" on staff detail page is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 Bug ID: 42341 Summary: "Print label" on staff detail page is not translatable Initiative type: --- Sponsorship --- status: Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com The print label button in the holdings table on the staff detail page is no longer translatable. This is because it's created using JS: render: function (data, type, row, meta) { return '<a class="btn btn-default btn-xs print-label" href="/cgi-bin/koha/labels/spinelabel-print.pl?barcode=%s"><i class="fa fa-print"></i> Print label</a>'.format(escape_str(row.external_id)); To test: - Activate SpineLabelShowPrintOnBibDetails - Install any translation. For ktd: sudo koha-translate --install de-DE --dev kohadev - Activate translation with StaffInterfaceLanguages - Find a bibliographic record with items and callnumbers in staff - Verify the "Print label" remains English when switching between languages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197169&action=edit Bug 42341: Fix translatability of 'Print label' on staff detail page To test: - Activate SpineLabelShowPrintOnBibDetails - Install any translation. For ktd: sudo koha-translate --install de-DE --dev kohadev - Activate translation with StaffInterfaceLanguages - Find a bibliographic record with items and callnumbers in staff - Verify the "Print label" is translated when switching between languages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |unspecified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197169|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 197550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197550&action=edit Bug 42341: Fix translatability of 'Print label' on staff detail page To test: - Activate SpineLabelShowPrintOnBibDetails - Install any translation. For ktd: sudo koha-translate --install de-DE --dev kohadev - Activate translation with StaffInterfaceLanguages - Find a bibliographic record with items and callnumbers in staff - Verify the "Print label" is translated when switching between languages Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- This works to enable translation on the string that is created with javascript. Following the coding guidelines: JS2: Enabling translation of language strings in embedded JavaScript JS4: Use the format() method to join variables with translatable strings Testing note: If you install the translation before applying the patch you have to update to see the effect: sudo koha-translate --update fr-FR --dev kohadev Nice work! Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197550|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 197678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197678&action=edit Bug 42341: Fix translatability of 'Print label' on staff detail page To test: - Activate SpineLabelShowPrintOnBibDetails - Install any translation. For ktd: sudo koha-translate --install de-DE --dev kohadev - Activate translation with StaffInterfaceLanguages - Find a bibliographic record with items and callnumbers in staff - Verify the "Print label" is translated when switching between languages Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42341 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org