https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Hi Lucas. I have signed this off as this fixes the issue on the circulation page, however the same thing occurs on these pages: - Tools - Tools > Patron card creator - Reports - Reports > Items with no checkouts - Circulation > Set library - Circulation > Transfer - Circulation > Overdues with fines Not sure whether these should be fixed in this bug, or a new bug(s) created. David -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 100387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100387&action=edit Bug 24825: Add [% SET footerjs = 1 %] to on pages that lack it This patch adds the adds the JS Footer to all the pages which lack it: TEST PLAN: -add this jQuery to IntranetUserJS: $('#logo').hide(); -load the circulation page, it does not hide the logo. -go to any other page on the staff client, the logo is hidden. -apply patch -load the circulation page, the logo is hidden. Check these other pages to make sure the logo is hidden here to: - Tools - Tools > Patron card creator - Reports - Reports > Items with no checkouts - Circulation > Set library - Circulation > Transfer - Circulation > Overdues with fines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks for looking David, I have added a new patch that encompasses all the pages you discovered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100387|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 100419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100419&action=edit Bug 24825: Add [% SET footerjs = 1 %] to on pages that lack it This patch adds the adds the JS Footer to all the pages which lack it: TEST PLAN: -add this jQuery to IntranetUserJS: $('#logo').hide(); -load the circulation page, it does not hide the logo. -go to any other page on the staff client, the logo is hidden. -apply patch -load the circulation page, the logo is hidden. Check these other pages to make sure the logo is hidden here to: - Tools - Tools > Patron card creator - Reports - Reports > Items with no checkouts - Circulation > Set library - Circulation > Transfer - Circulation > Overdues with fines Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17858 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] [OMNIBUS] Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- grep -L "SET footerjs" **/*.tt All of them are not valid. But some are, for instance acqui/basketgroup.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Jonathan, I got the list of files from David, who discovered pages where jQuery does not work. I don't understand what you mean by 'All of them are not valid.' Are there some cases where I should not add [% SET footerjs %]? Then there is no way to use jQuery on that particular page? Also, do I have to get every single instance where the template does NOT include [% SET footerjs %]? Thanks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- ha, my bad. Lucas, this is not a bug, you must have you code inside $(document).ready Put the following code inside IntranetUserJS and it will work: $(document).ready(function(){ $('#logo').hide(); }); I think this should be marked as invalid. -- You are receiving this mail because: You are watching all bug changes.