[Bug 6210] New: Choose framework on Merge
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Bug #: 6210 Summary: Choose framework on Merge Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Right now when you merge two bibs they have to be the same framework, I'd like to see the librarian be able to choose which framework to apply to the newly merged record instead of just stopping them from merging two records with different frameworks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-09-21 03:02:42 UTC --- We can go three ways with this: * Take reference record framework * Pick from two records frameworks * Pick from the full list Can you please pick the most appropriate one -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-21 07:44:36 UTC --- Could we use the full list and preselect the reference record's framework? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-09-21 23:58:55 UTC --- That is certainly possible. Do we need a confirmation on this, or shall I proceed? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-09-28 14:59:37 UTC --- I confirm that this is the way it should work. Go ahead with Katrin's idea. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |srdjan@catalyst.net.nz --- Comment #5 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-10-06 06:58:46 UTC --- Created attachment 5731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5731 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5731|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-10-06 12:49:24 UTC --- Created attachment 5734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5734 [SIGNED-OFF] bug_6210: Select framework if merging two records with different frameworks Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #7 from Nicole C. Engard <nengard@gmail.com> 2011-10-06 17:05:34 UTC --- New test plan found that this doesn't pass QA: Test 1: Merge two records with the same framework Desired result: shouldn't get any prompting to pick a framework, and the same framework should be used **PASSED Test 1** Test 2: 2 records, different frameworks, into the kept record's framework Desired result: merge with kept records framework used **PASSED Test 2** Test 3: 2 records, different frameworks, into the discarded record's framework Desired result: merge with used records framework used **FAILED Test 3** Test 4: 2 records, different frameworks, into a third framework Desired result: merge with third framework used **FAILED Test 4** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5731|1 |0 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5734|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5731|0 |1 is obsolete| | --- Comment #8 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-10-07 05:40:54 UTC --- Created attachment 5759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5759 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Patch Status|Failed QA |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5759|0 |1 is obsolete| | --- Comment #9 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-11-07 02:39:32 UTC --- Created attachment 6245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6245 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #10 from Nicole C. Engard <nengard@gmail.com> 2011-11-11 14:56:28 UTC --- When repeating test #2 I get the following when trying to complete the merge: Software error: Tag "" is not a valid tag. at /home/nengard/kohaclone/C4/Biblio.pm line 3219 For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6245|0 |1 is obsolete| | --- Comment #11 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-11-14 06:30:25 UTC --- Created attachment 6302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6302 patch I believe that is a data issue. However, the error reporting is quite poor, so please try this patch and if the error reported is not clear please check the log file. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |master Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #12 from Nicole C. Engard <nengard@gmail.com> 2011-12-12 15:44:08 UTC --- Test 1: Merge two records with the same framework Desired result: shouldn't get any prompting to pick a framework, and the same framework should be used **PASSED Test 1** Test 2: 2 records, different frameworks, into the kept record's framework Desired result: merge with kept records framework used **PASSED Test 2** Test 3: 2 records, different frameworks, into the discarded record's framework Desired result: merge with used records framework used **PASSED Test 3** Test 4: 2 records, different frameworks, into a third framework Desired result: merge with third framework used ** FAILED Test 4 ** After clicking 'merge' I get this - I tried to merge a books framework title and a fast add framework title in to the default framework. Software error: No biblionumber tag for framework "Default" at /home/nengard/kohaclone/C4/Biblio.pm line 3186. For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6302|0 |1 is obsolete| | --- Comment #13 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-12-19 06:25:31 UTC --- Created attachment 6858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6858 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #14 from Nicole C. Engard <nengard@gmail.com> 2011-12-20 15:39:48 UTC --- Test 1: Merge two records with the same framework Desired result: shouldn't get any prompting to pick a framework, and the same framework should be used **PASSED Test 1** Test 2: 2 records, different frameworks, into the kept record's framework Desired result: merge with kept records framework used **PASSED Test 2** Test 3: 2 records, different frameworks, into the discarded record's framework Desired result: merge with used records framework used **PASSED Test 3** Test 4: 2 records, different frameworks, into a third framework Desired result: merge with third framework used ** PASSED Test 4 ** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6858|0 |1 is obsolete| | --- Comment #15 from Nicole C. Engard <nengard@gmail.com> 2011-12-20 15:40:46 UTC --- Created attachment 6889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6889 [SIGNED-OFF] bug_6210: Select framework if merging two records with different frameworks ModBiblio() - set framework to "" if "Default" Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All 4 tests passed: Test 1: Merge two records with the same framework Desired result: shouldn't get any prompting to pick a framework, and the same framework should be used Test 2: 2 records, different frameworks, into the kept record's framework Desired result: merge with kept records framework used Test 3: 2 records, different frameworks, into the discarded record's framework Desired result: merge with used records framework used Test 4: 2 records, different frameworks, into a third framework Desired result: merge with third framework used -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-24 11:13:42 UTC --- QA comments: 1- there is an unconditionnal warn: warn qq{No marc tags for framework "$frameworkcode" field $kohafield}; 2- strengthen/clean the code on some subs by: - testing input parameters (_koha_marc_update_bib_ids) - switching a if !cond {A} else {B} to a if cond {B} else {A} (this was not announced, it's OK, but would have been better if announced 3- cataloguing/merge.pl add a +use C4::Koha; => where is this C4::Koha used ? (I can't see, as there are also a lot of reindenting) 4- my tests show a look I think strange, was it intended ? (screenshot attached) Failed QA for 1, waiting for an answer to 3 and 4, (2 is OK) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-24 11:15:46 UTC --- Created attachment 7311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7311 screenshot the framework list is on the right, is it intended ? looks a little bit strange to me -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #18 from Nicole C. Engard <nengard@gmail.com> 2012-01-24 14:24:46 UTC --- It is intended - it's there so you can choose what the framework will be when you finish merging. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-24 14:43:03 UTC --- (In reply to comment #18)
It is intended - it's there so you can choose what the framework will be when you finish merging. Nicole, I understand what it's made for. My surprise is his position on the screen.
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> 2012-01-24 15:47:36 UTC --- Created attachment 7321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7321 Follow-up fix This patch attempts to make the title selection form a little clearer. Also: - Adding subtitle to the display of titles to be merged - Adding a link to preview the MARC record of titles to be merged - Correcting breadcrumbs -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #21 from Nicole C. Engard <nengard@gmail.com> 2012-01-24 16:48:57 UTC --- Owen, Is your patch a follow up? or an edited patch? Should I apply both? Cause when I tried to apply both I got this: nengard@kohavm:~/kohaclone$ git bz apply 6210 Bug 6210 - Choose framework on Merge [SIGNED-OFF] bug_6210: Select framework if merging two records with different frameworks Apply? [yn] y Applying: bug_6210: Select framework if merging two records with different frameworks /home/nengard/kohaclone/.git/rebase-apply/patch:195: trailing whitespace. $framework = $frameworkcode1; /home/nengard/kohaclone/.git/rebase-apply/patch:221: trailing whitespace. choosereference => 1, /home/nengard/kohaclone/.git/rebase-apply/patch:299: trailing whitespace. [% frameworkcodeloo.frameworktext %] warning: 3 lines add whitespace errors. Follow-up fix Apply? [yn] y Applying: Bug 6210 - Follow up, Choose framework on merge error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/merge.tt:198 error: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/merge.tt: patch does not apply Patch failed at 0001 Bug 6210 - Follow up, Choose framework on merge When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Follow-up-fix-z8BjoC.patch nengard@kohavm:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> 2012-01-24 21:08:11 UTC --- My patch is a follow-up. I just tried using git bz to apply both patches on a fresh branch and had no problems. I wonder if it's because I have this git configuration tweak? http://blog.bigballofwax.co.nz/2011/12/15/fixing-whitespace-when-apply-patch... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7321|0 |1 is obsolete| | --- Comment #23 from Nicole C. Engard <nengard@gmail.com> 2012-01-24 22:06:46 UTC --- Created attachment 7327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7327 [SIGNED-OFF] Bug 6210 - Follow up, Choose framework on merge - Adding subtitle to the display of titles to be merged - Adding a link to preview the MARC record of titles to be merged - Fixing up markup of form to improve appearance - Correcting breadcrumbs Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #24 from Nicole C. Engard <nengard@gmail.com> 2012-01-24 22:07:39 UTC --- That was it - the follow up was signed off on. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #25 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-01-25 07:02:22 UTC --- Issues from comment 16: 1. warn is not unconditional, sub returns before warn if all is ok 3. C4::Koha::getframeworks() is used 4. Other layouts are posiible. Fields can be moved around easily without affecting functionality. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #26 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-01 16:44:17 UTC --- thx owen for the new display, thanks srdjan for your answers, passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #27 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-02 13:57:17 UTC --- (In reply to comment #26)
thx owen for the new display, thanks srdjan for your answers, passed QA
Probably, these new warnings (like below) come from this first patch, making changes in GetMarcFromKohaField: [Thu Feb 02 14:46:00 2012] [error] [client 192.87.126.61] [Thu Feb 2 14:46:00 2012] opac-search.pl: No marc tags for framework "" field items.biblionumber at /usr/share/koha/testclone/C4/Biblio.pm line 1051., referer: http://libdevelop.rijksmuseum.nl:8008/cgi-bin/koha/opac-search.pl?q=vermeer Note that it repeats for multiple fields!! Just a side note: When writing/testing your patches, please check your error log too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #28 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-02 14:34:53 UTC --- In Comment #16 I wrote:
QA comments: 1- there is an unconditionnal warn: warn qq{No marc tags for framework "$frameworkcode" field $kohafield}; Srdjan answered in comment #25: Issues from comment 16: 1. warn is not unconditional, sub returns before warn if all is ok
Why didn't I checked, I don't know. But the result is the verbose logs ! In UNIMARC, there are many fields that are in items table and not connected to a MARC field. And that should not trouble anyone. So we should not issue any warning. I've pushed a follow-up removing the warning, the logs are silenced now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #29 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-03 07:41:38 UTC --- Confirming that follow up fixed noise in the log. Thx! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org