[Bug 16522] New: Add 773 (Host item entry) to the cart display and e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Bug ID: 16522 Summary: Add 773 (Host item entry) to the cart display and e-mail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When adding an analytical record to your cart or your list, the host item entry - the serial or monograph the analytic is included in, will now show. Ideally this information should show in staff and OPAC - in the brief display table - on the more details view - in the e-mail text For libraries with a lot of analytical records this is quite an issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3150 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am changing this to be a bug - the analytical information is useless without the source. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add 773 (Host item entry) |Add 773 (Host item entry) |to the cart display and |to the cart and list |e-mail |displays and e-mails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller@bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Assignee|oleonard@myacpl.org |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 114178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114178&action=edit Bug 16522: Adding 773 to basket and cart WIP Not yet ready for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114178|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 114429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114429&action=edit Bug 16522: Adding 773 to cart and list displays and emails This patch adds a new subroutine get_host_item_entries in the Koha::Biblio module which retrieves any 773 fields from the biblio record. The subroutine is used to show a host item entry and a link to the record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - opac list - opac cart - opac send list email email - opac send cart email To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. confirm tests pass: t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a new release notes| |subroutine | |get_host_item_entries in | |the | |Koha::Biblio module | |which retrieves any 773 | |fields from the biblio | |record. The subroutine is | |used to show a host item | |entry and a link to the | |record in the following | |places: | |- staff client list | |- staff client cart | |- staff | |client send list email | |- | |staff client send cart | |email | |- opac list | |- opac | |cart | |- opac send list email | |email | |- opac send cart | |email Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looks good, however I think the Koha::Biblio method should not return a MARC::Field set, but instead hashrefs with the info you need. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Joubu for your comment! Took a first glance at the code too, but need to spend some more time. Problem is that $0 and $9 subfields are not MARC standard, but only used for Koha's EasyAnalytics feature, which we can't use as it clashes with our union catalog workflow. I want to check how it all fits together with our 773 not having either in comparison, to give you better feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks Katrin - the host item feature isn't something I've used before so some context and more specific feedback would be useful! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Abdulaziz qn <azoz141415@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |azoz141415@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114429|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 120425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120425&action=edit Bug 16522: Adding 773 to cart and list displays and emails This patch adds a new subroutine get_host_item_entries in the Koha::Biblio module which retrieves any 773 fields from the biblio record. The subroutine is used to show a host item entry and a link to the record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - opac list - opac cart - opac send list email email - opac send cart email To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. confirm tests pass: t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120425|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 130250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130250&action=edit Bug 16522: Adding 773 to cart and list displays and emails This patch adds a new subroutine get_host_item_entries in the Koha::Biblio module which retrieves any 773 fields from the biblio record. The subroutine is used to show a host item entry and a link to the record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - opac list - opac cart - opac send list email email - opac send cart email To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. confirm tests pass: t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #9 from Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> --- I was testing this using a sandbox. Unfortunately, on step 8 and 9 i couldn't see the "host item entry" link... In the list, i can see the source (step 11) with the title (245 $a), but no link (?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks for testing Christian. Please mark bug as 'Failed QA' if they don't behave according to the test plan. I'll take a look at this when I get a chance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130250|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 133509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133509&action=edit Bug 16522: Adding 773 to cart and list displays and emails This patch adds a new subroutine get_host_item_entries in the Koha::Biblio module which retrieves any 773 fields from the biblio record. The subroutine is used to show a host item entry and a link to the record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - opac list - opac cart - opac send list email email - opac send cart email To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. confirm tests pass: t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 133509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133509 Bug 16522: Adding 773 to cart and list displays and emails Review of attachment 133509: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16522&attachment=133509) ----------------------------------------------------------------- ::: Koha/Biblio.pm @@ +1099,5 @@
+ my @host_item_entries = $record->field('773'); + + return ( @host_item_entries > 0 ) ? \@host_item_entries : undef; +} +
Should we be using 'get_marc_host' from bug 20310 here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29268 CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133509|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 135416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135416&action=edit Bug 16522: Adding 773 to cart and list displays and emails This patch adds a new subroutine get_host_item_entries in the Koha::Biblio module which retrieves any 773 fields from the biblio record. The subroutine is used to show a host item entry and a link to the record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - opac list - opac cart - opac send list email email - opac send cart email To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #14 from David Nind <david@davidnind.com> --- Two things from testing: 1. For the emails, is the link supposed to be to the record for the source/host item entry, or the record it is in? For me, it is linking to the record with the 773. 2. After applying the patch, flush_memcached, restart_all, I get these error traces when sending the email from the staff interface for the cart and list (I could send emails for the cart and list before the patch was applied, and I can send emails from the cart and list from the OPAC): Cart: staff interface ~~~~~~~~~~~~~~~~~~~~~ Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127 in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 127 124: 125: my $data; 126: binmode( STDOUT, ":encoding(UTF-8)" ); 127: $template->process( $self->filename, $vars, \$data ) 128: || die "Template process failed: ", $template->error(); 129: return $data; List: staff interface ~~~~~~~~~~~~~~~~~~~~~ The method Koha::Biblio->get_host_item_entries is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Biblio=HASH(0x560f9c5e1470)') called at /kohadevbox/koha/virtualshelves/sendshelf.pl line 95 eval {...} at /kohadevbox/koha/virtualshelves/sendshelf.pl line 2 CGI::Compile::ROOT::kohadevbox_koha_virtualshelves_sendshelf_2epl::__ANON__('CGI::Compile=HASH(0x560f9af894f8)', '', '/kohadevbox/koha/virtualshelves/sendshelf.pl', '/kohadevbox/koha/virtualshelves', 'ARRAY(0x560f9b0ef760)') called at /usr/share/perl5/CGI/Compile.pm line 151 CGI::Compile::ROOT::kohadevbox_koha_virtualshelves_sendshelf_2epl::sendshelf_2epl at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 CGI::Emulate::PSGI::__ANON__('HASH(0x560f9c7603f8)') called at /usr/share/perl5/Plack/App/WrapCGI.pm line 95 Plack::App::WrapCGI::call('Plack::App::WrapCGI=HASH(0x560f9b22e9c0)', 'HASH(0x560f9c7603f8)') called at /usr/s ......... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #15 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): - Email sending setup by adding this to the koha-conf.xml file (where email address = gmail address and yourpassword = the app password setup for your gmail account): <smtp_server> <host>smtp.gmail.com</host> <port>587</port> <timeout>5</timeout> <ssl_mode>STARTTLS</ssl_mode> <user_name>youraddress@gmail.com</user_name> <password>yourpassword</password> <debug>1</debug> </smtp_server> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Aleisha, sorry for taking so long to give feedback on this patch. It took a while to wrap my head around and I hope my notes make sense.
Thanks Katrin - the host item feature isn't something I've used before so some context and more specific feedback would be useful!
I'll try! We'd create an analytical record a litle different than in your test plan, as we can't use the EasyAnalytics feature that relies on creating 773 fields in the MARC record. For our records the union catalog is the primary database and the link between the record and its host item would be created there. This would resemble our workflow a little better in Koha: * Search for a serial or monograph record in the staff interface * From the detail page: New > New child record * This opens a new record in the cataloguing editor with a 773 created from the information of its 'parent' record. If you are using controlnumber for linking, the 001 of the host will be in $w of the child used for linking by ID. * Add 773$g with information on the location of the 'child' within the 'parent' (i.e. volume, issue, pages) Example: $g 13(1917), 12, p. 98-104 There is sample record set on bug 11175, that's a good starting point. For testing I have added $g and removed $w in some records. =XSLT based displays (list view in OPAC)= * I think currently the result page uses a copy of the 773 code from the detail page, but they have fallen out of sync. For example missing the change from bug 20277. Could you please move the code into MARC21slimUtils.xsl as a new template, so we can use the same logic in detail and result page? Nick did something similar on bug 5927. * We should probably note in the test plan that the changes to the XSLT will also apply to the normal result list in the catalog and staff interface. =TT based displays (cart detail, list detail, cart email, list email)= You used get_marc_host for finding the host record and the include for displaying the title here, which I think is a neat approach. I really like that it allows us to create a direct link using the biblionumber instead of the more complicated search link using $w or $a$t. But as usual, there are some caveats with libraries. :( At the moment the 773 will only show when the library has been using $w/001 for linking, which is often not the case. We also have some cases, where an 'unlinked' 773 without $w will be added/imported in our catalogs. * It would be nice if we could still be using get_marc_host somehow, but we might need at least a fallback to create the display using 773$atg directly. 773 should only display if there is at least a $t. I think when there is no $w just displaying the plain text without a link would be ok and still a nice improvement. * Can you please add 773$g to display? It looks like get_marc_host will return it if called in list context. * virtualshelves/sendshelf.pl still has $biblio->get_host_item_entries, maybe from a previous version of this patch? * Release notes and test plan also mention $biblio->get_host_item_entries, but I think it was replaced by get_marc_host. * The FOREACH in the templates might not be needed if we keep using get_marc_host as it only looks at the first 773. * The 'label' for 773 is usually "In:" in the detail and other views. Can you please make the TT views match? Currently they are using 'Host item entry' or 'Host item entries' or 'Source' (XSLT results). About comment#14 from David: * I couldn't test the email part, apart from reading the code, but maybe you could check the the links? I'll certainly try his test plan for email next iteration :) * I didn't have the issue with the cart in the staff interface that David noted, but I think the list issue is due to the wrong method name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds a new |This patch adds a new release notes|subroutine |subroutine get_marc_host in |get_host_item_entries in |the |the |Koha::Biblio module |Koha::Biblio module |which retrieves any 773 |which retrieves any 773 |fields from the biblio |fields from the biblio |record. The subroutine is |record. The subroutine is |used to show a host item |used to show a host item |entry and a link to the |entry and a link to the |record in the following |record in the following |places: |places: |- staff client list |- staff client list |- staff client cart |- staff client cart |- staff |- staff |client send list email |client send list email |- |- |staff client send cart |staff client send cart |email |email |- staff client search |- opac list |results |- opac |- staff client |cart |detail page |- opac send list email |- opac list |email |- |- opac send cart |opac cart |email |- opac send list | |email email | |- opac send | |cart email | |- opac search | |results | |- opac detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135416|0 |1 is obsolete| | --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 137196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137196&action=edit Bug 16522: Adding 773 to cart and list displays and emails This patch adds a new subroutine get_marc_host in the Koha::Biblio module which retrieves any 773 fields from the biblio record. The subroutine is used to show a host item entry and a link to the record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - staff client search results - staff client detail page - opac list - opac cart - opac send list email email - opac send cart email - opac search results - opac detail page To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. Confirm host item info also shows correctly on the OPAC and staff client search results, and the OPAC and staff client detail pages (where XSLT is used) 15. Delete the 773$w and confirm host item info still shows correctly but no longer links to biblio 16. confirm tests pass t/db_dependent/Koha/Biblio/host_record.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 137197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137197&action=edit Bug 16522: (follow-up) MARC display templates and get_marc_host fixes Also: - Show related parts 773$g - Normalise using 'Host item entry' as title - Remove 'foreach' because non-xslt views only return first - If no $w, use $atg, and related tests in t/db_dependent/Koha/Biblio/host_record.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from David Nind <david@davidnind.com> --- 1. Sending email ~~~~~~~~~~~~~~~ Sending email from staff interface - for both the cart and the list I get this error trace (note: can send email from OPAC for both the cart and list): Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127 in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 127 124: 125: my $data; 126: binmode( STDOUT, ":encoding(UTF-8)" ); 127: $template->process( $self->filename, $vars, \$data ) 128: || die "Template process failed: ", $template->error(); 129: return $data; 130: } Show function arguments in (eval) at /kohadevbox/koha/virtualshelves/sendshelf.pl line 111 108: ); 109: 110: # Getting template result 111: my $template_res = $template2->output(); 112: my $body; 113: 114: my $subject; in CGI::Compile::ROOT::kohadevbox_koha_virtualshelves_sendshelf_2epl::__ANON__ at /kohadevbox/koha/virtualshelves/sendshelf.pl line 2 .... Setup to test email: see comment #15 (note: yourpassword = an app password, not the normal Gmail password) 2. OPAC - link for host item entry is wrong ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The link in OPAC record detail page to the host item entry is using the staff interface URL. Link in OPAC detail view: http://127.0.0.1:8080/cgi-bin/koha/catalogue/detail.pl?biblionumber=262 Should be: http://127.0.0.1:8080/cgi-bin/koha/opac-detail.pl?biblionumber=262 3. Step 15 ~~~~~~~~~~ I deleted the 773$w, but the staff interface and OPAC are still showing the link to the host record. 4. Text 'Host item entry' vs 'In' ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Have you seen bug 31106 - text in child record to host item is 'In'. See also Katrin's comment about the 'label' for 773 in comment #16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137196|0 |1 is obsolete| | --- Comment #20 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 139168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139168&action=edit Bug 16522: Adding 773 to cart and list displays and emails This patch adds a new subroutine get_marc_host in the Koha::Biblio module which retrieves any 773 fields from the biblio record. The subroutine is used to show a host item entry and a link to the record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - staff client search results - staff client detail page - opac list - opac cart - opac send list email email - opac send cart email - opac search results - opac detail page To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. Confirm host item info also shows correctly on the OPAC and staff client search results, and the OPAC and staff client detail pages (where XSLT is used) 15. Delete the 773$w and confirm host item info still shows correctly but no longer links to biblio 16. confirm tests pass t/db_dependent/Koha/Biblio/host_record.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137197|0 |1 is obsolete| | --- Comment #21 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 139169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139169&action=edit Bug 16522: (follow-up) MARC display templates and get_marc_host fixes Also: - Show related parts 773$g - Normalise using 'Host item entry' as title - Remove 'foreach' because non-xslt views only return first - If no $w, use $atg, and related tests in t/db_dependent/Koha/Biblio/host_record.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #22 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Have rebased the patches, will now work on addressing the other bits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #23 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Nind from comment #19)
1. Sending email ~~~~~~~~~~~~~~~
Hi David, I couldn't reproduce this, can you please retest?
2. OPAC - link for host item entry is wrong ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Should be fixed with my rebase
3. Step 15 ~~~~~~~~~~
I deleted the 773$w, but the staff interface and OPAC are still showing the link to the host record.
Cannot reproduce, can you please tell me what steps you took to get this?
4. Text 'Host item entry' vs 'In' ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Have you seen bug 31106 - text in child record to host item is 'In'.
See also Katrin's comment about the 'label' for 773 in comment #16
I addressed this in my latest follow-up Ready to test please -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139168|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139846&action=edit Bug 16522: Adding 773 to cart and list displays and emails This patch adds a new subroutine get_marc_host in the Koha::Biblio module which retrieves any 773 fields from the biblio record. The subroutine is used to show a host item entry and a link to the record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - staff client search results - staff client detail page - opac list - opac cart - opac send list email email - opac send cart email - opac search results - opac detail page To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. Confirm host item info also shows correctly on the OPAC and staff client search results, and the OPAC and staff client detail pages (where XSLT is used) 15. Delete the 773$w and confirm host item info still shows correctly but no longer links to biblio 16. confirm tests pass t/db_dependent/Koha/Biblio/host_record.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139169|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139847&action=edit Bug 16522: (follow-up) MARC display templates and get_marc_host fixes Also: - Show related parts 773$g - Normalise using 'Host item entry' as title - Remove 'foreach' because non-xslt views only return first - If no $w, use $atg, and related tests in t/db_dependent/Koha/Biblio/host_record.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139848&action=edit Bug 16522: (follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Rebased and provided a follow-up to make the QA test tools pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #27)
Rebased and provided a follow-up to make the QA test tools pass.
Conflict was limited to sendbasket.pl and the change to this line: $dat->{ITEM_RESULTS} = $biblio->items->search_ordered; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #29 from Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> --- On step 10 in the test plan. "Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127 in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 127 124: 125: my $data; 126: binmode( STDOUT, ":encoding(UTF-8)" ); 127: $template->process( $self->filename, $vars, \$data ) 128: || die "Template process failed: ", $template->error(); 129: return $data; 130: } Show function arguments in (eval) at /kohadevbox/koha/basket/sendbasket.pl line 105 102: ); 103: 104: # Getting template result 105: my $template_res = $template2->output(); 106: my $body; 107: 108: my $subject; ..." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #30 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi Christian, I wasn't able to reproduce that error. Are you sure you're testing on the latest upstream version? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Doesn't bug 3150 negate the need for this at all? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #32 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Martin Renvoize from comment #31)
Doesn't bug 3150 negate the need for this at all?
Bug 3150 would only address some of the email part for this bug? This also handles the display in the cart and list within Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139846|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141058&action=edit Bug 16522: Adding 773 to cart and list displays and emails This patch adds a new subroutine get_marc_host in the Koha::Biblio module which retrieves any 773 fields from the biblio record. The subroutine is used to show a host item entry and a link to the record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - staff client search results - staff client detail page - opac list - opac cart - opac send list email email - opac send cart email - opac search results - opac detail page To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. Confirm host item info also shows correctly on the OPAC and staff client search results, and the OPAC and staff client detail pages (where XSLT is used) 15. Delete the 773$w and confirm host item info still shows correctly but no longer links to biblio 16. confirm tests pass t/db_dependent/Koha/Biblio/host_record.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139847|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141059&action=edit Bug 16522: (follow-up) MARC display templates and get_marc_host fixes Also: - Show related parts 773$g - Normalise using 'Host item entry' as title - Remove 'foreach' because non-xslt views only return first - If no $w, use $atg, and related tests in t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139848|0 |1 is obsolete| | --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141060&action=edit Bug 16522: (follow-up) Add missing TT filters Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141061&action=edit Bug 16522: (follow-up) Rename "Host item entry" to "In" We already use In: as label for 773 on the result lists and detail pages and it's also recommended in the MARC documentation. With this patch the label is the same everywhere. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141062&action=edit Bug 16522: (follow-up) Fix variable in OPAC cart brief display Without this change records 773 entries with links in $w would not display the title information, but just "No title". With the variable fixed, now the host's title displays. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141063&action=edit Bug 16522: (follow-up) Remove HTML links from email The emails sent for cart and list are plain text and any <a> tag will be scrubbed by HtmlToText. So we can remove those links. This also solves an issue with the original patch set, where the error below would appear on sending a cart or list email from the staff interface: Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127 Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have changed the test plan slightly to account for our cataloguing use case as we are not using EasyAnalytics: 1. apply patch, restart services Original test plan: 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. Adapted test plan: 2. log into the staff interface and enable the syspref UseControlNumber 3. Download analytical records and their host records from one of our catalogs :) 4. Import records into Koha, view them and verify the 773 links work correctly 5. Remove 773$w from one of the records, as sometimes records might not be linked. In the staff interface: 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. CART * Brief view: OK with the provided follow-up * More view: OK * E-mail: Exploded with the error mentioned by David and Christian: Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127 The reason is, that the file is missing [% PROCESS 'html_helpers.inc' %]. But: The html links get removed by the HTMLToText Process and don't show in the text based email. So I have decided to remove the links here. Also: we don't want to link to the staff interface, so the email can still be send to users. The staff email currently only includes a link to the record in the OPAC. -> Follow-up provided LIST * Result list: OK * E-mail: Same issue as for the cart mail, same fix. -> Follow-up provided In the OPAC: 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. CART * Brief view: OK with the provided follow-up * More view: OK * E-mail: OK LIST * Result list: OK * E-mail: OK 14. Confirm host item info also shows correctly on the OPAC and staff client search results, and the OPAC and staff client detail pages (where XSLT is used) OPAC: * Results: OK * Detail: OK Staff interface: * Results: OK * Detail: OK 15. Delete the 773$w and confirm host item info still shows correctly but no longer links to biblio 773$w link missing: OK! Tested with a separate record in the steps above. SIGNED OFF! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Added Marcel to CC list.. this patchset changes get_marc_host.. I know you're close to that sub.. any chance you could validate the change here.. I'm afraid my knowledge of that area has dropped away somewhat. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #40)
Added Marcel to CC list.. this patchset changes get_marc_host.. I know you're close to that sub.. any chance you could validate the change here.. I'm afraid my knowledge of that area has dropped away somewhat.
Its on my list now ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- if ( !$hostfld and $record->subfield('773','t') ) { # not linked using $w so just return plaintext my $unlinkedf = $record->field('773'); my $host = join( ", ", $unlinkedf->subfield('a'), $unlinkedf->subfield('t'), $unlinkedf->subfield('g') ); return wantarray ? ( $host, $unlinkedf->subfield('g') ) : $host; } The user of this routine expects a Koha object returned first. You return a concatenation of strings. Would be better to not disturb existing returns but find a way to return new alternative data. And change POD accordingly in the end. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #43 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - [% INCLUDE 'biblio-title.inc' link = 1 biblio=BIBLIO_RESULT.HOSTITEMENTRIES %] [% BIBLIO_RESULT.RELATEDPARTS | $raw %] + [% INCLUDE 'biblio-title.inc' biblio=BIBLIO_RESULT.HOSTITEMENTRIES %] [% BIBLIO_RESULT.RELATEDPARTS | $raw %] Please clarify why you remove link = 1. Should this have been link=1 without spaces?? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please update release notes/commit message. The routine get_marc_host exists already :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #43)
- [% INCLUDE 'biblio-title.inc' link = 1 biblio=BIBLIO_RESULT.HOSTITEMENTRIES %] [% BIBLIO_RESULT.RELATEDPARTS | $raw %] + [% INCLUDE 'biblio-title.inc' biblio=BIBLIO_RESULT.HOSTITEMENTRIES %] [% BIBLIO_RESULT.RELATEDPARTS | $raw %]
Please clarify why you remove link = 1. Should this have been link=1 without spaces??
I did clarify :) See comment#39: The html links get removed by the HTMLToText Process and don't show in the text based email. So I have decided to remove the links here. Also: we don't want to link to the staff interface, so the email can still be send to users. The staff email currently only includes a link to the record in the OPAC. -> Follow-up provided -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds a new |This adds information from release notes|subroutine get_marc_host in |host item entry (MARC21 |the |773) and if applicable a |Koha::Biblio module |link to the host record in |which retrieves any 773 |the following places: |fields from the biblio |* |record. The subroutine is |Staff interface: list, list |used to show a host item |email, cart, cart email, |entry and a link to the |and search results |record in the following |* OPAC: |places: |list, list email, cart, |- staff client list |cart email, and search |- staff client cart |results |- staff | |client send list email | |- | |staff client send cart | |email | |- staff client search | |results | |- staff client | |detail page | |- opac list | |- | |opac cart | |- opac send list | |email email | |- opac send | |cart email | |- opac search | |results | |- opac detail page | --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #44)
Please update release notes/commit message. The routine get_marc_host exists already :)
Updated the release notes description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141058|0 |1 is obsolete| | --- Comment #47 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142036&action=edit Bug 16522: Adding 773 to cart and list displays and emails This enhancement adds information from a host item entry and a link if applicable to the host record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - staff client search results - staff client detail page - opac list - opac cart - opac send list email email - opac send cart email - opac search results - opac detail page To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. Confirm host item info also shows correctly on the OPAC and staff client search results, and the OPAC and staff client detail pages (where XSLT is used) 15. Delete the 773$w and confirm host item info still shows correctly but no longer links to biblio 16. confirm tests pass t/db_dependent/Koha/Biblio/host_record.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141059|0 |1 is obsolete| | --- Comment #48 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142037&action=edit Bug 16522: (follow-up) MARC display templates and get_marc_host fixes Also: - Show related parts 773$g - Normalise using 'Host item entry' as title - Remove 'foreach' because non-xslt views only return first - If no $w, use $atg, and related tests in t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141060|0 |1 is obsolete| | --- Comment #49 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142038&action=edit Bug 16522: (follow-up) Add missing TT filters Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141061|0 |1 is obsolete| | --- Comment #50 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142039&action=edit Bug 16522: (follow-up) Rename "Host item entry" to "In" We already use In: as label for 773 on the result lists and detail pages and it's also recommended in the MARC documentation. With this patch the label is the same everywhere. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141062|0 |1 is obsolete| | --- Comment #51 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142040&action=edit Bug 16522: (follow-up) Fix variable in OPAC cart brief display Without this change records 773 entries with links in $w would not display the title information, but just "No title". With the variable fixed, now the host's title displays. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141063|0 |1 is obsolete| | --- Comment #52 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142041&action=edit Bug 16522: (follow-up) Remove HTML links from email The emails sent for cart and list are plain text and any <a> tag will be scrubbed by HtmlToText. So we can remove those links. This also solves an issue with the original patch set, where the error below would appear on sending a cart or list email from the staff interface: Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127 Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #53 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142042&action=edit Bug 16522: (follow-up) If no 773$w, try to return host record Use host biblionumber or host itemnumber to return a host record, or use title and author to search for a host record, or return an undef record and a string of host information when get_marc_host is called in list context. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #54 from David Cook <dcook@prosentient.com.au> --- I think I had someone asking for this the other day. I'll come back... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #55 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #54)
I think I had someone asking for this the other day. I'll come back...
Actually, I think this might be much much more complicated than what we were wanting to do. We just want to show the 773 information rather than fetching data from a record linked via the 773... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Subfields 0 and 9 are only used with EasyAnalytics and might be used differently by other libraries as these are not standard MARC - I think we should wrap that part into a preference check. Otherwise it could cause issues if either of them is used locally with a numerical value. For our use case 0 and 9 would never be set with any Koha IDs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thinking about the search fallback too: I don't think it will work reliably enough and we should remove it. Most of the time 773 are used with articles from serials. And there are a lot of serials with very similar names and subseries in $b etc. Thinking about the serial "Pädagogik" or "Natur" for examples. Even an exact field search would turn up many results there and not only the one you were looking for. Also serials usually don't have authors, so the search is quite limited. I really think using the IDs is ok'ish with the caveat of it checking EasyAnalytics, but trying to link otherwise won't work well enough and there are records where the host is just not in the catalog and then we just need to display 773 information directly from the record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #58 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #57)
Thinking about the search fallback too: I don't think it will work reliably enough and we should remove it.
Most of the time 773 are used with articles from serials. And there are a lot of serials with very similar names and subseries in $b etc. Thinking about the serial "Pädagogik" or "Natur" for examples. Even an exact field search would turn up many results there and not only the one you were looking for. Also serials usually don't have authors, so the search is quite limited.
I really think using the IDs is ok'ish with the caveat of it checking EasyAnalytics, but trying to link otherwise won't work well enough and there are records where the host is just not in the catalog and then we just need to display 773 information directly from the record.
Yes, I tend to agree. Looked at the follow-up too. Looks better, more consistent now. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142042|0 |1 is obsolete| | --- Comment #59 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142843&action=edit Bug 16522: (follow-up) If no 773$w, try to return host record Use host biblionumber or host itemnumber to return a host record if EasyAnalyticalRecords is enabled, or return an undef record and a string of host information when get_marc_host is called in list context. Confirm tests pass: - t/db_dependent/Koha/Biblio/host_record.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #60 from Heather <heather_hernandez@nps.gov> --- I tried signing off on this bug and ran into trouble with this step: "10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC." This is the email from the email logs (with some spaces deleted to save space): Date: Mon, 5 Dec 2022 17:47:21 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Here is your cart, sent from our online catalog. Please note that the attached file is a MARC bibliographic records file which can be imported into personal bibliographic software like EndNote, Reference Manager or ProCite. --------------------------------------------------------------------- testing emailing --------------------------------------------------------------------- 1. Four metaphysical poets : an anthology of poetry by Donne, Herbert, Marvell, and Vaughan / Author(s): Donne, John, --1572-1631. ; Wilmott, Richard. Copyright year: 1985 Notes : Includes index. In: Li Po and Tu Fu In online catalog: http://h2sandboxes.biblibre.eu:8080/cgi-bin/koha/opac-detail.pl?bibl= ionumber=3D16 Items: * Centerville GEN 39999000000719 * Fairview GEN 39999000000696 ----------------------------------------------------------------- ---End quoted email And the record it should be linking to is this one: https://staff-h2.sandboxes.biblibre.eu/cgi-bin/koha/catalogue/detail.pl?bibl... But the link in the email has an extraneous equals sign: bibl= ionumber But if you take that out and make the link this one: http://h2sandboxes.biblibre.eu:8080/cgi-bin/koha/opac-detail.pl?bibl ionumber=3D16 It's still incorrect, a broken link. If you put in record number 3D16 into a correct record link, i.e.: https://staff-h2.sandboxes.biblibre.eu/cgi-bin/koha/catalogue/detail.pl?bibl... You get the wrong record ("Introduction to Attic Greek"). It should be this link, to "Four metaphysical poets:" https://staff-h2.sandboxes.biblibre.eu/cgi-bin/koha/catalogue/detail.pl?bibl... So there's an extraneous "3D" before the record number "16." Are the extraneous "=" and "3D" being inserted into the log transcript of the email, or are they really in a sent email? Cheerio! --h2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #61 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Are the extraneous "=" and "3D" being inserted into the log transcript of the email, or are they really in a sent email?
It's something about having to replace some characters before sending them via email: https://en.wikipedia.org/wiki/Quoted-printable#Quoted-printable_encoding It's under the hood so users don't see this. But on sandboxes, koha mail log shows raw data. So = becomes =3D So this part of the link is valid! It's biblionumber=16 as expected. The bibl= is a way to represent going to the next line. So it's biblionumber, as expected. The beginning of the link looks wrong because h2sandboxes.biblibre.eu:8080 isn't what you have in the browser. But it looks like to be the internal address of the OPAC. So just replace with the OPAC address and it should work. So if I understand correctly the link is valid! So you can retry and use the bellow link (or do adapt it yourself from the email logs) and it should work :) http://opac-h2sandboxes.biblibre.eu:8080/cgi-bin/koha/opac-detail.pl?biblion... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #62 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Here is a decoder: https://www.motobit.com/util/quoted-printable-decoder.asp Paste the email and click decode. And then the *first/top* text area contains the result: In online catalog: http://h2sandboxes.biblibre.eu:8080/cgi-bin/koha/opac-detail.pl?biblionumber... Items: * Centerville GEN 39999000000719 * Fairview GEN 39999000000696 And the link is right! (except for the address because that's the previous problem) errata: on the previous comment:
http://opac-h2sandboxes.biblibre.eu:8080/cgi-bin/koha/opac-detail.pl?biblion...
It's http://opac-h2sandboxes.biblibre.eu/cgi-bin/koha/opac-detail.pl?biblionumber... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #63 from Heather <heather_hernandez@nps.gov> --- Thank you so much for all this, Victor! I will try signing off on this bug again today. Would it be good to add this information about sandbox email to the wiki? Maybe here: https://wiki.koha-community.org/wiki/Sandboxes#Testing_sending_emails (For librarians and sign-off newbies like me?) More later!! --h2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #64 from Heather <heather_hernandez@nps.gov> --- Created attachment 144455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144455&action=edit Search results screenshot showing "In.." appearing correctly in staff client I got as far as step 14 in the test plan, and am uploading this screenshot to show that the "In..." is appearing correctly in the staff client, so this is what I was looking for in the OPAC. (I'll upload an OPAC screenshot next.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #65 from Heather <heather_hernandez@nps.gov> --- Created attachment 144456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144456&action=edit Search results in OPAC without "In..." appearing In step 14 in the test plan, I expected to see "In..." appearing in the search results for this record here in the OPAC, as I did in the staff client, but I don't see it there. The test plan implies that I should? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #66 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Heather from comment #63)
Would it be good to add this information about sandbox email to the wiki? Maybe here: https://wiki.koha-community.org/wiki/Sandboxes#Testing_sending_emails (For librarians and sign-off newbies like me?)
Good idea! I missed there was already a section about that. Here is a completed version: https://wiki.koha-community.org/wiki/Sandboxes#Testing_sending_emails Can you proofread to confirm if it's good enough for beginners? And email me if there are things unclear or ideas to improve phrasing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #67 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Heather from comment #65)
In step 14 in the test plan, I expected to see "In..." appearing in the search results for this record here in the OPAC, as I did in the staff client, but I don't see it there. The test plan implies that I should?
Let's switch the ticket to failed QA, as the test plan need clarification. (it seems also to me the test plan says you should see the same thing in the OPAC) And to remove it from the list of tickets ready to be tested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Heather from comment #65)
Created attachment 144456 [details] Search results in OPAC without "In..." appearing
In step 14 in the test plan, I expected to see "In..." appearing in the search results for this record here in the OPAC, as I did in the staff client, but I don't see it there. The test plan implies that I should?
Hi Heather, I see the In: in your screenshot right below the title. Can you confirm maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #69 from Heather <heather_hernandez@nps.gov> --- Ah, Katrin--yes! Thank you! It *is* there right below the title and authors, but shouldn't it be near the "Online access..." at the bottom of the display, like in the staff client? I don't think users will look for it or notice it if it's near the title/authors--they are going to be looking near "Online access..." and "Availability..." as I did. I confess that I completely missed seeing it tucked under the authors, and I was looking for it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #70 from Heather <heather_hernandez@nps.gov> --- Hi, Victor! This is great--very helpful for a newbie! Thank you!! --h2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #71 from Heather <heather_hernandez@nps.gov> --- Hi, Katrin-- I went through the test plan again: --I still think that the "In:..." link should be moved in the OPAC, down to the "Online access..." and "Availability..." area, as it is in the staff client. --I did this step: "15. Delete the 773$w and confirm host item info still shows correctly but no longer links to biblio" And the host item info does still show correctly, but the record does still link to the host biblio. It can be seen in my sandbox here: https://staff-bug16522.sandbox.bywatersolutions.com/cgi-bin/koha/catalogue/detail.pl?biblionumber=16&searchid= Could this be because there is a subfield 0 (zero) in the 773 field ("Host biblionumber") which is not actually a valid MARC21 subfield? (c.f. https://www.loc.gov/marc/bibliographic/bd773.html) --Also, there is a subfield 9 in the 773 to "Host itemnumber," which is nonsense (according to this cataloger)--analytic relationships should only exist at the title level/biblionumber level. If you have variation in contents at the item level, the items should not be on the same biblio (says the cataloger). These are minor quibbles, but I think it would be best for them to be fixed before going into master: --Move the "In:..." in the OPAC near the "Online access..." and/or "Availability:..." so users are more likely to notice it. --Don't use an invalid 773 subfield 0 (zero) with a biblionumber in the 773, but actually use the valid $w field to contain the biblionumber --Don't retain/have an invalid itemnumber in the 773 field, since it's unnecessary and nonsense for this type of relationship, and really use the 773$w. If these quibbles are too minor, no problem--of course, I rely on y'all's expertise for such decisions! It's a great development!! --h2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
These are minor quibbles, but I think it would be best for them to be fixed before going into master: --Move the "In:..." in the OPAC near the "Online access..." and/or "Availability:..." so users are more likely to notice it.
This could be done, although I the current placement also makes sense to me. Having the article and journal information close together. But moving it would be more consistent with other pages, I understand that argument.
--Don't use an invalid 773 subfield 0 (zero) with a biblionumber in the 773, but actually use the valid $w field to contain the biblionumber --Don't retain/have an invalid itemnumber in the 773 field, since it's unnecessary and nonsense for this type of relationship, and really use the 773$w.
This is out of scope here. I'll explain: These subfields are added because you used EasyAnalytics: _0163 _9354 When you remove to $w there is a fallback to the biblionumber in these subfields. But we didn't add that - it's always been in the XSLTs. We would break things for people using EasyAnalytics changing this behaviour. But I think we can assume that libraries using $w won't have EasyAnalytics turned on, they are known to be incompatible. Try cataloguing things manually with UseControlNumber activated and EasyAnalytics turned off, all should work as you expect it then with $w used. Make sure your host has a 001. Then from the detail page use New > New child record and it should create a nice standard 773 for you. I wrote an adapted test plan that should cover that if you ignore the first paragraph: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522#c39
If these quibbles are too minor, no problem--of course, I rely on y'all's expertise for such decisions! It's a great development!! --h2
Thanks for testing this - very happy to see it get attention! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #73 from Heather <heather_hernandez@nps.gov> --- Thank you SO much for all of this, Katrin! I'm going to go ahead and sign off because everything you say makes a lot of sense. Also, I followed the adapted test plan here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522#c39
I imported an analytic record and its parent/host record; the child was linked to the parent (with the generated search using the record number in the $w of the child record to the 001 of the parent record). I deleted the $w from the 773 and the child remained linked to the parent because Koha then used the data in the 773 $t of the child record which retrieved the data in the 245 $a of the parent record. It does this even with the syspref "UseControlNumber" set to "Use" and "EasyAnalyticalRecords" set to "Don't Show." Maybe it shouldn't do this, but I like it--I like the fact that there is a fallback behavior when there is no Control Number (i.e. no $w) to use for searching. (And I will keep arguing that the "In:..." in the OPAC should be moved down to be consistent with other displays, but more folks in the community like it up near the title and author(s), then I'll probably start arguing to move it up there in the staff client!) I think this is a GREAT development, not at all minor, and will be of service to many libraries in getting to their users articles, chapters, papers, songs...all those great things that analytic records are used for. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142843|0 |1 is obsolete| | --- Comment #74 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 145047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145047&action=edit Bug 16522: (follow-up) If no 773$w, try to return host record Use host biblionumber or host itemnumber to return a host record if EasyAnalyticalRecords is enabled, or return an undef record and a string of host information when get_marc_host is called in list context. Confirm tests pass: - t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #75 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks Heather for testing :) Thanks Katrin for spotting the "In...", I missed it also! And the for clarifications on the other points. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- First of all - thanks Heather! Your 'stamp of approval' means a lot to us! (In reply to Heather from comment #73)
I deleted the $w from the 773 and the child remained linked to the parent because Koha then used the data in the 773 $t of the child record which retrieved the data in the 245 $a of the parent record. It does this even with the syspref "UseControlNumber" set to "Use" and "EasyAnalyticalRecords" set to "Don't Show."
Maybe it shouldn't do this, but I like it--I like the fact that there is a fallback behavior when there is no Control Number (i.e. no $w) to use for searching.
We actually asked for it, because we have both cases getting imported from the union catalog, linked and unlinked. It's not perfect, but it's a nice fallback.
(And I will keep arguing that the "In:..." in the OPAC should be moved down to be consistent with other displays, but more folks in the community like it up near the title and author(s), then I'll probably start arguing to move it up there in the staff client!)
I'll take care of that in a follow-up now.
I think this is a GREAT development, not at all minor, and will be of service to many libraries in getting to their users articles, chapters, papers, songs...all those great things that analytic records are used for.
+100 :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at the diff of this patch set in full made me realize that we didn't change the posiition of the 773 display in results, neither did we add it. It only displayed as Source: before this patch. I'll move it anyway and leave it up to next instance to use the patch or move to separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142036|0 |1 is obsolete| | --- Comment #78 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145521&action=edit Bug 16522: Adding 773 to cart and list displays and emails This enhancement adds information from a host item entry and a link if applicable to the host record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - staff client search results - staff client detail page - opac list - opac cart - opac send list email email - opac send cart email - opac search results - opac detail page To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. Confirm host item info also shows correctly on the OPAC and staff client search results, and the OPAC and staff client detail pages (where XSLT is used) 15. Delete the 773$w and confirm host item info still shows correctly but no longer links to biblio 16. confirm tests pass t/db_dependent/Koha/Biblio/host_record.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142037|0 |1 is obsolete| | --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145522&action=edit Bug 16522: (follow-up) MARC display templates and get_marc_host fixes Also: - Show related parts 773$g - Normalise using 'Host item entry' as title - Remove 'foreach' because non-xslt views only return first - If no $w, use $atg, and related tests in t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142038|0 |1 is obsolete| | --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145523&action=edit Bug 16522: (follow-up) Add missing TT filters Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142039|0 |1 is obsolete| | --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145524&action=edit Bug 16522: (follow-up) Rename "Host item entry" to "In" We already use In: as label for 773 on the result lists and detail pages and it's also recommended in the MARC documentation. With this patch the label is the same everywhere. Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142040|0 |1 is obsolete| | --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145525&action=edit Bug 16522: (follow-up) Fix variable in OPAC cart brief display Without this change records 773 entries with links in $w would not display the title information, but just "No title". With the variable fixed, now the host's title displays. Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142041|0 |1 is obsolete| | --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145526&action=edit Bug 16522: (follow-up) Remove HTML links from email The emails sent for cart and list are plain text and any <a> tag will be scrubbed by HtmlToText. So we can remove those links. This also solves an issue with the original patch set, where the error below would appear on sending a cart or list email from the staff interface: Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127 Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145047|0 |1 is obsolete| | --- Comment #84 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145527&action=edit Bug 16522: (follow-up) If no 773$w, try to return host record Use host biblionumber or host itemnumber to return a host record if EasyAnalyticalRecords is enabled, or return an undef record and a string of host information when get_marc_host is called in list context. Confirm tests pass: - t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #85 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145528&action=edit Bug 16522: Move 773 entries in result lists before 856 entries This moves the display of 773 In: displays to right before the 856 Online resource: as suggested by Heather in order to make it more consistent with the display in the detail pages. Everything should be unchanged, but the position of the In: line :) Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 [Bug 32689] Host item entry (773) missing a space between label and content when $i is used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14341 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #86 from Heather <heather_hernandez@nps.gov> --- I'm happy-dancing about all the latest on this bug--thank you thank you!! #HappyLibrarian #KohaDevelopersRock #CommunityPower #KatrinHasSuperpowers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #87 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #88 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #89 from Lucas Gass <lucas@bywatersolutions.com> --- This patchset doesn't apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #90 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 15. Delete the 773$w and confirm host item info still shows correctly but no longer links to biblio This no longer appears to work in my testing, but I am not sure what happened. The information for unlinked 773 (no $w) is missing from cart display in staff and OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #91 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #90)
15. Delete the 773$w and confirm host item info still shows correctly but no longer links to biblio
This no longer appears to work in my testing, but I am not sure what happened. The information for unlinked 773 (no $w) is missing from cart display in staff and OPAC.
Will be fixed on: Bug 33160 - Make sure 773 (host item entry) displays in the cart when not linked by $w -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 17867 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org