[Bug 35307] New: Expired holds are missing an input, so updating holds causes loss of data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Bug ID: 35307 Summary: Expired holds are missing an input, so updating holds causes loss of data Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In 23.05 when viewing a list of holds expired holds show as 'Expired: mm/dd/yyyy' The table is a form, and when submitted, these expired rows have no input - so the array of expiration dates fetched is out of sync and rows after an expired hold can have dates set incorrectly. To test: 1 - Place 3 holds on a bib, each for a different patron 2 - IN the db, set the first hold to be expired: UPDATE reserves SET expirationdate='2023-01-01' WHERE reserve_id=1; 3 - Refresh the holds page for the biblio 4 - Note the first hold now says 'Expired' in the expiration date column 5 - Set an expiration date for the last hold 6 - Click 'Update holds' 7 - Note the date is applied to the second hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35306 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158888&action=edit Bug 35307: Add a hidden input for expired holds To test: 1 - Place 3 holds on a bib, each for a different patron 2 - IN the db, set the first hold to be expired: UPDATE reserves SET expirationdate='2023-01-01' WHERE reserve_id=1; 3 - Refresh the holds page for the biblio 4 - Note the first hold now says 'Expired' in the expiration date column 5 - Set an expiration date for the last hold 6 - Click 'Update holds' 7 - Note the date is applied to the second hold 8 - Delete the holds 9 - Apply patch 10 - Repeat 1-6 11 - Confirm only the correct hold is updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158888|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 158957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158957&action=edit Bug 35307: Add a hidden input for expired holds To test: 1 - Place 3 holds on a bib, each for a different patron 2 - IN the db, set the first hold to be expired: UPDATE reserves SET expirationdate='2023-01-01' WHERE reserve_id=1; 3 - Refresh the holds page for the biblio 4 - Note the first hold now says 'Expired' in the expiration date column 5 - Set an expiration date for the last hold 6 - Click 'Update holds' 7 - Note the date is applied to the second hold 8 - Delete the holds 9 - Apply patch 10 - Repeat 1-6 11 - Confirm only the correct hold is updated Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Can confirm that this is not an issues on master, and that the patch fixes the issue on 23.05.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158957|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 159006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159006&action=edit Bug 35307: Add a hidden input for expired holds To test: 1 - Place 3 holds on a bib, each for a different patron 2 - IN the db, set the first hold to be expired: UPDATE reserves SET expirationdate='2023-01-01' WHERE reserve_id=1; 3 - Refresh the holds page for the biblio 4 - Note the first hold now says 'Expired' in the expiration date column 5 - Set an expiration date for the last hold 6 - Click 'Update holds' 7 - Note the date is applied to the second hold 8 - Delete the holds 9 - Apply patch 10 - Repeat 1-6 11 - Confirm only the correct hold is updated Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks David for double checking master/main Bug affects 22.11.x but not 22.05.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable Version(s)| |23.05.06 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Pushed to 22.11.x for 22.11.13 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.06 |23.05.06,22.11.13 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |phil@chetcolibrary.org --- Comment #9 from Phil Ringnalda <phil@chetcolibrary.org> --- Landed on the only two affected branches. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org