[Bug 35789] New: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Bug ID: 35789 Summary: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveC ount Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 35782 Blocks: 35781 Can be replaced with biblio.article_requests.filter_by_current.count Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 [Bug 35781] [omnibus] Remove unneeded Koha::Template::Plugin methods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35782 [Bug 35782] Remove Koha::Template::Plugin::Biblio::HoldsCount -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35790 [Bug 35790] Remove Koha::Template::Plugin::Biblio::CanArticleRequest -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160972&action=edit Bug 35789: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount Can be replaced with biblio.article_requests.filter_by_current.count Test plan: Turn on article requests (syspref + circ rule) Request an article (detail page of a bib record) On the left you see "Article requests" tab with the number of current article requests. It should show the correct number (same as before this patch). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- The patch no longer applies - sha1 error: Bug 35789 - Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount 160972 - Bug 35789: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35789: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount error: sha1 information is lacking or useless (Koha/Template/Plugin/Biblio.pm). error: could not build fake ancestor Patch failed at 0001 Bug 35789: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35782 |35788 Status|Patch doesn't apply |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35782 [Bug 35782] Remove Koha::Template::Plugin::Biblio::HoldsCount https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Nind from comment #2)
The patch no longer applies - sha1 error:
The dependencies were not correct. Fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160972|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161042&action=edit Bug 35789: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount Can be replaced with biblio.article_requests.filter_by_current.count Test plan: Turn on article requests (syspref + circ rule) Request an article (detail page of a bib record) On the left you see "Article requests" tab with the number of current article requests. It should show the correct number (same as before this patch). Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Test plan follows correctly. I'd like to add that the AR count also displays on the detail view, not just the left tab. And it works. QA script happy, behavior correct, code is correct. Straight QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35781 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 [Bug 35781] [omnibus] Remove unneeded Koha::Template::Plugin methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We don't have the database update here that came with other similar patches, but maybe it's unlikely that this has been used in notices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Architecture change, nothing to add/edit in the Koha manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Bug 35789 depends on bug 35788, which changed state. Bug 35788 Summary: Remove Koha::Template::Plugin::Biblio::BookingsCount https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org