[Bug 16017] New: Currency constraints and poorly named prices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16017 Bug ID: 16017 Summary: Currency constraints and poorly named prices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Remainder from bug 15084: Note that another report should deal with adding missing constraints on the currency code in suggestions and aqbooksellers. Also note that the aqorder fields listprice and invoiceprice refer to currency. Imo these are very poor names for currency codes; you should never call something a price when you mean a currency code! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16017 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Jonathan: Can I please leave this one for you? :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16017 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15084 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16017 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13323, 13726 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I can, but I won't now. There are bug 13323 and bug 13726 in the queue. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 [Bug 13323] Change the tax rate on receiving https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16017 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just to abuse this report, to add something slightly related: AqordersItem -- what should be the primary key? And why is itemnumber no FK ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16017 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #3)
Just to abuse this report, to add something slightly related:
AqordersItem -- what should be the primary key?
The PK is correct, it's itemnumber
And why is itemnumber no FK ?
See bug 12555 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16017 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16017 Bug 16017 depends on bug 13726, which changed state. Bug 13726 Summary: Koha::Acquisition::Bookseller should use Koha::Object https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org