[Bug 40937] New: No option to show/hide data menu in report results when including borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 Bug ID: 40937 Summary: No option to show/hide data menu in report results when including borrowernumber Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com Depends on: 37188 When borrowernumber was added as an option for batch patron action from reports, it didn't get added to the IF statement that makes the Show/Hide Data Menus button appear. It only knows to show up for cardnumber, biblionumber, itemnumber, or reserve_id. (https://github.com/Koha-Community/Koha/blob/99283025fc4ca0fa1c096344a47b380f...) In a fun little twist, we told Koha to not set batch_cardnumbers if batch_borrowernumbers was already set, to stop the batch operations from showing up twice. (https://github.com/Koha-Community/Koha/blob/99283025fc4ca0fa1c096344a47b380f...) To recreate: 1 - save and run "SELECT borrowernumber FROM borrowers" - no Show/Hide button 2 - save and run "SELECT cardnumber FROM borrowers" - yes Show/Hide button! 3 - save and run "SELECT cardnumber, borrowernumber FROM borrowers" - no Show/Hide button 4 - save and run "SELECT cardnumber, borrowernumber, itemnumber FROM issues LEFT JOIN borrowers USING (borrowernumber)" - yes Show/Hide button! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37188 [Bug 37188] Batch patron modification from report results should be an option when borrowernumber is selected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187268&action=edit Bug 40937: Include show data menu button for batch_borrowernumbers To test: 1 - save and run a report of "SELECT borrowernumber FROM borrowers" 2 - observe your results page does not include the Show Data Menu button 3 - save and run a report of "SELECT cardnumber FROM borrowers" 4 - observe your results page does include the button 5 - save and run a report of "SELECT borrowernumber, cardnumber FROM borrowers" 6 - observe you are once again buttonless on the results page 7 - apply patch 8 - run your report from step 1, observe you now have the button 9 - run your report from step 3, observe you still have the button 10 - run your report from step 5, observe you now have the button 11 - confirm that the batch actions dropdown only includes the patron actions once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187268|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 187947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187947&action=edit Bug 40937: Include show data menu button for batch_borrowernumbers To test: 1 - save and run a report of "SELECT borrowernumber FROM borrowers" 2 - observe your results page does not include the Show Data Menu button 3 - save and run a report of "SELECT cardnumber FROM borrowers" 4 - observe your results page does include the button 5 - save and run a report of "SELECT borrowernumber, cardnumber FROM borrowers" 6 - observe you are once again buttonless on the results page 7 - apply patch 8 - run your report from step 1, observe you now have the button 9 - run your report from step 3, observe you still have the button 10 - run your report from step 5, observe you now have the button 11 - confirm that the batch actions dropdown only includes the patron actions once Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187947|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188029&action=edit Bug 40937: Include show data menu button for batch_borrowernumbers To test: 1 - save and run a report of "SELECT borrowernumber FROM borrowers" 2 - observe your results page does not include the Show Data Menu button 3 - save and run a report of "SELECT cardnumber FROM borrowers" 4 - observe your results page does include the button 5 - save and run a report of "SELECT borrowernumber, cardnumber FROM borrowers" 6 - observe you are once again buttonless on the results page 7 - apply patch 8 - run your report from step 1, observe you now have the button 9 - run your report from step 3, observe you still have the button 10 - run your report from step 5, observe you now have the button 11 - confirm that the batch actions dropdown only includes the patron actions once Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.05 |25.11.00,25.05.05,24.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40937 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org