[Bug 16795] New: Patron categories: Accept integers only for enrolment period and age limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795 Bug ID: 16795 Summary: Patron categories: Accept integers only for enrolment period and age limits Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When creating / editing patron categories, it is possible to enter decimal values for enrolment period and age limits, but vaules are stored as integers (rounded up or down). For example it is possible to enter 0.1 for enrolment period, the value stored will be 0, and the table on page "Patron categories" will show a bare 'until' in column 'Enrolment period'. The fields 'Enrolmentperiod', 'Age required' and 'Upperage limit' should accept integers only. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 52677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52677&action=edit Bug 16795 - Patron categories: Accept integers only for enrolment period and age limits To test: - Apply patch - Clear browser cache - Go to Home > Administration > Patron categories - Create or edit a category - Verify that field 'In months', 'Age required' and 'Upperage limit' accept digits only -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52677|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 52684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52684&action=edit [SIGNED-OFF] Bug 16795 - Patron categories: Accept integers only for enrolment period and age limits To test: - Apply patch - Clear browser cache - Go to Home > Administration > Patron categories - Create or edit a category - Verify that field 'In months', 'Age required' and 'Upperage limit' accept digits only Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52684|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52826&action=edit Bug 16795 - Patron categories: Accept integers only for enrolment period and age limits To test: - Apply patch - Clear browser cache - Go to Home > Administration > Patron categories - Create or edit a category - Verify that field 'In months', 'Age required' and 'Upperage limit' accept digits only Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16286 CC| |julian.maurice@biblibre.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16286 [Bug 16286] Use validation plugin when adding or editing patron category -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org