[Bug 37441] New: Sometimes images don't upload in Uploads Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Bug ID: 37441 Summary: Sometimes images don't upload in Uploads Tool Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: alexandre.noel@inlibro.com QA Contact: testopia@bugs.koha-community.org The file upload tool intermittently fails, causing the selected file to disappear without uploading. The second time we want to upload, it will work. Replicate: 1. Go to Tools > Uploads 2. Click "Choose file" and select any file (png, jpeg, pdf...) 3. Click "Upload" -> The file uploads successfully 4. Click "Delete" to remove the uploaded file. -> The page returns to the upload screen. Repeat steps 2 and 3. -> The selected file is deleted, and is not uploaded, requiring the process to be restarted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Alexandre Noel <alexandre.noel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexandre.noel@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 --- Comment #1 from Alexandre Noel <alexandre.noel@inlibro.com> --- The issue appears to be caused by line 493 (upload.tt): `ShowAlerts( [% msg | html %] );` when deleting an upload, which results in an error in the console log. This happens because the special characters in msg are transformed by the | html filter. This filter was added for security reasons in Bug 13618. I tried removing the `| html` filter, and the error no longer occurred, resolving my issue. I'm concerned that removing this filter might introduce security problems. However, I can see that 'msg' in the Perl file is converted into JSON, and since this is the intranet interface, it probably won't impact security. Let me know if that's correct. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hammat.wele@inlibro.com |ity.org | CC| |hammat.wele@inlibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 --- Comment #2 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170993&action=edit Bug 37441: Sometimes images don't upload in Uploads Tool To test: 1. Go to Tools > Uploads 2. Click 'Choose file' and select any file (png, jpeg, pdf...) 3. Click 'Upload' -> The file uploads successfully 4. Click 'Delete' to remove the uploaded file. -> The page returns to the upload screen. 5. Inspect the page -> There's a javascript error 6. Repeat steps 2 and 3. -> The selected file is not uploaded, requiring the process to be restarted. 7. Apply the patch 8. Repeat step 2, 3, 4, 5 -> There's no more javascript error 9. Repeat steps 2 and 3. -> The selected file is uploaded successfully -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170993|0 |1 is obsolete| | --- Comment #3 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 171036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171036&action=edit Bug 37441: Sometimes images don't upload in Uploads Tool To test: 1. Go to Tools > Uploads 2. Click 'Choose file' and select any file (png, jpeg, pdf...) 3. Click 'Upload' -> The file uploads successfully 4. Click 'Delete' to remove the uploaded file. -> The page returns to the upload screen. 5. Inspect the page -> There's a javascript error 6. Repeat steps 2 and 3. -> The selected file is not uploaded, requiring the process to be restarted. 7. Apply the patch 8. Repeat step 2, 3, 4, 5 -> There's no more javascript error 9. Repeat steps 2 and 3. -> The selected file is uploaded successfully Signed-off-by: Eric Garcia <cubingguy714@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171036|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 173750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173750&action=edit Bug 37441: Sometimes images don't upload in Uploads Tool To test: 1. Go to Tools > Uploads 2. Click 'Choose file' and select any file (png, jpeg, pdf...) 3. Click 'Upload' -> The file uploads successfully 4. Click 'Delete' to remove the uploaded file. -> The page returns to the upload screen. 5. Inspect the page -> There's a javascript error 6. Repeat steps 2 and 3. -> The selected file is not uploaded, requiring the process to be restarted. 7. Apply the patch 8. Repeat step 2, 3, 4, 5 -> There's no more javascript error 9. Repeat steps 2 and 3. -> The selected file is uploaded successfully Signed-off-by: Eric Garcia <cubingguy714@gmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Component|Koha |Templates Status|Passed QA |Pushed to stable Group|Koha security | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | Resolution|--- |FIXED Version(s)|26.05.04,25.11.09,25.05.15, |26.11.00,26.05.04,25.11.09, released in|24.11.20 |25.05.15,24.11.20 Status|Pushed to stable |RESOLVED CC| |pedro.amorim@openfifth.co.u | |k --- Comment #44 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.04,25.11.09, |25.05.15 released in|25.05.15,24.11.20 | --- Comment #45 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oups in 24.11 patch t/Koha/Plugins/json.t is 644 instead of 755 Fixed by commit in 24.11.x : Bug 37441: [24.11] Fix t/Koha/Plugins/json.t perm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 --- Comment #46 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Is the "Version(s) released in" edit intended @Frido? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 --- Comment #47 from David Cook <dcook@prosentient.com.au> --- (In reply to Pedro Amorim (ammopt) from comment #46)
Is the "Version(s) released in" edit intended @Frido?
Must be an error of some kind... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.15 |26.11.00,26.05.04,25.11.09, released in| |25.05.15,24.11.20 --- Comment #48 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Pedro Amorim (ammopt) from comment #46)
Is the "Version(s) released in" edit intended @Frido?
Heurk not at all. I've restored the value :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org