[Bug 9813] New: Update About page with license information about Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Bug ID: 9813 Summary: Update About page with license information about Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: About Assignee: nengard@gmail.com Reporter: oleonard@myacpl.org According to http://twitter.github.com/bootstrap/ the following license terms cover Bootstrap: Code licensed under Apache License v2.0, Glyphicons Free (which we include in original and modified versions) licensed under CC BY 3.0. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Summary|Update About page with |Update About page with |license information about |license information about |Bootstrap |Bootstrap and jQuery --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- jQuery projects (including both jQuery and jQueryUI) are licensed under the MIT license. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16100&action=edit Bug 9813 - Update About page with license information about Bootstrap and jQuery This patch adds license information about Bootstrap, jQuery, and jQueryUI to the About page in the staff client. To test, view the About page and confirm that information appears about Bootstrap, jQuery, and jQueryUI with working links. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard@gmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16100|0 |1 is obsolete| | --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 16103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16103&action=edit Bug 9813 - Update About page with license information about Bootstrap and jQuery This patch adds license information about Bootstrap, jQuery, and jQueryUI to the About page in the staff client. To test, view the About page and confirm that information appears about Bootstrap, jQuery, and jQueryUI with working links. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Fixed a small typo - Boostrap -> Bootstrap, otherwise looks great. Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Owen, don't we want jQuery and Bootstrap in a h2 title, not h3? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16103|0 |1 is obsolete| | --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 16123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16123&action=edit Bug 9813 - Update About page with license information about Bootstrap and jQuery This patch adds license information about Bootstrap, jQuery, and jQueryUI to the About page in the staff client. To test, view the About page and confirm that information appears about Bootstrap, jQuery, and jQueryUI with working links. Fixed a small typo and changed erroneous h3's to h2's to match the other listings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Thanks Liz! On an ergonomic point of view it looks good. On a juridic point of view, it was already debated. Apache v2 is GPLv3 compatible (http://www.apache.org/licenses/GPL-compatibility.html), so no problem. I just have a little question about Glyphicons Free, on its license page (http://glyphicons.com/glyphicons-licenses/), I understand: if the CC BY 3.0 is used, we should include the url (to glyphicons.com) on every page they appear. As we used the icon set from bootstrap, don't we use it under the Apache v2 license? (And so the link appears in the about page, as requested). Sorry if I misunderstood something or I the question has already been asked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- Glyphicons website says: Glyphicons Halflings are also a part of Bootstrap by Twitter, and are released under the same license as Bootstrap. While you are not required to include attribution on your Bootstrap-based projects, I’d certainly appreciate a visibile link back to glyphicons.com in any place you find appropriate (footer, docs, etc). I think the visible link in the about page should cover it for the intranet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 --- Comment #8 from Liz Rea <liz@catalyst.net.nz> --- http://glyphicons.com/glyphicons-licenses/ our case is the "included in bootstrap" case. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #8)
http://glyphicons.com/glyphicons-licenses/
our case is the "included in bootstrap" case.
Yes, so don't we point out we use Glyphicons Free under the Apache License v2 instead of the CC BY 3.0 license? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16123|0 |1 is obsolete| | --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 16196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16196&action=edit Bug 9813 - Update About page with license information about Bootstrap and jQuery This patch adds license information about Bootstrap, jQuery, and jQueryUI to the About page in the staff client. To test, view the About page and confirm that information appears about Bootstrap, jQuery, and jQueryUI with working links. Fixed a small typo and changed erroneous h3's to h2's to match the other listings Moved glyphicons link to indicate that it is licensed under the same terms as bootstrap - with Apache 2.0 license and not CC-BY. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16196|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16319&action=edit Bug 9813 - Update About page with license information about Bootstrap and jQuery This patch adds license information about Bootstrap, jQuery, and jQueryUI to the About page in the staff client. To test, view the About page and confirm that information appears about Bootstrap, jQuery, and jQueryUI with working links. Fixed a small typo and changed erroneous h3's to h2's to match the other listings Moved glyphicons link to indicate that it is licensed under the same terms as bootstrap - with Apache 2.0 license and not CC-BY. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Looks to me now. This patch adds license Apache License v.2.0 for Bootstrap and Glyphicons Free and MIT License for jQuery and jQueryUI. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16319|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16342&action=edit Bug 9813 - Update About page with license information about Bootstrap and jQuery This patch adds license information about Bootstrap, jQuery, and jQueryUI to the About page in the staff client. To test, view the About page and confirm that information appears about Bootstrap, jQuery, and jQueryUI with working links. Fixed a small typo and changed erroneous h3's to h2's to match the other listings Moved glyphicons link to indicate that it is licensed under the same terms as bootstrap - with Apache 2.0 license and not CC-BY. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9813 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org