https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18706 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- submitBackgroundJob is used by : offline_circ/ process_koc.tt tools/ batch_record_modification.tt batchMod-del.tt batchMod-edit.tt manage-marc-import.tt stage-marc-import.tt Disabled input can exist in batchMod, what about the others ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Can you further explain the bug? I'm not sure what you're describing here. 1. I go to /cgi-bin/koha/tools/batchMod.pl 2. I enter a barcode and submit the form 3. I see all the item fields that I can use for doing the batch edit What's "input of deleted subfields are disabled" mean? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707

--- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> ---
(In reply to David Cook from comment #3)
> Can you further explain the bug? I'm not sure what you're describing here. 
> 
> 1. I go to /cgi-bin/koha/tools/batchMod.pl
> 2. I enter a barcode and submit the form
> 3. I see all the item fields that I can use for doing the batch edit
> 
> What's "input of deleted subfields are disabled" mean?

Hie, thanks for testing this.

>For example, in Tools > Batch item modification input of deleted subfields are disabled.
I mean, in this form there is for each subfield :
- a text input or select to change the value of this subfield
- a checkbox to delete the subfield
When checking the checkbox, the text input or select is set to disable (HTML
attribute). So that it can't be edited and, but more important, it is not sent
when form is submitted. This is important because the code looks to subfields
to modify with those inputs.

The bug is that with backgound job, inputs are sent event when they have de
HTML attribut "disabled".

-- 
You are receiving this mail because:
You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Missing test plan... but I tested multiple batch operations and the change makes sense. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91065|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91396&action=edit Bug 18707: Background jobs post disabled inputs For example, in Tools > Batch item modification input of deleted subfields are disabled. This form is posted using background job via JS code. Looks like this JS code converts a POST form into a GET URL, including inputs that are disabled : koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js function submitBackgroundJob(f) { ... $(':input', f).each(function() { ... This patch add a :enabled to selector Test plan : <to define> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.