[Bug 37141] New: Add option to display completed bookings from patron page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Bug ID: 37141 Summary: Add option to display completed bookings from patron page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Currently on the bookings tab of the patron pages, we always filter to active bookings. We should add the option to display completed bookings too; This would match the functionality introduced in the biblio details view for bookings in bug 37065 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37047 [Bug 37047] Patron Bookings not visible from Patrons Checkout page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167934&action=edit Bug 37141: Add 'Include completed' option to bookings tab This patch adds the 'Include completed' filter toggle option to the bookings display tab on both the patron details and circulation pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168420&action=edit Bug 37141: Add 'Show completed' option to bookings tab This patch adds the 'Show completed' filter toggle option to the bookings display tab on both the patron details and circulation pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167934|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37065 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Keywords| |Academy, Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 --- Comment #3 from Kristi <kkrueger@cuyahogalibrary.org> --- Is there a test plan for this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I tested like this: 1) Create a booking for any item. 2) Open a db shell with `koha-mysql <INSTANCE>` 3) Update the created booking with: ` update bookings set start_date = '<date in the past>', end_date = '<date also in the past'> where booking_id = '<booking id of the booking you just created>'. ` 4) Go the the bookings tab of said item. 5) Notice that a 'Show expired' link/button appears on the top left of the table. Also note that the booking you created isn't displayed because it's in the past. 6) Click the 'Show expired' button. 7) Notice that the expired booking is now shown. 8) Sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- PS: after you applied the patch :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168420|0 |1 is obsolete| | --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170057&action=edit Bug 37141: Add 'Show completed' option to bookings tab This patch adds the 'Show completed' filter toggle option to the bookings display tab on both the patron details and circulation pages. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- This doesn't work for me, I had to move the line: let filter_expired = true; up in scope , then the link worked. There is another issue, if the patron has no current bookings the table is not loaded and you can't see their expired bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Strange that the first issue didn't come up for me. I'll take a look at it again in a bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I've looked at the wrong page because it didn't read the title of this bug. My sign-off is therefore invalid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170063&action=edit Bug 37141: (follow-up) Move filter_expired to outer scope This allows access by the bookings-tab and the expired_filter click handlers which are both required for the state change to work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170064&action=edit Bug 37141: (follow-up) Check for expired bookings when rendering bookings table We preserve the existing logic of this bug and add another case for when we just encounter expired bookings. In that case we render the fieldset without the 'filtered' class and determine the value of filter_expired in bookings.js by the class being set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170057|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 170081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170081&action=edit Bug 37141: Add 'Show completed' option to bookings tab This patch adds the 'Show completed' filter toggle option to the bookings display tab on both the patron details and circulation pages. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170063|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 170082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170082&action=edit Bug 37141: (follow-up) Move filter_expired to outer scope This allows access by the bookings-tab and the expired_filter click handlers which are both required for the state change to work. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170064|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 170083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170083&action=edit Bug 37141: (follow-up) Check for expired bookings when rendering bookings table We preserve the existing logic of this bug and add another case for when we just encounter expired bookings. In that case we render the fieldset without the 'filtered' class and determine the value of filter_expired in bookings.js by the class being set. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement to release notes| |bookings now shows | |completed bookings for | |patrons on their check out | |and details page. There is | |now a filter to show | |expired and hide expired | |bookings (similar to what | |is shown on a record's | |bookings page.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170081|0 |1 is obsolete| | Attachment #170082|0 |1 is obsolete| | Attachment #170083|0 |1 is obsolete| | --- Comment #15 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170088&action=edit Bug 37141: Add 'Show completed' option to bookings tab This patch adds the 'Show completed' filter toggle option to the bookings display tab on both the patron details and circulation pages. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 --- Comment #16 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170089&action=edit Bug 37141: (follow-up) Move filter_expired to outer scope This allows access by the bookings-tab and the expired_filter click handlers which are both required for the state change to work. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 --- Comment #17 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170090&action=edit Bug 37141: (follow-up) Check for expired bookings when rendering bookings table We preserve the existing logic of this bug and add another case for when we just encounter expired bookings. In that case we render the fieldset without the 'filtered' class and determine the value of filter_expired in bookings.js by the class being set. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 --- Comment #18 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170091&action=edit Bug 37141: Tidy JS Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37574 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 [Bug 37574] Add visual indicator that bookings are expired -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks so much for taking this one over Paul.. you've done a great job with the follow-ups I hadn't managed to get on to yet! Thanks for the testing and quick QA Nick! Go teamwork! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |bookings function| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, Sandbox | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please keep in mind, we need to use double underscores for translatable strings in .js files. Fixed in a follow-up. Fixed in a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Bug 37141 depends on bug 37047, which changed state. Bug 37047 Summary: Patron bookings are not visible from patrons checkout page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37047 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |aude.charillon@openfifth.co | |.uk --- Comment #22 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Screenshot in the Koha Manual already shows filter. No additional wording required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org