[Bug 27068] New: HoldsQueue doesn't know how to use holds groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Bug ID: 27068 Summary: HoldsQueue doesn't know how to use holds groups Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 22284 Bug 22284 added local holds groups, but didn't teach the holds queue how to use them. It needs to do that. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Add ability to define groups of locations for hold pickup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113900&action=edit Bug 27068: Add hold group limits to Holds Queue builder -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |agustinmoyano@theke.io -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- My patch is incomplete. HoldsQueue needs to understand how to handle hold_fullfillment_policy for "holdgroup" and "patrongroup". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- It should be relying on $item->pickup_locations more heavily. Will take a look on monday with Agustin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|agustinmoyano@theke.io |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113900|0 |1 is obsolete| | --- Comment #4 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 114125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114125&action=edit Bug 27068: Control hold group logic in HoldsQueue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io --- Comment #5 from Agustín Moyano <agustinmoyano@theke.io> --- Hello Kyle, could you please checkout this patch? I've placed holds policy checking (including hold groups) inside a function called _checkHoldsPolicy, and call it whenever it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114125|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 114140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114140&action=edit Bug 27068: Control hold group logic in HoldsQueue Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 114141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114141&action=edit Bug 27068: Fix errors in _checkHoldPolicy Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 114142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114142&action=edit Bug 27068: Fetch libraries once for speed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- What would be the test plan? Here is a try: 1) In library groups add a root group and check it as hold group. 2) Add two libraries to the group 3) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 4) Place a hold from a patron whose home library is from the group 5) Go to hold queue of the record 6) ??? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen@gmail.com |agustinmoyano@theke.io -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #10 from Lisette Scheer <lisetteslatah@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #9)
What would be the test plan?
Here is a try: 1) In library groups add a root group and check it as hold group. 2) Add two libraries to the group 3) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 4) Place a hold from a patron whose home library is from the group
5) Go to /cgi-bin/koha/circ/view_holdsqueue.pl 6) Select the holding branch of the item with a hold 7) observe no results 8) Apply Patch 9) Repeat 5-6 10) The item should come up on the holds queue results 11) Place a hold on an item where 1 record has 2 copies, 1 in the hold group, 1 not. 12) Run the HoldQueue for the library not in the group and make sure the hold isn't showing. 13) Turn on transportation cost matrix and set costs for the libraries within the group. 14) Place a hold for a patron where multiple copies are on the bib. 15) Check both branch's hold queue for the item, it should only show on the lower cost branch's list if both copies are available. Agustin or Kyle could probably tell us if there are any steps missing in there. These are steps I wrote based on experience with the problem at hand and looking at the diff for the patches. Lisette -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks for completing the test plan :)
10) The item should come up on the holds queue results
Unfortunately it doesn't come up. My patron's library is Centerville The item's current and home library is Centerville Centerville is in the group This configuration should work right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #11)
Thanks for completing the test plan :)
10) The item should come up on the holds queue results
Unfortunately it doesn't come up.
My patron's library is Centerville The item's current and home library is Centerville Centerville is in the group
This configuration should work right?
Did you run the build_holds_queue script? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Hi Augustin, this one needs unit tests for the changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114142|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115987&action=edit Bug 27068: Fetch libraries once for speed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114140|0 |1 is obsolete| | Attachment #114141|0 |1 is obsolete| | Attachment #115987|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116022&action=edit Bug 27068: Control hold group logic in HoldsQueue Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116023&action=edit Bug 27068: Fix errors in _checkHoldPolicy Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116024&action=edit Bug 27068: Fetch libraries once for speed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116025&action=edit Bug 27068: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116025|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116026&action=edit Bug 27068: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116022|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116607&action=edit Bug 27068: Control hold group logic in HoldsQueue Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116023|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116608&action=edit Bug 27068: Fix errors in _checkHoldPolicy Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116024|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116609&action=edit Bug 27068: Fetch libraries once for speed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116026|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116610&action=edit Bug 27068: Add unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- No regressions found, working as expected for me. QA scripts passing and we've got unit tests and they pass. Passing QA Can we get some text for the release notes though pretty please ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Koha 20.05 introduced local release notes| |hold groups, but neglected | |to add support of them in | |the holds queue. Because of | |this, the holds queue will | |not show items the could | |have filled holds from | |other libraries in a hold | |group. This patch set adds | |support for hold groups to | |the holds queue builder | |thus improving Koha's | |ability to find items to | |fill hold requests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116814&action=edit Bug 27068: Don't 'cache' Koha::Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116815&action=edit Bug 27068: Perltidy _checkHoldPolicy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords|release-notes-needed | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The way we cache Koha::Libraries at package level is quite a poor design here. I understand that we are doing it because _checkHoldPolicy is called in a loop, but we should maybe then redesign something else. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #27)
The way we cache Koha::Libraries at package level is quite a poor design here. I understand that we are doing it because _checkHoldPolicy is called in a loop, but we should maybe then redesign something else.
What do you think?
Undoing it is fine with me. This runs as a cronjob so speed isn't of the utmost concern. If we really wanted to, we could use Koha::Cache. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116814|0 |1 is obsolete| | Attachment #116815|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116816&action=edit Bug 27068: Don't 'cache' Koha::Libraries Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116817&action=edit Bug 27068: Perltidy _checkHoldPolicy Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #32 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | --- Comment #33 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #34 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Well drat. I've for test failures after backporting this to 20.05: root@kohadevbox:koha(rmain2005)$ prove t/db_dependent/HoldsQueue.t t/db_dependent/HoldsQueue.t .. 3/55 The method Koha::Item->exclude_from_local_holds_priority is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 780 Koha::Object::AUTOLOAD('Koha::Item=HASH(0x56534a141a70)') called at /kohadevbox/koha/C4/HoldsQueue.pm line 457 C4::HoldsQueue::MapItemsToHoldRequests('ARRAY(0x56534a155a30)', 'ARRAY(0x56534a11abd8)', 'ARRAY(0x56534a141008)', undef) called at /kohadevbox/koha/C4/HoldsQueue.pm line 212 C4::HoldsQueue::CreateQueue at t/db_dependent/HoldsQueue.t line 388 # Looks like your test exited with 11 just after 26. t/db_dependent/HoldsQueue.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 29/55 subtests Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 2816 Tests: 26 Failed: 0) Non-zero exit status: 11 Parse errors: Bad plan. You planned 55 tests but ran 26. Files=1, Tests=26, 3 wallclock secs ( 0.02 usr 0.01 sys + 1.76 cusr 0.36 csys = 2.15 CPU) Result: FAIL root@kohadevbox:koha(rmain2005)$ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #35 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 19.11.x, it's not affected, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 117215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117215&action=edit [20.05.x] Bug 27068: (follow-up) Remove local hold priority exclusion-related code for 20.05.x The local hold priority exclusions feature is only present in 20.11, so the use case handling shouldn't be included in the backport. This code removes the couple lines in which this is handled (trivial) and tested (trivial, as it is disabled by default on the tests, we just remove the places in which the original patch set the non-existent attributes). To test: 1. Run: $ kshell k$ prove t/db_dependent/HoldsQueue.t => FAIL: Tests fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24359 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 [Bug 24359] Remove items from Holds Queue when checked in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28766 [Bug 28766] Fix remaining instance of missing sub checkHoldPolicy in C4/HoldsQueue.pm -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org