[Bug 32112] New: Misaligned checkbox and text in batchmod.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 Bug ID: 32112 Summary: Misaligned checkbox and text in batchmod.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When deleting items in batch, there is an option to delete the bibliographic record if all the items are deleted. In the new design, the text and the checkbox for this option are misaligned. They are also on the same line as the button to delete the item, which was not the case before. To test: 1. Go to a bibliographic record that has items 2. Click Edit > Delete items in a batch --> At the bottom of the resulting screen, there is a checkbox 'Delete records if no items remain', which is misaligned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 143209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143209&action=edit Screenshot of the items batch deletion tool in the old design This is a screenshot of the items batch deletion tool in the old design. Note that the text and checkbox under the table are aligned, and also on their own line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 143210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143210&action=edit Screenshot of the items batch deletion tool in the new design This is a screenshot of the items batch deletion tool in the new design. Note that the checkbox and text are misaligned and also on the same line as the button and cancel option. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I just noticed that the line break is not in the more recent versions. I was comparing with the manual screenshot, which dates back to I don't know when, but I checked in a 21.05 instance and the option is on the same line as the button and delete option. I kind of like when it is on two lines, but I don't know why it was changed, and maybe there is a reason it was put on the same line... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Misaligned checkbox and |Move "Delete selected |text in batchmod.pl |items" button to new line Depends on| |30952 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The checkbox and the label now align correctly on maser - I believe this to be a positive side-effect from some other fixes. We the Save button is still on the same line as the checkbox, that might be something to still look into here. Adjusting bug description. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143920&action=edit Bug 32112: Move 'Delete selected items' to its own line This moves the checkbox and its label out of the action field set which makes it appear above the bottons instead of in front of it. To test: * Go to any record * Select items and send to item batch delete * Verify checkbox appears in front of button * Apply patch * Verify the checkbox and the yellow 'delete selected items' button are now on separate lines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143920|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 143931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143931&action=edit Bug 32112: Move 'Delete selected items' to its own line This moves the checkbox and its label out of the action field set which makes it appear above the bottons instead of in front of it. To test: * Go to any record * Select items and send to item batch delete * Verify checkbox appears in front of button * Apply patch * Verify the checkbox and the yellow 'delete selected items' button are now on separate lines Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143931|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 143944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143944&action=edit Bug 32112: Move 'Delete selected items' to its own line This moves the checkbox and its label out of the action field set which makes it appear above the bottons instead of in front of it. To test: * Go to any record * Select items and send to item batch delete * Verify checkbox appears in front of button * Apply patch * Verify the checkbox and the yellow 'delete selected items' button are now on separate lines Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112 Bug 32112 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org