[Bug 7403] New: CataloguingLog warning incorrect
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403 Bug #: 7403 Summary: CataloguingLog warning incorrect Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration AssignedTo: paul.poulain@biblibre.com ReportedBy: nengard@gmail.com QAContact: ian.walls@bywatersolutions.com CC: gmcharlt@gmail.com The CataloguingLog preference says "Since this occurs whenever a book is checked in or out as well, it is not advisable to turn this on." but no one has ever been able to confirm that this is true. This warning should be removed unless someone can point to the code that makes this warning accurate.
From IRC:
[09:18] <nengard> has anyone ever tested and confirmed the warning on the cataloguinglog preference? it says that its slows things down cause it tracks everytime the barcode is scanned - is that right? is the warning valid? [09:19] <jcamins> nengard: it is not correct. [09:19] <jcamins> nengard: at least, so far as I know. [09:19] <nengard> that's what i thought!!! [09:19] <nengard> and thank you jcamins [09:19] <nengard> i've asked this at least once a year for the last 4 years! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2012-01-05 14:47:53 UTC --- Okay, the log does track all checkouts and ins, but the warning isn't exactly clear - we need to say that it's a size issue - and not a performance issue: [09:29] <sekjal> nengard: I believe it's been incorrect since 3.4 was released, and items were removed from the biblio. [09:29] <tcohen> jcamins: AddIssue calls ModItem which happens to do some logging [09:29] <jcamins> nengard: I stand corrected. [09:30] <nengard> so it is incorrect now [09:30] <nengard> but wasn't before [09:30] <jcamins> tcohen: does it actually log anything? 3.6, it seems to me, is not logging issues in the cataloguing log. [09:31] <jwagner> jcamins, you forgot biblioitems from your truncate list. Also need to check for any issues or reserves. [09:32] <tcohen> jcamins, i might be wrong, but I just checked that AddIssue calls ModItem [09:32] <tcohen> which happens to have : [09:32] <tcohen> logaction("CATALOGUING", "MODIFY", $itemnumber, Dumper($item)) if C4::Context->preference("CataloguingLog"); [09:32] <tcohen> inside [09:32] <tcohen> i think it is not a problem any more, thou [09:33] <tcohen> because we don't do a ModBiblio, which was reallly expensive [09:33] <jcamins> jwagner: thanks. [09:33] <jcamins> nengard: the warning may still be correct, then. [09:33] <jcamins> nengard: I've never noticed any particular performance issues, though. [09:33] <tcohen> (because we log the whole marc there) [09:39] <nengard> yes, i just tested and when i checked an item out it added two lines to the cataloging log [09:39] <nengard> but does it actually slow things down? [09:40] <sekjal> nengard: I don't think it's so much an issue of slowing down transactions, as storing TONS of data [09:40] <sekjal> so accessing the log table becomes slow [09:40] <sekjal> but I don't believe it would affect circ transactions or normal response time [09:40] <nengard> libraries might be okay with that - whereas they won't be okay with things slowing down checkouts and such [09:40] <tcohen> nengard, prior to removing items from marc/marcxml every time an item was borrowed [09:41] <tcohen> the biblio itself was modified [09:41] <tcohen> (the marc/marcxml stuff) [09:41] <tcohen> and the change was then logged [09:41] <nengard> it's nice to see that i just had to report a bug to get an answer to my question - like i said i've been asking about this for the manual for 4 years now [09:41] <tcohen> that was an expensive task, as the marc itself is saved in the log -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The warning is still present on current master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The warning is still present, also we somehow seem to add 2 entries for each checkout and return of an item. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403 --- Comment #4 from Marc Véron <veron@veron.ch> --- (In reply to Katrin Fischer from comment #3)
The warning is still present, also we somehow seem to add 2 entries for each checkout and return of an item.
Check out an item generates 2 entries: 2016-01-26 17:14:16 A. Testman (51) Catalog Modify Item 364 item $VAR1 = { 'itemnumber' => '364', 'issues' => 1, 'datelastborrowed' => '2016-01-26', 'holdingbranch' => 'CPL', 'itemlost_on' => undef, 'itemlost' => 0, 'onloan' => '2016-02-04' }; 2016-01-26 17:14:16 A. Testman (51) Catalog Modify Item 364 item $VAR1 = { 'itemnumber' => '364', 'datelastseen' => '2016-01-26', 'itemlost_on' => undef, 'itemlost' => 0 }; Check in the item generates 3 entries, #1 and #2 are identical: 2016-01-26 17:16:21 A. Testman (51) Catalog Modify Item 364 item $VAR1 = { 'itemnumber' => '364', 'onloan' => undef }; 2016-01-26 17:16:21 A. Testman (51) Catalog Modify Item 364 item $VAR1 = { 'itemnumber' => '364', 'onloan' => undef }; 2016-01-26 17:16:21 A. Testman (51) Catalog Modify Item 364 item $VAR1 = { 'itemnumber' => '364', 'datelastseen' => '2016-01-26', 'itemlost_on' => undef, 'itemlost' => 0 }; It will be difficult to get that right, because while checking in and out, ModItem is called several times and generates each time a log entry (C4/Items.pm line 608) Maybe the logs for items and for bibliographic records could be separated? E.g. use 'Cataloguing' for records only and a new log 'Items' for Items? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org