[Bug 19770] New: Add cardnumber to holds awaiting pickup screen and add classes to borrower info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Bug ID: 19770 Summary: Add cardnumber to holds awaiting pickup screen and add classes to borrower info Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Some libraries use a combination of borrowers surname and cardnumber on hold slips, this seems to be a fairly common occurence. To facilitate this it would be nice to have the cardnumber available on the waiting holds report. Additionally it would be nice to have classes add to the borrower information so that they can be accessed via javascript for constructing the special code used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 69607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69607&action=edit Bug 19770 - Add cardnumber to holds awaiting pickup and add classes to borrower info To Test: 1 - View the holds awaiting pickup report 2 - Note there is no cardnumber 3 - Apply patch 4 - Cardnumber now shows 5 - Add to IntranetUserCSS .borrowercardnumber { display: none; } 6 - Cardnumber does not show 7 - Verify the same works for 'Holds over' tab 8 - Sign off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69607|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69612&action=edit Bug 19770 - Add cardnumber to holds awaiting pickup and add classes to borrower info To Test: 1 - View the holds awaiting pickup report 2 - Note there is no cardnumber 3 - Apply patch 4 - Cardnumber now shows 5 - Add to IntranetUserCSS .borrowercardnumber { display: none; } 6 - Cardnumber does not show 7 - Verify the same works for 'Holds over' tab 8 - Sign off Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why did not you choose to use patron-title.inc? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, patch doesn't apply. Can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- I think Joubu is right, this should be done using patron-title.inc and that should be adding the spans -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick@bywatersolutions.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83919&action=edit Bug 19770: Add cardnumber and CSS classed to patron info on waiting holds Patch makes use fo patron-string.inc for displaying the patron information on the waiting holds report. It also adds spans with classes for phone and email. To Test: 1 - View the holds awaiting pickup report 2 - Note there is no cardnumber for the patron 3 - Apply patch 4 - Cardnumber shows now 5 - Verify the same works for 'Holds over' tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69612|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83919|0 |1 is obsolete| | --- Comment #7 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 84224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84224&action=edit Bug 19770: Add cardnumber and CSS classed to patron info on waiting holds Patch makes use fo patron-string.inc for displaying the patron information on the waiting holds report. It also adds spans with classes for phone and email. To Test: 1 - View the holds awaiting pickup report 2 - Note there is no cardnumber for the patron 3 - Apply patch 4 - Cardnumber shows now 5 - Verify the same works for 'Holds over' tab Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84224|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 84270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84270&action=edit Bug 19770: Add cardnumber and CSS classed to patron info on waiting holds Patch makes use fo patron-string.inc for displaying the patron information on the waiting holds report. It also adds spans with classes for phone and email. To Test: 1 - View the holds awaiting pickup report 2 - Note there is no cardnumber for the patron 3 - Apply patch 4 - Cardnumber shows now 5 - Verify the same works for 'Holds over' tab Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24024 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org