https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82568&action=edit Bug 21871: Show authority 856 links in the OPAC This patch modifies the authority detail view in the OPAC so that any links found in 856 tags are displayed and active. To test, apply the patch and locate or create an authority record which contains one or more URLs in 856 tags. - View this record in the OPAC and confirm that the links appear. - Test records with and without link text. - Test records with and without public notes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82568|0 |1 is obsolete| | --- Comment #2 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 82596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82596&action=edit Bug 21871: Show authority 856 links in the OPAC This patch modifies the authority detail view in the OPAC so that any links found in 856 tags are displayed and active. To test, apply the patch and locate or create an authority record which contains one or more URLs in 856 tags. - View this record in the OPAC and confirm that the links appear. - Test records with and without link text. - Test records with and without public notes. All tested and it worked, nice job Owen. What do you think about to add similar links in Intranet authorities detail page so librarians can directly reach the resource when they click them? Signed-off-by: Devinim <kohadevinim@devinim.com.tr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The display works, but I think the code for the TrackClicks should not be there. The linktracker table only has a bilbionumber column, nothing is tracked there if you click on the authority links now. I suggest removing it and adding a separate bug to make it possible to track links for authorities. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84005&action=edit Bug 21871: (follow-up) Remove link tracking Links to tracklinks.pl were erroneously copied from detail.tt. This patch removes them. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83834|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84466&action=edit Bug 21871: Show authority 856 links in the OPAC This patch modifies the authority detail view in the OPAC so that any links found in 856 tags are displayed and active. To test, apply the patch and locate or create an authority record which contains one or more URLs in 856 tags. - View this record in the OPAC and confirm that the links appear. - Test records with and without link text. - Test records with and without public notes. Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84466|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84468&action=edit Bug 21871: Show authority 856 links in the OPAC This patch modifies the authority detail view in the OPAC so that any links found in 856 tags are displayed and active. To test, apply the patch and locate or create an authority record which contains one or more URLs in 856 tags. - View this record in the OPAC and confirm that the links appear. - Test records with and without link text. - Test records with and without public notes. Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=21817 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84470&action=edit Bug 21871: (QA follow-up) Use Koha.Preference in template Use TT plugin to get value for OPACURLOpenInNewWindow. Works without, but might be a little nicer. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=21817 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Suggesting 2 follow-ups: I think it's a tiny bit irritating to use something from Biblio in authorities... but I know we will get to make this all shiny at some point with the new API. Added a qw() to help remember what we exactly need this for here. Suggest use of TT plugin in the template. Kept them separate, so you can pick and choose :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.