[Bug 12547] New: Create better API for handling external authentication
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 Bug ID: 12547 Summary: Create better API for handling external authentication Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt@gmail.com Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org At the moment, authentication is really handled all that consistently. There is Auth_with_cas.pm, Auth_with_ldap.pm, and perhaps one day Auth_with_Shibboleth.pm. There is also Persona which relies on a DOM API and Javascript on some OPAC pages. All of these different methods also hook into Auth.pm. They all work but it's not really that easy to see how they work nor is it straightforward to add new forms of external authentication. I don't have a plan of how to improve C4::Auth::checkauth() or C4::Auth, but I think it's worth thinking about. Obviously, it would require a ton of testing, but perhaps we could have incremental improvements. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3237 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8446 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- "At the moment, authentication isn't really handled all that consistently"* It's also not documented very well, but I'll create a new bug for that... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12548 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #1)
"At the moment, authentication isn't really handled all that consistently"*
It's also not documented very well, but I'll create a new bug for that...
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #2)
(In reply to David Cook from comment #1)
"At the moment, authentication isn't really handled all that consistently"*
It's also not documented very well, but I'll create a new bug for that...
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548
Actually, the more I review C4::Auth::checkauth(), maybe more in-line documentation and better indenting is all that is required at the moment... it probably would be a good idea to switch to Koha::Auth at some point, but a good first step would be to get a better handle on the existing situation, I think... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I am slowly on the case here.. starting with a non-destructive tidy of the code found in bug 13499. The aim is to Tidy -> Document -> Write Tests -> Refactor -> Rewrite over a long period... even if I only get steps one and two done I'd be pretty happy that we're moving forward. Fancy verifying that my tidy actually improves things and maintain git blame history David? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #4)
I am slowly on the case here.. starting with a non-destructive tidy of the code found in bug 13499.
The aim is to Tidy -> Document -> Write Tests -> Refactor -> Rewrite over a long period... even if I only get steps one and two done I'd be pretty happy that we're moving forward.
Fancy verifying that my tidy actually improves things and maintain git blame history David?
It's been a while now since I've looked at the C4::Auth code, but I'll do my best when I can to check it out :). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org