[Bug 23775] New: Claiming a serial issue doesn't create the next one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Bug ID: 23775 Summary: Claiming a serial issue doesn't create the next one Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com == test plan == 1. have a vendor with an email address for claiming late issues 2. have a subscription linked to this vendor - You can create a new one with arbitrary values 3. Go to "Serial collection" 4. click "Edit serials" 5. Status of the latest: change from Expected to Claimed 6. save 7. see that the next issue has been created 8. go to /cgi-bin/koha/serials/claims.pl 9. make a claim on the expected issue of the previously used serial 10. Then you see that the next issue hasn't been created -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |victor.grousset@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.breuillard@biblibre. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 --- Comment #1 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 133119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133119&action=edit Bug 23775: Claiming a serial issue doesn't create the next one Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'. Test Plan: -- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today -- 1)On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked 2)Then Home > Serials > Claims > Claims for <your_vendor_name> 3)Check the row of the serial with the EXPECTED status 4)Click 'Send notification' 5)Notice the status of the row : it is now CLAIMED 6)To verify: Home > Serials > Serial collection information for <your_record_name> 7)The status is CLAIMED too & a new serial with an EXPECTED status has appeared on the table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133119|0 |1 is obsolete| | --- Comment #2 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 133122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133122&action=edit Bug 23775: Claiming a serial issue doesn't create the next one Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'. Test Plan: -- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today -- 1)On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked 2)Then Home > Serials > Claims > Claims for <your_vendor_name> 3)Check the row of the serial with the EXPECTED status 4)Click 'Send notification' 5)Notice the status of the row : it is now CLAIMED 6)To verify: Home > Serials > Serial collection information for <your_record_name> 7)Here the status is CLAIMED too but nothing happened around 8)Apply patch 9)Repeat from 2) to 6) 10)The status is still CLAIMED & the new serial with status EXPECTED is freshly generated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|victor@tuxayo.net |jeremy.breuillard@biblibre. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> ---
3)Check the row of the serial with the EXPECTED status 4)Click 'Send notification' 5)Notice the status of the row : it is now CLAIMED
I don't know if I'm doing something wrong, but this step doesn't work for me. The status of the issue remains EXPECTED. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 --- Comment #4 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Thanks for the feedback, it works fine on my computer. I have changed the test plan to be clearer :
3)Tick the checkbox of the row where the status is EXPECTED then 4)Click 'Send notification' 5)Notice the status of the row : it is now CLAIMED
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133122|0 |1 is obsolete| | --- Comment #5 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 134062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134062&action=edit Bug 23775: Claiming a serial issue doesn't create the next one Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'. Test Plan: -- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today -- 1)On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked 2)Then Home > Serials > Claims > Claims for <your_vendor_name> 3)Tick the checkbox of the row where the status is EXPECTED then 4)Click 'Send notification' 5)Notice the status of the row : it is now CLAIMED 6)To verify: Home > Serials > Serial collection information for <your_record_name> 7)Here the status is CLAIMED too but nothing happened around 8)Apply patch 9)Repeat from 2) to 6) 10)The status is still CLAIMED & the new serial with status EXPECTED is freshly generated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Thibault Keromnès <thibault.keromnes@univ-paris8.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |thibault.keromnes@univ-pari | |s8.fr --- Comment #6 from Thibault Keromnès <thibault.keromnes@univ-paris8.fr> --- Tried on a sandbox, doesn't apply : TASK [Apply bug 23775 via git-bz in docker container] ************************** fatal: [localhost -> koha-bz23775]: FAILED! => {"changed": true, "cmd": "cd /kohadevbox/koha && yes | git bz apply 23775", "delta": "0:00:06.645085", "end": "2022-09-08 14:37:16.817592", "msg": "non-zero return code", "rc": 1, "start": "2022-09-08 14:37:10.172507", "stderr": ".git/rebase-apply/patch:80: trailing whitespace.\n \nwarning: 1 line adds whitespace errors.\n.git/rebase-apply/patch:80: trailing whitespace.\n \nwarning: 1 line applied after fixing whitespace errors.\nerror: Failed to merge in the changes.\nhint: Use 'git am --show-current-patch=diff' to see the failed patch\nPatch left in /tmp/Bug-23775-Claiming-a-serial-issue-doesnt-create-th-5vIy9g.patch", "stderr_lines": [".git/rebase-apply/patch:80: trailing whitespace.", " -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134062|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 152624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152624&action=edit Bug 23775: Claiming a serial issue doesn't create the next one Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'. Test Plan: -- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today -- 1) On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked 2) Then Home > Serials > Claims > Claims for <your_vendor_name> 3) Tick the checkbox of the row where the status is EXPECTED then 4) Click 'Send notification' 5) Notice the status of the row : it is now CLAIMED 6) To verify: Home > Serials > Serial collection information for <your_record_name> 7) Here the status is CLAIMED too but nothing happened around 8) Apply patch 9) Repeat from 2) to 6) 10) The status is still CLAIMED & the new serial with status EXPECTED is freshly generated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Assignee|jeremy.breuillard@biblibre. |julian.maurice@biblibre.com |com | Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patch cleaned and rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152624|0 |1 is obsolete| | --- Comment #9 from Sam Lau <samalau@gmail.com> --- Created attachment 152696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152696&action=edit Bug 23775: Claiming a serial issue doesn't create the next one Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'. Test Plan: -- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today -- 1) On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked 2) Then Home > Serials > Claims > Claims for <your_vendor_name> 3) Tick the checkbox of the row where the status is EXPECTED then 4) Click 'Send notification' 5) Notice the status of the row : it is now CLAIMED 6) To verify: Home > Serials > Serial collection information for <your_record_name> 7) Here the status is CLAIMED too but nothing happened around 8) Apply patch 9) Repeat from 2) to 6) 10) The status is still CLAIMED & the new serial with status EXPECTED is freshly generated Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152696|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152729&action=edit Bug 23775: Claiming a serial issue doesn't create the next one Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'. Test Plan: -- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today -- 1) On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked 2) Then Home > Serials > Claims > Claims for <your_vendor_name> 3) Tick the checkbox of the row where the status is EXPECTED then 4) Click 'Send notification' 5) Notice the status of the row : it is now CLAIMED 6) To verify: Home > Serials > Serial collection information for <your_record_name> 7) Here the status is CLAIMED too but nothing happened around 8) Apply patch 9) Repeat from 2) to 6) 10) The status is still CLAIMED & the new serial with status EXPECTED is freshly generated Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Working as expected, unit tests included, qa script happy. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org