[Bug 25314] New: Make OPAC facets collapse
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Bug ID: 25314 Summary: Make OPAC facets collapse Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org I propose making facets collapse by defualt. I don't think we need to continue to have 'Show less' and 'Show more' buttons. If everything is collapsed by default we can show everything within that list when it is expanded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 103957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103957&action=edit Bug 25314: Make OPAC facets collapse TO TEST: 1. Apply patch 2. Regenerate CSS (yarn build --view opac) 3. DO a search and look at the facets. They should be collapsed. 4. Try mousing over a facet heading and click, that list should appear. 5. Try clicking the heading again to make th facet disappear. 6. Play around with different limiters and make sure eveything works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103957|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 103958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103958&action=edit Bug 25314: Make OPAC facets collapse TO TEST: 1. Apply patch 2. Regenerate CSS (yarn build --view opac) 3. DO a search and look at the facets. They should be collapsed. 4. Try mousing over a facet heading and click, that list should appear. 5. Try clicking the heading again to make th facet disappear. 6. Play around with different limiters and make sure eveything works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This looks good! I wonder if we need a way for the library to define which facet(s) should be expanded by default? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103958|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 103997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103997&action=edit Bug 25314: Make OPAC facets collapse TO TEST: 1. Apply patch 2. Regenerate CSS (yarn build --view opac) 3. DO a search and look at the facets. They should be collapsed. 4. Try mousing over a facet heading and click, that list should appear. 5. Try clicking the heading again to make th facet disappear. 6. Play around with different limiters and make sure eveything works. 7. Check aria labels look correct and you can tab through facets without a keyboard. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Owen, Would this be a system preference where libraries could define which facets should be expanded by default? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- I anticipate that a lot of people will miss the 'by default expanded' facets. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 madamyk@ckls.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk@ckls.org --- Comment #7 from madamyk@ckls.org --- Created attachment 107447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107447&action=edit Failed QA: facets showing "<<<< HEAD" Tested this patch. Confirmed that without the patch, the search facets were all showing uncollapsed. I added the patch, and although the facets are now collapsed, they are also not appearing correctly. Each facet is displaying multiple times, with the text size changing each time it appears. There is also "======" and "<<<<<< HEAD" showing mixed in with the facets. See attachment "Bug25314.1" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 madamyk@ckls.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to madamyk from comment #7)
Created attachment 107447 [details] Failed QA: facets showing "<<<< HEAD"
Tested this patch. Confirmed that without the patch, the search facets were all showing uncollapsed.
I added the patch, and although the facets are now collapsed, they are also not appearing correctly. Each facet is displaying multiple times, with the text size changing each time it appears. There is also "======" and "<<<<<< HEAD" showing mixed in with the facets. See attachment "Bug25314.1"
Thanks for testing, this patch needs to be rebased for master. I will do so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103997|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 107448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107448&action=edit Bug 25314: Make OPAC facets collapse TO TEST: 1. Apply patch 2. Regenerate CSS (yarn build --view opac) 3. DO a search and look at the facets. They should be collapsed. 4. Try mousing over a facet heading and click, that list should appear. 5. Try clicking the heading again to make th facet disappear. 6. Play around with different limiters and make sure eveything works. 7. Check aria labels look correct and you can tab through facets without a keyboard. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107448|0 |1 is obsolete| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 107450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107450&action=edit Bug 25314: Make OPAC facets collapse TO TEST: 1. Apply patch 2. Regenerate CSS (yarn build --view opac) 3. DO a search and look at the facets. They should be collapsed. 4. Try mousing over a facet heading and click, that list should appear. 5. Try clicking the heading again to make th facet disappear. 6. Play around with different limiters and make sure eveything works. 7. Check aria labels look correct and you can tab through facets without a keyboard. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 107451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107451&action=edit Bug 25314: Add system pref to control expanding/collapsing facets TO TEST: 1. Apply patch 2. Regenerate CSS (yarn build --view opac), updatedatabase and restart_all 3. DO a search and look at the facets. They should be collapsed. 4. Try mousing over a facet heading and click, that list should appear. 5. Try clicking the heading again to make th facet disappear. 6. Play around with different limiters and make sure eveything works. 7. Check aria labels look correct and you can tab through facets without a keyboard. 8. Find the system pref OPACFacetsCollapseByDefault in OPAC > Features 9. Try toggling different facets and make sure they all expland/collapse correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107447|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107450|0 |1 is obsolete| | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 107452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107452&action=edit Bug 25314: Add system pref to control expanding/collapsing facets TO TEST: 1. Apply patch 2. Regenerate CSS (yarn build --view opac), updatedatabase and restart_all 3. DO a search and look at the facets. They should be collapsed. 4. Try mousing over a facet heading and click, that list should appear. 5. Try clicking the heading again to make th facet disappear. 6. Play around with different limiters and make sure eveything works. 7. Check aria labels look correct and you can tab through facets without a keyboard. 8. Find the system pref OPACFacetsCollapseByDefault in OPAC > Features 9. Try toggling different facets and make sure they all expland/collapse correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107451|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107450|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ivan.dziuba@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't look like this has been tested so I'm not sure why the status was changed to 'Signed-off', reseting this to 'Needs Signoff' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- (In reply to Lucas Gass from comment #13)
Doesn't look like this has been tested so I'm not sure why the status was changed to 'Signed-off', reseting this to 'Needs Signoff'
I tested this bug. It works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Ivan, In that case you need to also upload the signed-off patch as attachment and mark the initial one as obsolete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We can take care of adding the sign off line in QA this time, but signing off patches is easy with the sandboxes if you want to give it a try: https://wiki.koha-community.org/wiki/Sandboxes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- There are some issues with this patchset that I did not realize when I wrote it. Mainly related to the use of pseudo elements as checkmarks. Pseudo elements are semantically meaningless. From what I understand pseudo elements must only be used for decorative purposes only This would be an accessibility issue so I am failing QA on this until a better solution can be devised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|madamyk@ckls.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- I notice the Bootstrap Collapse component uses pseudo elements but adds the "aria-expanded" attribute: https://getbootstrap.com/docs/3.4/javascript/#collapse Would that solve the issue? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Might be nice to revisit this one :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lauren Denny <lauren_denny@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny@sil.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107450|0 |1 is obsolete| | Attachment #107452|0 |1 is obsolete| | --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192334&action=edit Bug 25314: Make OPAC facets collapse This patch implements collapsing facets using the Bootstrap Collapse component. To test, apply the patch and rebuild the OPAC CSS. 1. Clear your browser cache if necessary. 2. Using the sample data, go to Advanced Search in the OPAC. Check the "Books" checkbox under the "Item types" tab and submit. 3. In the left-hand sidebar you should see the facets you normally see, but now each one has an arrow icon to show whether the facet is expanded or collapsed. 4. All facets should be expanded by default. Adding expanded/collapsed settings to system preferences is out of scope for this bug. 5. Test expanding and collapsing facets, as well as the "Show more" link under each one. 6. Click the "Fiction" link under the "Collections" facet. When the refined search results load you clicked should now have a red "X" link next to "Fiction," which should no longer be a link. - Because "Fiction" is the only uption under the "Collections" facet, the facet is not collapsible. I reasoned that it would be important not to let a facet limitation disappear behind hidden facets. * The only way I know to do this in the template is to check for facets with only one option this has the possibly-unwanted side effect of making facets which haven't been selected but still only have one option not collapsible. In this example search "Holding libraries" and "Topics" show this. I'm open to suggestions on this! 7. Test with the displayFacetCount preference both enabled and disabled. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192334|0 |1 is obsolete| | --- Comment #21 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192341&action=edit Bug 25314: Make OPAC facets collapse This patch implements collapsing facets using the Bootstrap Collapse component. To test, apply the patch and rebuild the OPAC CSS. 1. Clear your browser cache if necessary. 2. Using the sample data, go to Advanced Search in the OPAC. Check the "Books" checkbox under the "Item types" tab and submit. 3. In the left-hand sidebar you should see the facets you normally see, but now each one has an arrow icon to show whether the facet is expanded or collapsed. 4. All facets should be expanded by default. Adding expanded/collapsed settings to system preferences is out of scope for this bug. 5. Test expanding and collapsing facets, as well as the "Show more" link under each one. 6. Click the "Fiction" link under the "Collections" facet. When the refined search results load you clicked should now have a red "X" link next to "Fiction," which should no longer be a link. - Because "Fiction" is the only uption under the "Collections" facet, the facet is not collapsible. I reasoned that it would be important not to let a facet limitation disappear behind hidden facets. * The only way I know to do this in the template is to check for facets with only one option this has the possibly-unwanted side effect of making facets which haven't been selected but still only have one option not collapsible. In this example search "Holding libraries" and "Topics" show this. I'm open to suggestions on this! 7. Test with the displayFacetCount preference both enabled and disabled. Sponsored-by: Athens County Public Libraries Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #22 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Awesome, I know many libraries will like this change a lot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 192597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192597&action=edit Screenshot of facets with custom search filter I quite like the changes, but wonder if we could make the custom search filters match in styling? the [x] is glued to the word and doesn't present in the same style as the facets. It's also missing a "tool tip" when hovering (might be a little out of scope, just noting). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ran yarn build and viewed in a new private window - so hopefully CSS was correctly applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192615&action=edit Bug 25314: (follow-up) Fix style of custom search filter clear button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192341|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193046&action=edit y# Attachment to Bug 25314 - Make OPAC facets collapse Bug 25314: Make OPAC facets collapse This patch implements collapsing facets using the Bootstrap Collapse component. To test, apply the patch and rebuild the OPAC CSS. 1. Clear your browser cache if necessary. 2. Using the sample data, go to Advanced Search in the OPAC. Check the "Books" checkbox under the "Item types" tab and submit. 3. In the left-hand sidebar you should see the facets you normally see, but now each one has an arrow icon to show whether the facet is expanded or collapsed. 4. All facets should be expanded by default. Adding expanded/collapsed settings to system preferences is out of scope for this bug. 5. Test expanding and collapsing facets, as well as the "Show more" link under each one. 6. Click the "Fiction" link under the "Collections" facet. When the refined search results load you clicked should now have a red "X" link next to "Fiction," which should no longer be a link. - Because "Fiction" is the only uption under the "Collections" facet, the facet is not collapsible. I reasoned that it would be important not to let a facet limitation disappear behind hidden facets. * The only way I know to do this in the template is to check for facets with only one option this has the possibly-unwanted side effect of making facets which haven't been selected but still only have one option not collapsible. In this example search "Holding libraries" and "Topics" show this. I'm open to suggestions on this! 7. Test with the displayFacetCount preference both enabled and disabled. Sponsored-by: Athens County Public Libraries Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192615|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193047&action=edit Bug 25314: (follow-up) Fix style of custom search filter clear button Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193046|0 |1 is obsolete| | Attachment #193047|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193048&action=edit Bug 25314: Make OPAC facets collapse This patch implements collapsing facets using the Bootstrap Collapse component. To test, apply the patch and rebuild the OPAC CSS. 1. Clear your browser cache if necessary. 2. Using the sample data, go to Advanced Search in the OPAC. Check the "Books" checkbox under the "Item types" tab and submit. 3. In the left-hand sidebar you should see the facets you normally see, but now each one has an arrow icon to show whether the facet is expanded or collapsed. 4. All facets should be expanded by default. Adding expanded/collapsed settings to system preferences is out of scope for this bug. 5. Test expanding and collapsing facets, as well as the "Show more" link under each one. 6. Click the "Fiction" link under the "Collections" facet. When the refined search results load you clicked should now have a red "X" link next to "Fiction," which should no longer be a link. - Because "Fiction" is the only uption under the "Collections" facet, the facet is not collapsible. I reasoned that it would be important not to let a facet limitation disappear behind hidden facets. * The only way I know to do this in the template is to check for facets with only one option this has the possibly-unwanted side effect of making facets which haven't been selected but still only have one option not collapsible. In this example search "Holding libraries" and "Topics" show this. I'm open to suggestions on this! 7. Test with the displayFacetCount preference both enabled and disabled. Sponsored-by: Athens County Public Libraries Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193049&action=edit Bug 25314: (follow-up) Fix style of custom search filter clear button Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for the speedy follow-up, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement modifies release notes| |the OPAC catalog search | |results page's facets menu, | |adding the ability to click | |on a facet heading to | |collapse it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #32 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42555 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 [Bug 42555] (Bug 25314 follow-up) Destroyed labels for customized facets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to stable |Needs documenting --- Comment #33 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backported to 25.05.x as this is an enhancement but I’m happy to revisit if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Irene Tortorella <i.tortorella@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.tortorella@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org