https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- This works well, I do wonder if there should be a public holds API to allow the user to change their own holds, but the modal works nicely. Two issues: The test should be in their own subtest as they are covering a new subroutine The opac-modrequest.pl script needs to check that the hold belongs to the signed in user, it is possible with these patches to alter another users hold via URL manipulation -- You are receiving this mail because: You are watching all bug changes.