[Bug 13458] New: Add new patron shows default / hardcoded patron categories after search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Bug ID: 13458 Summary: Add new patron shows default / hardcoded patron categories after search Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: david.roberts@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com After performing a patron search resulting in a list of patrons, clicking on New Patron shows a default list of patron categories, not the ones configured on the system. This happens in 3.18 and on Master. To reproduce: 1) Carry out a patron search for Smith (or other similar common name). This will bring up cgi-bin/koha/members/member.pl and a list of patrons. 2) Click on New Patron. 3) The list of categories will contain: Adult Patron, Child Patron, Professional Patron, Organisation, Staff Patron, Statistical Patron. These will display regardless of which patron categories are configured. This is the only page on which this happens - adding a patron on cgi-bin/koha/members/members-home.pl shows the correct list of configured patron categories. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We can confirm this bug still appears in 3.18.2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34680&action=edit Bug 13458: Display the correct patron categories Bug 9811 removes useful code. Actually the AddPatronLists pref is not sent to the template from members/member.pl. To fix this issue, we can use the existing not clean way, or compare the syspref value directly in the template. This second solution is implemented in this patch. Test plan: 1/ Set the AddPatronLists pref to 'specific' 2/ On the patron home page (members/members-home/pl), the patron search result page (members/member.pl after launching a search) and on the checkouts page/patron search result (circ/circulation.pl after searching a patron using the check out), verify that the patron category list is the specific ones. 3/ Test there are no regression with the AddPatronLists pref set to 'general'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Version|3.18 |master Depends on| |9811 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34680|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34682&action=edit Bug 13458: Display the correct patron categories Bug 9811 removes useful code. Actually the AddPatronLists pref is not sent to the template from members/member.pl. To fix this issue, we can use the existing not clean way, or compare the syspref value directly in the template. This second solution is implemented in this patch. Test plan: 1/ Set the AddPatronLists pref to 'specific' 2/ On the patron home page (members/members-home/pl), the patron search result page (members/member.pl after launching a search) and on the checkouts page/patron search result (circ/circulation.pl after searching a patron using the check out), verify that the patron category list is the specific ones. 3/ Test there are no regression with the AddPatronLists pref set to 'general'. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34682|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34707&action=edit [PASSED QA] Bug 13458: Display the correct patron categories Bug 9811 removes useful code. Actually the AddPatronLists pref is not sent to the template from members/member.pl. To fix this issue, we can use the existing not clean way, or compare the syspref value directly in the template. This second solution is implemented in this patch. Test plan: 1/ Set the AddPatronLists pref to 'specific' 2/ On the patron home page (members/members-home/pl), the patron search result page (members/member.pl after launching a search) and on the checkouts page/patron search result (circ/circulation.pl after searching a patron using the check out), verify that the patron category list is the specific ones. 3/ Test there are no regression with the AddPatronLists pref set to 'general'. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described and fixes the problem. Note: I am not sure if AddPatronLists makes sense - if you set it to general patron types, it still preselects the wrong category type (tried organization, a child patron category was selected). Also the name is confusiong nowadays with the Patron list feature. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13497 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
Note: I am not sure if AddPatronLists makes sense - if you set it to general patron types, it still preselects the wrong category type (tried organization, a child patron category was selected). Also the name is confusiong nowadays with the Patron list feature.
Agreed, cf bug 13497. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 CC| |mtj@kohaaloha.com --- Comment #8 from Mason James <mtj@kohaaloha.com> --- Contains string changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #10 from Magnus Enger <magnus@enger.priv.no> --- I am still seeing something similar to this on 3.16.7. But I don't have to do a search to see it. If I just go to the "Patrons" page (<intranet>/cgi-bin/koha/members/members-home.pl), the dropdown for adding a new patron is showing the default/hardcoded patron categories. Not sure if it is the same issue as this one or something new... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #11 from Magnus Enger <magnus@enger.priv.no> --- The setting of AddPatronLists does not affect the behaviour. The hardcoded categories are shown no matter what AddPatronLists is set to. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Magnus Enger from comment #11)
The setting of AddPatronLists does not affect the behaviour. The hardcoded categories are shown no matter what AddPatronLists is set to.
Yes, this pref does not work, I proposed to remove it on bug 13497. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Magnus Enger from comment #10)
I am still seeing something similar to this on 3.16.7. But I don't have to do a search to see it. If I just go to the "Patrons" page (<intranet>/cgi-bin/koha/members/members-home.pl), the dropdown for adding a new patron is showing the default/hardcoded patron categories. Not sure if it is the same issue as this one or something new...
You are right, it does not work for 3.16.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35555&action=edit Bug 13458: specific followup for 3.16.x members/member.tt uses patron-toolbar.inc which calls the Koha TT Plugin (for Preference). But this plugin is not loaded in the member.tt. It works on master and 3.18.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Magnus, could you please confirm this patch works for 3.16.x? (I tested it and it fixes the problem for 3.16.x) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #16 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #15)
Magnus, could you please confirm this patch works for 3.16.x?
(I tested it and it fixes the problem for 3.16.x)
I've tested this 2nd patch on 3.16.x. It works OK for me :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #17 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #16)
(In reply to Jonathan Druart from comment #15)
Magnus, could you please confirm this patch works for 3.16.x?
(I tested it and it fixes the problem for 3.16.x)
I've tested this 2nd patch on 3.16.x.
Pushed to 3.16.x, patch will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org