[Bug 29564] New: Use List::MoreUtils so SIP U16/Xenial does not break
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Bug ID: 29564 Summary: Use List::MoreUtils so SIP U16/Xenial does not break Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org patch to come... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 127969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127969&action=edit to test... - run prove t/00-load.t, see error - apply patch 00:07:08.189 koha_1 | # Failed test 'use C4::SIP::Sip::Configuration;' 00:07:08.189 koha_1 | # at t/00-load.t line 46. 00:07:08.189 koha_1 | # Tried to use 'C4::SIP::Sip::Configuration'. 00:07:08.189 koha_1 | # Error: "uniq" is not exported by the List::Util module - run prove t/00-load.t, see tests pass :0) https://bugs.koha-community.org/show_bug.cgi?id=29478 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127969|0 |1 is obsolete| | --- Comment #2 from Mason James <mtj@kohaaloha.com> --- Created attachment 127970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127970&action=edit Bug 29564: Use List::MoreUtils so SIP U16/Xenial does not break - run prove t/00-load.t, see error - apply patch 00:07:08.189 koha_1 | # Failed test 'use C4::SIP::Sip::Configuration;' 00:07:08.189 koha_1 | # at t/00-load.t line 46. 00:07:08.189 koha_1 | # Tried to use 'C4::SIP::Sip::Configuration'. 00:07:08.189 koha_1 | # Error: "uniq" is not exported by the List::Util module - run prove t/00-load.t, see tests pass :0) https://bugs.koha-community.org/show_bug.cgi?id=29478 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29264 Depends on| |29264 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | CC| |jonathan.druart+koha@gmail. | |com Keywords| |rel_20_11_candidate, | |rel_21_05_candidate, | |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127970|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 127986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127986&action=edit Bug 29564: Use List::MoreUtils so SIP U16/Xenial does not break - run prove t/00-load.t, see error - apply patch 00:07:08.189 koha_1 | # Failed test 'use C4::SIP::Sip::Configuration;' 00:07:08.189 koha_1 | # at t/00-load.t line 46. 00:07:08.189 koha_1 | # Tried to use 'C4::SIP::Sip::Configuration'. 00:07:08.189 koha_1 | # Error: "uniq" is not exported by the List::Util module - run prove t/00-load.t, see tests pass :0) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes using koha-testing-docker (KTD): - To start KTD using U16/xenial change KOHA_IMAGE=master-xenial in your .env file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127986|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 127987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127987&action=edit Bug 29564: Use List::MoreUtils so SIP U16/Xenial does not break - run prove t/00-load.t, see error - apply patch 00:07:08.189 koha_1 | # Failed test 'use C4::SIP::Sip::Configuration;' 00:07:08.189 koha_1 | # at t/00-load.t line 46. 00:07:08.189 koha_1 | # Tried to use 'C4::SIP::Sip::Configuration'. 00:07:08.189 koha_1 | # Error: "uniq" is not exported by the List::Util module - run prove t/00-load.t, see tests pass :0) https://bugs.koha-community.org/show_bug.cgi?id=29478 https://bugs.koha-community.org/show_bug.cgi?id=29564 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Our use case is simple so switching to List::MoreUtils:uniq shouldn't change the behavior. List::MoreUtils is already even in 19.11.x so it's not a new dep. Look good for QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 --- Comment #8 from Mason James <mtj@kohaaloha.com> --- hi, can we get this pushed back to 20.05.x branch please :0) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,20.11.12 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Early pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,20.11.12 |21.11.00,20.11.12,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,20.11.12,21.05.05 |21.11.00,20.11.12,21.05.07 released in| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.07, not .05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,20.11.12,21.05.07 |21.11.00,21.05.07,20.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.07,20.11.12 |21.11.00,21.05.07,20.11.12, released in| |20.05.18 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #13 from wainuiwitikapark@catalyst.net.nz --- Should this be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Nope, it was a regression due to bug 29264 so you dodged a bullet ^^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 --- Comment #15 from wainuiwitikapark@catalyst.net.nz --- (In reply to Victor Grousset/tuxayo from comment #14)
Nope, it was a regression due to bug 29264 so you dodged a bullet ^^
Cool, I thought that was the case. Thank you!! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org