[Bug 32408] New: Add an option to allow or disallow checkout when the outstanding amount is under noissuecharge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Bug ID: 32408 Summary: Add an option to allow or disallow checkout when the outstanding amount is under noissuecharge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: matthias.meusburger@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 11633 blocked SIP checkout when the patron has fines under the noissuescharge amount (define maximum amount withstanding before checkouts are blocked). Some libraries may want to allow SIP checkout in that case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add an option to allow or |Add an option to allow or |disallow checkout when the |disallow checkout when the |outstanding amount is under |outstanding amount is under |noissuecharge |noissuescharge -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add an option to allow or |Add an option to allow or |disallow checkout when the |disallow SIP checkout when |outstanding amount is under |the outstanding amount is |noissuescharge |under noissuescharge -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com Status|NEW |Needs Signoff --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 144447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144447&action=edit Subject: [PATCH] Bug 32408: Allow SIP checkout when the outstanding amount is under noissuescharge -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, this sounds more like a bug, if noissuecharge is actually the one to blame. Are we sure it's not AllowFineOverride that is to be blamed here? We found it blocking issues from the self check in the past. There is a capitalization issue here: + $message = 'Outstanding Fines block issue' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 --- Comment #3 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 144469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144469&action=edit Bug 32408: Allow SIP checkout when the outstanding amount is under noissuescharge Test plan: - Set up a patron with an outstanding amount under the noissuescharge syspref - Do a SIP checkout, and check that it is blocked - Apply the patch, and check that under_noissuescharge_block_checkout is enabled in SIPconfig.xml - Do a SIP checkout, and check that it is still blocked - Disable under_noissuescharge_block_checkout in SIPconfig.xml - Do a SIP checkout, and check that is allowed - Prove t/db_dependent/SIP/Transaction.t Additionaly, you can enable show_outstanding_amount in SIPconfig.xml to have the outstanding amount displayed on SIP checkout. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Thanks for your feedback, Katrin. The capitalization issue has been fixed in the updated patch, reverting to Needs Signoff. As for your other concern, the thing is that we may want to have a different behavior in SIP than in Koha. You can see for example the following parameters that have already been added to SIPconfig.xml: - holds_block_checkin (previously no_holds_checkin): Bug 25541: Add ability to prevent checkin via SIP of items with holds - holds_get_captured: Bug 29936: Add holds_get_captured option to sip config - prevcheckout_block_checkout: Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out document - overdues_block_checkout (previously disable_too_many_overdue) All of these parameters are designed to give the ability to have a specific behavior for SIP. The one introduced in this patch is no different. What do you think ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144447|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add an option to allow or |If a fine can be overridden |disallow SIP checkout when |on checkout in Koha, what |the outstanding amount is |should the SIP client do? |under noissuescharge | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144469|0 |1 is obsolete| | --- Comment #5 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 144473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144473&action=edit Bug 32408: Allow SIP to override a fine on checkout if a librarian can Test plan: - Set up a patron with an outstanding amount under the noissuescharge syspref - Check that you can override the fine on checkout in Koha - Do a SIP checkout, and check that it is blocked - Apply the patch, and check that override_fine_on_checkout is disabled in SIPconfig.xml - Do a SIP checkout, and check that it is still blocked - Enable override_fine_on_checkout in SIPconfig.xml - Do a SIP checkout, and check that is allowed - Prove t/db_dependent/SIP/Transaction.t Additionaly, you can enable show_outstanding_amount in SIPconfig.xml to have the outstanding amount displayed on SIP checkout. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 --- Comment #6 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- I have edited the bug title, the parameter used, the patch title and the test plan to make things more clear about what this patch does. Hope it helps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144473|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144474&action=edit Bug 32408: Allow SIP to override a fine on checkout if a librarian can Test plan: - Set up a patron with an outstanding amount under the noissuescharge syspref - Check that you can override the fine on checkout in Koha - Do a SIP checkout, and check that it is blocked - Apply the patch, and check that override_fine_on_checkout is disabled in SIPconfig.xml - Do a SIP checkout, and check that it is still blocked - Enable override_fine_on_checkout in SIPconfig.xml - Do a SIP checkout, and check that is allowed - Prove t/db_dependent/SIP/Transaction.t Additionaly, you can enable show_outstanding_amount in SIPconfig.xml to have the outstanding amount displayed on SIP checkout. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I worked through understanding this with Matthias and we tweaked it a little to clarify intention. It works well and is much clearer now too. No regressions, QA scripts are happy and it's well unit tested. Going straight for a PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. I just added this to the wiki page... It highlighted we already have a system preference override for this maybe: https://wiki.koha-community.org/wiki/SIP2_configuration#syspref_overrides_2 Does the above achieve the same thing.. now I'm a little confused.. I'll ask Kyle to weight in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What I thought was happening: * Koha and self check block checkout, if amount > noissuecharge * Koha asks for confirmation, if AllFinesNeedOverride = require, no matter the amount * Self check blocks checkout, if AllFinesNeedOverride = require, no matter the amount I had wrongly copied AllowFineOverride yesterday, but AllFinesNeedOverride was the one that I knew blocked checkouts. So my thinking here was that we are not changing the behaviour of noissuecharge, but that you actually want to override AllFinesNeedOverride. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 --- Comment #11 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Martin, Katrin, you were right, this can be done by overriding sysprefs. This table sums it up (the columns Under and Over are referring to Under noissuescharge or Over noissuescharge): +----------------------+-------------------+---------+---------+ | AllFinesNeedOverride | AllowFineOverride | Under | Over | +----------------------+-------------------+---------+---------+ | 0 | 0 | allowed | blocked | | 0 | 1 | allowed | blocked | | 1 | 0 | blocked | blocked | | 1 | 1 | blocked | blocked | +----------------------+-------------------+---------+---------+ Since I wrote unit tests to generate this table, I will update the patch so they can be added to Koha. However, the "allowed" cases are not returning any message to SIP, so I will open another BZ to have meaningful messages in those cases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144474|0 |1 is obsolete| | --- Comment #12 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 144496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144496&action=edit Bug 32408: Add unit tests to SIP checkout This patch adds unit tests to show SIP's behavior on checkout according to the AllFinesNeedOverride, AllowFineOverride and noissuescharge sysprefs, knowingly: +----------------------+-------------------+---------+---------+ | AllFinesNeedOverride | AllowFineOverride | Under | Over | +----------------------+-------------------+---------+---------+ | 0 | 0 | allowed | blocked | | 0 | 1 | allowed | blocked | | 1 | 0 | blocked | blocked | | 1 | 1 | blocked | blocked | +----------------------+-------------------+---------+---------+ (the columns Under and Over are referring to "under noissuescharge" and "over noissuescharge") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Cool, let's allow setting this things at the account level. That would be valuable in the long run. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |arthur.suzuki@biblibre.com Resolution|--- |FIXED --- Comment #17 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- enhancement + conflicts on application on 21.11.x. won't backport here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org