[Bug 7874] New: Templates::get_language generates lots of not defined warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7874 Priority: P5 - low Change sponsored?: --- Bug ID: 7874 Assignee: gmcharlt@gmail.com Summary: Templates::get_language generates lots of not defined warnings QA Contact: koha.sekjal@gmail.com Severity: minor Classification: Unclassified OS: All Reporter: colin.campbell@ptfs-europe.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha Was trying to track another error and found the get_languages routine in C4::Templates was giving lots of not defined errors in the logs. Looking closer found that the routine has obviously grown by accretion and was a) not always too clear in its intention b) was carelessly using undefined values c) was actually passing undef to other routines so they could in turn log warnings and return undef - only a few cycles wasted but it is a routine that could be called freqently. Have refactored the routine to address these concerns -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7874 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 8775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8775&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7874 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8775|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 8811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8811&action=edit Signed-off patch Having put my hands recently in this part of Koha code, I can confirm that this patch fix log warnings, and add clarity and conciseness. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7874 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7874 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: small patches, nothing to spot. passed QA I've tested language change still works after applying the patch by switching from en to fr-FR and then back to en -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7874 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7874 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch will be included in 3.6.5. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7874 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3754 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org