https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12374 Larry Baerveldt <larry@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larry@bywatersolutions.com --- Comment #14 from Larry Baerveldt <larry@bywatersolutions.com> --- There is very much a need for this tool. We at ByWater have needed this for so long, that I wrote my own script very much like this. To my mind, I have no problem with there being two scripts with overlapping functionality. They serve different purposes. Koha-dump is optimized for backups, plain and simple. Koha-mysqldump has a different purpose, and is geared for those who need to have the option to use the full range of mysqldump options. The fact that both scripts happen to share a common underlying program should not be a strike against this one. As for the issue of maintaining another script, I think that's inconsequential. The script itself is dead simple, and once added, I think will not require much in the way of ongoing support. As for modifying the existing koha-dump script to allow mysqldump parameters, I think that's actually the more complicated solution. You would have to add an option to skip the configs backup, override the output directory and automatic gzipping of output, override the chown and chmod commands etc. Honestly, it would be easier to add this script and simply modify koha-dump to call *this* one for the mysql dump portion. Also, if you were to modify koha-dump, it will probably require one or more command line option flags, to both override its normal function and to pass in the new options you might want to use. Koha-mysqldump is simpler, as after the initial command and site name, all remaining command line options are the same as for mysqldump. To reiterate my earlier comment about different functions, koha-dump's purpose is to do backups, koha-mysqldump's purpose is to simply put a wrapper around mysqldump. Yes, it would be possible to modify koha-dump to add this functionality, but my vote is for the new script. In my opinion, it's the simpler and easier way to add needed functionality, without making an existing script more complicated. - Larry -- You are receiving this mail because: You are watching all bug changes.