[Bug 22999] New: Switch two-column templates to Bootstrap grid: Circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Bug ID: 22999 Summary: Switch two-column templates to Bootstrap grid: Circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 20654 Target Milestone: --- The circulation (check out) template should be updated to use the Bootstrap grid. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91112&action=edit Bug 22999: Switch two-column templates to Bootstrap grid: Circulation This patch modifies the circulation page template to use the Bootstrap grid instead of YUI. To test, apply the patch and view the checkout page, confirming that it looks correct at various browser widths: - Check out (no patron) - Check out -> Patron search - Results - No results - Check out -> Patron selected - Can check out - Checkout blocked (renewal confirmation, item on hold, etc) - Can't check out (expired, restricted) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91113&action=edit Bug 22999: (follow-up) Indentation updates The markup changes require indentation updates. This patch contains indentation changes only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91112|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 91126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91126&action=edit Bug 22999: Switch two-column templates to Bootstrap grid: Circulation This patch modifies the circulation page template to use the Bootstrap grid instead of YUI. To test, apply the patch and view the checkout page, confirming that it looks correct at various browser widths: - Check out (no patron) - Check out -> Patron search - Results - No results - Check out -> Patron selected - Can check out - Checkout blocked (renewal confirmation, item on hold, etc) - Can't check out (expired, restricted) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91113|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 91127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91127&action=edit Bug 22999: (follow-up) Indentation updates The markup changes require indentation updates. This patch contains indentation changes only. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Tested using Firefox 67.0.4 on Ubuntu 18.04. Used manual browser resize as well as CTRL + SHIFT + M to test using different device screen sizes. No issues identified. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, Owen, but this one no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22999: Switch two-column templates to Bootstrap grid: Circulation Applying: Bug 22999: (follow-up) Indentation updates error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt). error: could not build fake ancestor Patch failed at 0001 Bug 22999: (follow-up) Indentation updates The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22999-follow-up-Indentation-updates-hr86eW.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91127|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91184&action=edit Bug 22999: (follow-up) Indentation updates The markup changes require indentation updates. This patch contains indentation changes only. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91126|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91239&action=edit Bug 22999: Switch two-column templates to Bootstrap grid: Circulation This patch modifies the circulation page template to use the Bootstrap grid instead of YUI. To test, apply the patch and view the checkout page, confirming that it looks correct at various browser widths: - Check out (no patron) - Check out -> Patron search - Results - No results - Check out -> Patron selected - Can check out - Checkout blocked (renewal confirmation, item on hold, etc) - Can't check out (expired, restricted) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91184|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91240&action=edit Bug 22999: (follow-up) Indentation updates The markup changes require indentation updates. This patch contains indentation changes only. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | Status|Signed Off |Passed QA CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25176 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25176 [Bug 25176] Styling problem with checkout form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch updates the release notes| |circulation page template | |to use the Bootstrap grid | |instead of YUI. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org