[Bug 20419] New: Current location not updated correctly on the return of a reserved item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 Bug ID: 20419 Summary: Current location not updated correctly on the return of a reserved item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: alexbuckley@catalyst.net.nz Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com At present when a reserved item is returned to a library branch which is not the branch set as the pickup location for the reserve then after clicking the 'Confirm hold and transfer' button on the return modal box the items current location is set to the pickup location even though the item is actually in transit. The current location of the item should be set as the branch that the item was returned to whilst in transit and only change to the pickup location when it checked in at the pickup location branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 72899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72899&action=edit Bug 20419 - Removed updating of holdingbranch in ModItemTransfer() The call to ModItem to update the holdingbranch has been removed from the ModItemTransfer function in C4/Items.pm this is because the holdingbranch should only be changed when the item is checked in at the destination branch not whilst it is in transit. Test plan: 1. Ensure the system preference AutomaticItemReturn is set to 'Dont' 2. Place a reserve on an item to be picked up at branch b 3. Check out the item to a different patron 4. Check the item back in to branch a 5. Select 'Confirm hold and transfer' button in the modal box that appears 6. Notice that the current location of the item visible on the item tab of the detail.pl page of the record is set as branch b even though the item is in transit 7. Apply patch 8. Restart apache2, memcached and plack (if it is enabled) 9. Repeat steps 1, 2, 3, 4, 5 and notice that the current location is set to branch a 10. Check the item in at branch b and notice that the current location of the item is now branch b Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal Summary|Current location not |Current location not |updated correctly on the |updated correctly on the |return of a reserved item |return of an item on hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Failed QA --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Please include unit tests when modifying C4 or Koha libraries. This prevents regression. It would be nice if they fail before the fix, and then pass after the fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley@catalyst.net.nz |hayleymapley@catalyst.net.n | |z CC| |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22097 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED CC| |aleisha@catalyst.net.nz --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I believe this has been fixed in master. Can someone else confirm that this is no longer a bug? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org