[Bug 18797] New: t/db_dependent/rollingloans.t is skipping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 Bug ID: 18797 Summary: t/db_dependent/rollingloans.t is skipping Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org t/db_dependent/rollingloans.t is need of a refactor using TestBuilder to correct its current lack of usefulness. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |ldjamison@marywood.edu, | |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good to me LOL ok 1 # skip Missing test borrower or item, skipping tests ok 2 # skip Missing test borrower or item, skipping tests ok 3 # skip Missing test borrower or item, skipping tests ok 4 # skip Missing test borrower or item, skipping tests ok 5 # skip Missing test borrower or item, skipping tests ok 6 # skip Missing test borrower or item, skipping tests ok 7 # skip Missing test borrower or item, skipping tests ok 8 # skip Missing test borrower or item, skipping tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marcel, yes that is the problem. The tests are never executed, data are not created. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73065&action=edit Bug 18797: Make rollingloans test useful TEST PLAN --------- 1) Run the following commands on a kohadevbox: kshell prove -v t/db_dependent/rollingloans.t exit -- all the tests were skipped, not useful! 2) Apply this patch 3) Redo step 1 -- all the tests run 4) Run qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73065|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 73137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73137&action=edit Bug 18797: Make rollingloans test useful TEST PLAN --------- 1) Run the following commands on a kohadevbox: kshell prove -v t/db_dependent/rollingloans.t exit -- all the tests were skipped, not useful! 2) Apply this patch 3) Redo step 1 -- all the tests run 4) Run qa test tools Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Combining SO/QA for simple unit test improvement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73294&action=edit Bug 18797: Create the biblioitem entry We need that since bug 19943 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org