[Bug 25526] New: Using Write Off Selected will not allow for a different dollar amount to be written off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Bug ID: 25526 Summary: Using Write Off Selected will not allow for a different dollar amount to be written off Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Using the Write Off Selected option in the Accounting Module, a user can not choose to write off a specific amount. If a user chooses to Write Off under the Actions button, then a specific amount can be written off as opposed to the full line item's amount. However, if the "Write Off Selected" is chosen a specific amount can not be typed in, Koha gives an error. 1. Have a fine on a Patron's account. 2. Choose the "Write off Selected" button 3. Enter an amount less than the amount owed by the patron. 4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Using Write Off Selected |Using Write Off Selected |will not allow for a |will not allow for a |different dollar amount to |different amount to be |be written off |written off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Severity|normal |major --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kelly, I can confirm the bug in master too - you have the form field to change the value, but you are not able to submit: You must collect a value greater than or equal to 2.00. Where 2.00 is the value I entered for write-off, not the total fine on the account. Updated severity a bit as I think we should fix this urgently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 105507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105507&action=edit Bug 25526: Allow write off selected of less than or equal to amount TEST PLAN: 1. Have a fine on a Patron's account. 2. Choose the "Write off Selected" button 3. Enter an amount less than the amount owed by the patron. 4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). 5. Apply patch 6. Again try to pay an amount less than the amount owed. 7. You should be able to pay it off. 8. Try paying an amount more than owed, you should still get an error. You shouldn't be able to write off more than the amount. 9. Make sure 'Pay selected' still works as it should. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105507|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 105528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105528&action=edit Bug 25526: Allow write off selected of less than or equal to amount TEST PLAN: 1. Have a fine on a Patron's account. 2. Choose the "Write off Selected" button 3. Enter an amount less than the amount owed by the patron. 4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). 5. Apply patch 6. Again try to pay an amount less than the amount owed. 7. You should be able to pay it off. 8. Try paying an amount more than owed, you should still get an error. You shouldn't be able to write off more than the amount. 9. Make sure 'Pay selected' still works as it should. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The proposed patch circumvents the serverside under-collection protection. To test: 1/ Disable javascript in the browser (in chrome you can do this via the developer tool > settings > disable Javascript) 2/ Attempt to pay part of a fine... enter an amount less than the 'amount being paid' into the 'amount tendered' box 3/ Without the patch, you would be faced with an undercollection error message (the yellow error box mentioned above) 4/ With the patch, you will not face any errors and the full payment amount will have been recorded against the accountable, not the lower amount you actually collected from the patron. Failing QA - Correct patch to follow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105625&action=edit Bug 25526: [ALTERNATIVE] Equality matching is case sensative TEST PLAN: 1. Have a fine on a Patron's account. 2. Choose the "Write off Selected" button 3. Enter an amount less than the amount owed by the patron. 4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). 5. Apply patch 6. Again try to writeoff an amount less than the amount owed. 7. You should be able to write it off. 8. Try paying an amount more than owed, you should still get an error. You shouldn't be able to write off more than the amount. 9. Follow the above steps via 'Pay selected' as aposed to 'Writeoff selected'. 10. You should not be able to 'Tender' less than the amount you have 'Paid'. 11. Disable Javascript and run through all the above steps. You should still be blocked where relevant. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105627&action=edit Bug 25526: Equality matching is case sensative TEST PLAN: 1. Have a fine on a Patron's account. 2. Choose the "Write off Selected" button 3. Enter an amount less than the amount owed by the patron. 4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). 5. Apply patch 6. Again try to writeoff an amount less than the amount owed. 7. You should be able to write it off. 8. Try paying an amount more than owed, you should still get an error. You shouldn't be able to write off more than the amount. 9. Follow the above steps via 'Pay selected' as aposed to 'Writeoff selected'. 10. You should not be able to 'Tender' less than the amount you have 'Paid'. 11. Disable Javascript and run through all the above steps. You should still be blocked where relevant. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105528|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105625|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bonus points.. the updated patch also fixes a related error. Test Plan 1/ Check the write-off permissions for the same scenarios and you will find the prior to this patch, they were not properly adhered to at the serverside -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105627|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105637&action=edit Bug 25526: Equality matching is case sensative TEST PLAN: 1. Have a fine on a Patron's account. 2. Choose the "Write off Selected" button 3. Enter an amount less than the amount owed by the patron. 4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). 5. Apply patch 6. Again try to writeoff an amount less than the amount owed. 7. You should be able to write it off. 8. Try paying an amount more than owed, you should still get an error. You shouldn't be able to write off more than the amount. 9. Follow the above steps via 'Pay selected' as aposed to 'Writeoff selected'. 10. You should not be able to 'Tender' less than the amount you have 'Paid'. 11. Disable Javascript and run through all the above steps. You should still be blocked where relevant. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com QA Contact|martin.renvoize@ptfs-europe |katrin.fischer@bsz-bw.de |.com | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works and fixes the bug, but the whole 'change calculation' still feels kludgy to me. I have filed bug 25746 with a suggestion to improve things (again). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105637|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105856&action=edit Bug 25526: Equality matching is case sensative TEST PLAN: 1. Have a fine on a Patron's account. 2. Choose the "Write off Selected" button 3. Enter an amount less than the amount owed by the patron. 4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). 5. Apply patch 6. Again try to writeoff an amount less than the amount owed. 7. You should be able to write it off. 8. Try paying an amount more than owed, you should still get an error. You shouldn't be able to write off more than the amount. 9. Follow the above steps via 'Pay selected' as aposed to 'Writeoff selected'. 10. You should not be able to 'Tender' less than the amount you have 'Paid'. 11. Disable Javascript and run through all the above steps. You should still be blocked where relevant. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00. 20.05.01 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |aleisha@catalyst.net.nz Version(s)|20.11.00. 20.05.01 |20.11.00. 20.05.01, released in| |19.11.07 --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net Version(s)|20.11.00. 20.05.01, |20.11.00. 20.05.01, released in|19.11.07 |19.11.07, 19.05.12 --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@koha-us.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org