[Bug 4941] New: Can't set branch in staff client when singleBranchMode is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Summary: Can't set branch in staff client when singleBranchMode is enabled Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Staff Client AssignedTo: paul.poulain@biblibre.com ReportedBy: camins@numismatics.org QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 Although the description of the syspref singleBranchMode implies that singleBranchMode is only relevant to the OPAC, in fact superlibrarians cannot change their branch on the staff client when it is set. Either the description of the syspref should be modified, or the syspref should be split into two, one that only impacts the OPAC, and one that only impacts the staff client. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Version|unspecified |rel_3_6 See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5053 --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> 2011-07-21 11:55:07 UTC --- I would contest that we shouldn't HAVE a singleBranchMode system preference. Rather, if only one branch is configured in the system, Koha should detect that, and not offer branch selection options. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> 2011-07-21 12:15:12 UTC --- I agree with Ian : SingleBranch is here to hide branch lists for the case of a single branch library (the list is useless) So, it shouldn't be here, and should just be detected through the number of lines in branches table. Having SingleBranch mode set and more than one branch sounds strange to me. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-02 15:58:48 UTC --- *** Bug 5053 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- This bug is still present in master as of 3.12 beta1. Although you can choose any branch when you're logging in, you can't change your library without logging out and logging in again. singleBranchMode blocks the form from appearing on the set library page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 7156 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|NEW |In Discussion --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paul Poulain from comment #2)
Having SingleBranch mode set and more than one branch sounds strange to me.
Same here, what's the point of having this pref enabled if you have more than 1 branch? (In reply to Ian Walls from comment #1)
I would contest that we shouldn't HAVE a singleBranchMode system preference. Rather, if only one branch is configured in the system, Koha should detect that, and not offer branch selection options.
What about this idea? singleBranchMode could be set in Auth.pm and sent to templates. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at the pref or doing a count of the branches in Auth.pm? Trying to understand :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #7)
Looking at the pref or doing a count of the branches in Auth.pm? Trying to understand :)
Count the branches from Auth and remove the pref everywhere. $template->param( singleBranchMode => Koha::Branches->search->count ); -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sounds good to me :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #10 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #8)
(In reply to Katrin Fischer from comment #7)
Looking at the pref or doing a count of the branches in Auth.pm? Trying to understand :)
Count the branches from Auth and remove the pref everywhere. $template->param( singleBranchMode => Koha::Branches->search->count );
Yes, that makes sense. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|paul.poulain@biblibre.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46311&action=edit Bug 4941: Make tests non DB dependent -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46312&action=edit Bug 4941: DB Changes -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46313&action=edit Bug 4941: Remove the singleBranchMode system preference The singleBranchMode system preference does not make sense. Either the install has only 1 library defined or several. In both case, we can easily guess the behavior to follow. So the idea of this patch is to replace the fetch of this syspref with a call to count the number of libraries defined in DB. Test plan: 1/ From a fresh Koha install, execute the DB entry to remove the pref. 2/ Define only 1 library 3/ Confirm that Koha behaves the same as before (try to change your library, look at the facets) 4/ Create another library (or more) and reinsert the pref and set it: insert into systempreferences (variable, value) values('singleBranchMode', 1); 5/ Execute the DB entry You should get a warning message. 6/ Repeat 3. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15294 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel@gmail.com --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Current master, on top of 15294, patch does not apply Applying: Bug 4941: Remove the singleBranchMode system preference fatal: sha1 information is lacking or useless (C4/Auth.pm). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Depends on| |15295 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bernardo Gonzalez Kriegel from comment #14)
Current master, on top of 15294, patch does not apply
Sorry, depends on bug 15295 too. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 7314 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46311|0 |1 is obsolete| | --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 46755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46755&action=edit Bug 4941: Make tests non DB dependent Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46312|0 |1 is obsolete| | --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 46756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46756&action=edit Bug 4941: DB Changes Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46313|0 |1 is obsolete| | --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 46757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46757&action=edit Bug 4941: Remove the singleBranchMode system preference The singleBranchMode system preference does not make sense. Either the install has only 1 library defined or several. In both case, we can easily guess the behavior to follow. So the idea of this patch is to replace the fetch of this syspref with a call to count the number of libraries defined in DB. Test plan: 1/ From a fresh Koha install, execute the DB entry to remove the pref. 2/ Define only 1 library 3/ Confirm that Koha behaves the same as before (try to change your library, look at the facets) 4/ Create another library (or more) and reinsert the pref and set it: insert into systempreferences (variable, value) values('singleBranchMode', 1); 5/ Execute the DB entry You should get a warning message. 6/ Repeat 3. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Does what it says, but will change behaviour for any Koha install that has 2 branches defined, One circulation, and this preference set. If that is an acceptable change, we might need to make sure this is noted well in the release notes. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The singleBranchMode system release notes| |preference has been | |removed. Koha instance with | |multiple libraries will not | |longer be able to use | |single branch mode. Single | |branch mode will be | |automatically enabled for | |Koha instances with only | |one library configured. CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46755|0 |1 is obsolete| | Attachment #46756|0 |1 is obsolete| | Attachment #46757|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47199&action=edit Bug 4941: Make tests non DB dependent Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47199|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47200&action=edit Bug 4941: Make tests non DB dependent Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Current status: Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47201&action=edit Bug 4940: DB Changes Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> http://bugs.koha-community.org/show_bug.cgi?id=4941 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47202&action=edit Bug 4941: Remove the singleBranchMode system preference The singleBranchMode system preference does not make sense. Either the install has only 1 library defined or several. In both case, we can easily guess the behavior to follow. So the idea of this patch is to replace the fetch of this syspref with a call to count the number of libraries defined in DB. Test plan: 1/ From a fresh Koha install, execute the DB entry to remove the pref. 2/ Define only 1 library 3/ Confirm that Koha behaves the same as before (try to change your library, look at the facets) 4/ Create another library (or more) and reinsert the pref and set it: insert into systempreferences (variable, value) values('singleBranchMode', 1); 5/ Execute the DB entry You should get a warning message. 6/ Repeat 3. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Does what it says, but will change behaviour for any Koha install that has 2 branches defined, One circulation, and this preference set. If that is an acceptable change, we might need to make sure this is noted well in the release notes. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org