[Bug 24499] New: sys pref EnhancedMessagingPreferences if set to Don't Allow does not even show within Patron Categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Bug ID: 24499 Summary: sys pref EnhancedMessagingPreferences if set to Don't Allow does not even show within Patron Categories Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The system preference EnhancedMessagingPreferences, which allows or doesn't allow for staff to see patron's messaging preferences. If Don't Allow, staff cannot see a specific patron's message preferences. If set to Don't Allow, this also hides the overall Messaging Preferences for Patron Categories in Admin, It would be extremely helpful for the Messaging Preferences to still be seen in the Admin - Patron Categories and a place to view what patrons are defaulting to be set up. Understanding that general staff can't see a specific patron's messaging preferences, but admin can see what patron categories are set up for. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it actually works right now as the feature was intended - it started out as a completely optional feature that was off by default. So all traces of the feature are hidden, when the feature is off. Then we decided to make it on by default - because everybody started using it. So maybe it's actually the pref description that is misleading? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- The issue here is that when off a patron can still receive notifications if their messaging preferences have been set, but you will not be able to see this in the interface. Additionally, the description implies that this simply prevents staff from editing the preferences, however, if you set the defaults for a category, then disable EnhancedMessagingPreferences the default are not respected/ Essentially, when this is disabled it can be hard to determine if a patron will receive a notice or not. Additionally - if EnhancedMessagingPreferencesOPAC is set to show, which also grants editing, but staff side is set to don't allow, it does not show (or allow editing) I think a solution would be a new preference: EnhancedMessaging - Send/Don't send patron circulation messages (holds, dues, predues,checkin,checkout) Reword other prefs to indicate they affect editing Show the settings for patrons on the staff client whether they can be edited or not and show default settings and allow their setting unless EnhancedMessaging is disabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We could also bring bug 20405 into the discussion - do we still need the EnhancedMessagingPreferences system preference or should we turn it always on? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20405 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|sys pref |System preference |EnhancedMessagingPreference |EnhancedMessagingPreference |s if set to Don't Allow |s if set to 'Don't allow' |does not even show within |doesn't even show within |Patron Categories |patron categories Version|19.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m --- Comment #4 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- I think there is two distinct points : 1/ The ability to define preferences 2/ Central activation/desactivation of notifications 1/ Should always be on (see bug 20405) 2/ Could be a preference system. Scripts that send notices must check if on before sending, whatever preferences are. This will allow to suspend temporarily notifications without changing parameters. At the moment, when preferences are set, if you disable EnhancedMessagingPreferences, you can't see how preferences are configured in admin interface, but notices are still sent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
From your comments, I decide to create a new syspref which show dialog alert on patron details (Patron messaging preferences section) but
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #5 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 129834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129834&action=edit New syspref EnhancedMessaging for clearer functionality Actually there is EnhancedMessagingPreferences that can be set on "Allow" or "Don't allow" to show or not show messaging preferences for patrons. But this syspref does not prevent notifications from being sent. prevent misc/cronjobs/advance_notices.pl script. EnhancedMessagingPreferences keep the same behavior I just took over preferences descriptions to make clearer context (on EnhancedMessagingPreferencesOPAC too). Test plan : 1 - Be sure to have a patron with a loan 2 - Also be sure to have a model on your library in "Notices & slips" 3 - Set max days for advance_notices on patron details table 4 - Then set EnhancedMessagingPreferences to "Allow" 5 - On Patron details you will see the table for settings notifications 6 - Run the misc/cronjobs/advance_notices.pl script manually 7 - The script find a notice and add a message in message_queue table 8 - Set now EnhancedMessagingPreferences to "Don't allow" 9 - Repeat the step 5, you don't see the table right now 10 - Repeat the step 6, same behavior, a message is created and stored 11 - Now apply this patch and launch updatedatabase.pl 12 - You will see the new syspref "EnhanceMessaging" 13 - If you want you can repeat steps 4 to 10 - same behavior again 14 - But now, you can set to "Don't send" on EnhancedMessaging 15 - See on patron details page, there is a dialog alert to inform 16 - Run again the step 6, normally it will send you a warn and no message was created or stored. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |thibaud.guillot@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Marius <marius.mandrescu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Marius <marius.mandrescu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129834|0 |1 is obsolete| | --- Comment #6 from Marius <marius.mandrescu@inlibro.com> --- Created attachment 145356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145356&action=edit New syspref EnhancedMessaging for clearer functionality Everything is fine in this pache. https://bugs.koha-community.org/show_bug.cgi?id=24499 Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
From your comments, I decide to create a new syspref which show dialog alert on patron details (Patron messaging preferences section) but
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 147411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147411&action=edit Bug 24499: New syspref EnhancedMessaging for clearer functionality Actually there is EnhancedMessagingPreferences that can be set on "Allow" or "Don't allow" to show or not show messaging preferences for patrons. But this syspref does not prevent notifications from being sent. prevent misc/cronjobs/advance_notices.pl script. EnhancedMessagingPreferences keep the same behavior I just took over preferences descriptions to make clearer context (on EnhancedMessagingPreferencesOPAC too). Test plan : 1 - Be sure to have a patron with a loan 2 - Also be sure to have a model on your library in "Notices & slips" 3 - Set max days for advance_notices on patron details table 4 - Then set EnhancedMessagingPreferences to "Allow" 5 - On Patron details you will see the table for settings notifications 6 - Run the misc/cronjobs/advance_notices.pl script manually 7 - The script find a notice and add a message in message_queue table 8 - Set now EnhancedMessagingPreferences to "Don't allow" 9 - Repeat the step 5, you don't see the table right now 10 - Repeat the step 6, same behavior, a message is created and stored 11 - Now apply this patch and launch updatedatabase.pl 12 - You will see the new syspref "EnhanceMessaging" 13 - If you want you can repeat steps 4 to 10 - same behavior again 14 - But now, you can set to "Don't send" on EnhancedMessaging 15 - See on patron details page, there is a dialog alert to inform 16 - Run again the step 6, normally it will send you a warn and no message was created or stored. Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Attachment #145356|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 147412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147412&action=edit Bug 24499: (QA follow-up) fix spelling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hi :) Thibaud: - fixed commit message not having the ticket number has prefix - fixed spelling in syspref text Marius: added back the rest of the commit message (description & test plan) that was lost. When signing off, one must amend the commit to add the Signed-off-by line after the existing stuff. Or some equivalent method. That's all from me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147412|0 |1 is obsolete| | --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 147413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147413&action=edit Bug 24499: (QA follow-up) fix spelling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21507 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Can the DB update be formatted a bit nicer please? Use installer/data/mysql/atomicupdate/skeleton.pl as an example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Does the bug description still fit with what the patch does? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21507 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
From your comments, I decide to create a new syspref which show dialog alert on patron details (Patron messaging preferences section) but
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147411|0 |1 is obsolete| | --- Comment #13 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 176059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176059&action=edit Bug 24499: New syspref EnhancedMessaging for clearer functionality Actually there is EnhancedMessagingPreferences that can be set on "Allow" or "Don't allow" to show or not show messaging preferences for patrons. But this syspref does not prevent notifications from being sent. prevent misc/cronjobs/advance_notices.pl script. EnhancedMessagingPreferences keep the same behavior I just took over preferences descriptions to make clearer context (on EnhancedMessagingPreferencesOPAC too). Test plan : 1 - Be sure to have a patron with a loan 2 - Also be sure to have a model on your library in "Notices & slips" 3 - Set max days for advance_notices on patron details table 4 - Then set EnhancedMessagingPreferences to "Allow" 5 - On Patron details you will see the table for settings notifications 6 - Run the misc/cronjobs/advance_notices.pl script manually 7 - The script find a notice and add a message in message_queue table 8 - Set now EnhancedMessagingPreferences to "Don't allow" 9 - Repeat the step 5, you don't see the table right now 10 - Repeat the step 6, same behavior, a message is created and stored 11 - Now apply this patch and launch updatedatabase.pl 12 - You will see the new syspref "EnhanceMessaging" 13 - If you want you can repeat steps 4 to 10 - same behavior again 14 - But now, you can set to "Don't send" on EnhancedMessaging 15 - See on patron details page, there is a dialog alert to inform 16 - Run again the step 6, normally it will send you a warn and no message was created or stored. Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147413|0 |1 is obsolete| | --- Comment #14 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 176060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176060&action=edit Bug 24499: (QA follow-up) fix spelling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #15 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 176061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176061&action=edit Bug 24499: (QA follow-up) fix atomic file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|System preference |Add new syspref |EnhancedMessagingPreference |EnhancedMessaging for |s if set to 'Don't allow' |central |doesn't even show within |activation/desactivation of |patron categories |notifications -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
From your comments, I decide to create a new syspref which show dialog alert on patron details (Patron messaging preferences section) but
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176059|0 |1 is obsolete| | --- Comment #16 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 186002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186002&action=edit Bug 24499: New syspref EnhancedMessaging for clearer functionality Actually there is EnhancedMessagingPreferences that can be set on "Allow" or "Don't allow" to show or not show messaging preferences for patrons. But this syspref does not prevent notifications from being sent. prevent misc/cronjobs/advance_notices.pl script. EnhancedMessagingPreferences keep the same behavior I just took over preferences descriptions to make clearer context (on EnhancedMessagingPreferencesOPAC too). Test plan : 1 - Be sure to have a patron with a loan 2 - Also be sure to have a model on your library in "Notices & slips" 3 - Set max days for advance_notices on patron details table 4 - Then set EnhancedMessagingPreferences to "Allow" 5 - On Patron details you will see the table for settings notifications 6 - Run the misc/cronjobs/advance_notices.pl script manually 7 - The script find a notice and add a message in message_queue table 8 - Set now EnhancedMessagingPreferences to "Don't allow" 9 - Repeat the step 5, you don't see the table right now 10 - Repeat the step 6, same behavior, a message is created and stored 11 - Now apply this patch and launch updatedatabase.pl 12 - You will see the new syspref "EnhanceMessaging" 13 - If you want you can repeat steps 4 to 10 - same behavior again 14 - But now, you can set to "Don't send" on EnhancedMessaging 15 - See on patron details page, there is a dialog alert to inform 16 - Run again the step 6, normally it will send you a warn and no message was created or stored. Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176060|0 |1 is obsolete| | --- Comment #17 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 186003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186003&action=edit Bug 24499: (QA follow-up) fix spelling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176061|0 |1 is obsolete| | --- Comment #18 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 186004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186004&action=edit Bug 24499: (QA follow-up) fix atomic file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- This appears to only affect advance_notices but the syspref name EnhancedMessaging implies it controls all messaging. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org