[Bug 4093] New: OPAC Suggestions List has extra column
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4093 Summary: OPAC Suggestions List has extra column Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com CC: henridamien@koha-fr.org Estimated Hours: 0.0 Change sponsored?: --- Created an attachment (id=1510) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1510) my suggestions in opac The 'my suggestions' page in the OPAC has a column for selecting items - but there are no checkboxes. Either the column and select links need to be removed or the checkboxes need to be added. Also there should be some control in place to prevent a user from deleting accepted suggestions. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4093 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |paul.poulain@biblibre.com --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2010-02-02 21:29:51 --- In the template that table cell is wrapped in <!-- TMPL_IF NAME="showcheckbox" --> ...but "showcheckbox" is not defined by any script in Koha that I can find. Hence the cell never shown. I can see how "showcheckbox" might be useful, as there are no other controls for display of the checkbox than whether or not there is a logged in user. It might be wise to introduce additional checks, like whether or not a particular suggestion has been accepted by the library. I would think it shouldn't be possible to delete a suggestion which has been accepted. Does the <!-- TMPL_IF NAME="showcheckbox" --> indicate some work in progress? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4093 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2010-02-03 16:13:13 --- Upping the severity of this because it is a loss of functionality: The patron cannot delete suggestions. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4093 tipaul <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|paul.poulain@biblibre.com |henridamien@koha-fr.org --- Comment #3 from tipaul <paul.poulain@biblibre.com> 2010-02-08 13:17:15 --- hdl ? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4093 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2010-02-08 16:10:53 --- Created an attachment (id=1579) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1579) Proposed fix Fix for Bug 4093, OPAC Suggestions List has extra column Looks like the check for <!-- TMPL_IF NAME="showcheckbox" --> was added in Garry Collum's patch for Bug 1607. According to the notes on that bug report the patch was pushed, but the code setting "showcheckbox" was subsequently removed from opac-suggestions.pl. This patch restores it. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4093 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> 2010-02-08 16:38:14 --- Pushed patch to HEAD for inclusion in 3.2. Please test and close. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4093 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com